Skip to content

Commit c27cc1f

Browse files
committed
MC-4129: Edit Panel Opens After Dragging & Dropping Content Types
- Fixing mftf build failures
1 parent ad27fc0 commit c27cc1f

5 files changed

+15
-11
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
<annotations>
105105
<features value="PageBuilder"/>
106106
<stories value="Slider"/>
107-
<title value="Collage Center - Can Inline Edit Slide Content When In Small Column"/>
107+
<title value="Collage Center - Can Inline Edit Slide Content When In 25 Percent Width Column"/>
108108
<description value="Verify that users are able to inline edit a collage center slide's content from the stage when the slide is in a 25 percent width column"/>
109109
<severity value="AVERAGE"/>
110110
<useCaseId value="MC-3228"/>
@@ -113,10 +113,9 @@
113113
<group value="pagebuilder-slide"/>
114114
<group value="pagebuilder-slideItemCollageCenter"/>
115115
</annotations>
116-
<actionGroup ref="chooseVisualSelectOption" after="dragContentTypeIntoContainer2" stepKey="enterAppearancePropertyExtended">
116+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
117117
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
118118
</actionGroup>
119-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
120119
<actionGroup ref="inlineEditWYSIWYGFromStageForSlideCollageAppearancesInSmallColumns" stepKey="inlineEdit">
121120
<argument name="contentType" value="PageBuilderSlideContentType"/>
122121
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
<annotations>
105105
<features value="PageBuilder"/>
106106
<stories value="Slider"/>
107-
<title value="Collage Left - Can Inline Edit Slide Content When In Small Column"/>
107+
<title value="Collage Left - Can Inline Edit Slide Content When In 25 Percent Width Column"/>
108108
<description value="Verify that users are able to inline edit a collage left slide's content from the stage when the slide is in a 25 percent width column"/>
109109
<severity value="AVERAGE"/>
110110
<useCaseId value="MC-3228"/>
@@ -113,10 +113,9 @@
113113
<group value="pagebuilder-slide"/>
114114
<group value="pagebuilder-slideItemCollageLeft"/>
115115
</annotations>
116-
<actionGroup ref="chooseVisualSelectOption" after="dragContentTypeIntoContainer2" stepKey="enterAppearancePropertyExtended">
116+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
117117
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
118118
</actionGroup>
119-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
120119
<actionGroup ref="inlineEditWYSIWYGFromStageForSlideCollageAppearancesInSmallColumns" stepKey="inlineEdit">
121120
<argument name="contentType" value="PageBuilderSlideContentType"/>
122121
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
<annotations>
105105
<features value="PageBuilder"/>
106106
<stories value="Slider"/>
107-
<title value="Collage Right - Can Inline Edit Slide Content When In Small Column"/>
107+
<title value="Collage Right - Can Inline Edit Slide Content When In 25 Percent Width Column"/>
108108
<description value="Verify that users are able to inline edit a collage right slide's content from the stage when the slide is in a 25 percent width column"/>
109109
<severity value="AVERAGE"/>
110110
<useCaseId value="MC-3228"/>
@@ -113,10 +113,9 @@
113113
<group value="pagebuilder-slide"/>
114114
<group value="pagebuilder-slideItemCollageRight"/>
115115
</annotations>
116-
<actionGroup ref="chooseVisualSelectOption" after="dragContentTypeIntoContainer2" stepKey="enterAppearancePropertyExtended">
116+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
117117
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
118118
</actionGroup>
119-
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
120119
<actionGroup ref="inlineEditWYSIWYGFromStageForSlideCollageAppearancesInSmallColumns" stepKey="inlineEdit">
121120
<argument name="contentType" value="PageBuilderSlideContentType"/>
122121
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,14 +179,18 @@
179179
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup2">
180180
<argument name="group" value="PageBuilderSliderContentType"/>
181181
</actionGroup>
182-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragContentTypeIntoContainerWithoutEditPanel">
182+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragContentTypeIntoContainer2">
183183
<argument name="contentType" value="PageBuilderSliderContentType"/>
184184
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
185185
<argument name="containerTargetIndex" value="2"/>
186186
</actionGroup>
187-
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="dragContentTypeIntoContainer2">
187+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditPanel">
188188
<argument name="section" value="SlideOnBackend"/>
189189
</actionGroup>
190+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
191+
<argument name="property" value="PageBuilderAppearance_Poster"/>
192+
</actionGroup>
193+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
190194
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide"/>
191195
<!-- Resize Column -->
192196
<comment userInput="Resize Column" stepKey="commentResizeColumn"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemContentTests.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,9 @@
504504
</actionGroup>
505505
<!-- Edit First Slide -->
506506
<comment userInput="Edit First Slide" stepKey="EditFirstSlide"/>
507+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="dragSliderIntoStage">
508+
<argument name="section" value="SlideOnBackend"/>
509+
</actionGroup>
507510
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterSlideTitle1">
508511
<argument name="property" value="PageBuilderSlideItemSlideName_Slide1"/>
509512
</actionGroup>

0 commit comments

Comments
 (0)