MC-5378: "Edit with Page Builder" button does not appear for Product or Category in IE11

davemacaulay · davemacaulay · commit c1b79825a176 · 2018-11-06T10:55:45.000Z
- Match on touch IE 11 user agent strings as well as standard
diff --git a/app/code/Magento/PageBuilder/Block/Adminhtml/Html/Head/BabelPolyfill.php b/app/code/Magento/PageBuilder/Block/Adminhtml/Html/Head/BabelPolyfill.php
@@ -17,8 +17,6 @@
  */
 class BabelPolyfill extends Template
 {
-    const IE_11_USER_AGENT = 'Trident/7.0; rv:11.0';
-
     /**
      * @var \Magento\PageBuilder\Model\ConfigInterface
      */
@@ -85,6 +83,7 @@ public function getCacheKeyInfo() : array
      */
     private function isIe11() : bool
     {
-        return strpos($this->httpHeader->getHttpUserAgent(), self::IE_11_USER_AGENT) !== false;
+        return strpos($this->httpHeader->getHttpUserAgent(), 'rv:11.0') !== false
+            && strpos($this->httpHeader->getHttpUserAgent(), 'Trident/7.0;') !== false;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@`
`17`	`17`	`*/`
`18`	`18`	`class BabelPolyfill extends Template`
`19`	`19`	`{`
`20`		`- const IE_11_USER_AGENT = 'Trident/7.0; rv:11.0';`
`21`		`-`
`22`	`20`	`/**`
`23`	`21`	`* @var \Magento\PageBuilder\Model\ConfigInterface`
`24`	`22`	`*/`
`@@ -85,6 +83,7 @@ public function getCacheKeyInfo() : array`
`85`	`83`	`*/`
`86`	`84`	`private function isIe11() : bool`
`87`	`85`	`{`
`88`		`- return strpos($this->httpHeader->getHttpUserAgent(), self::IE_11_USER_AGENT) !== false;`
	`86`	`+ return strpos($this->httpHeader->getHttpUserAgent(), 'rv:11.0') !== false`
	`87`	`+ && strpos($this->httpHeader->getHttpUserAgent(), 'Trident/7.0;') !== false;`
`89`	`88`	`}`
`90`	`89`	`}`