Skip to content

Commit bfca6a3

Browse files
dhaeckerdhaecker
committed
PB-266: Video background for Slide
- Cleaning up slide video background tests
1 parent 3998387 commit bfca6a3

8 files changed

+101
-95
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -314,9 +314,9 @@
314314
<argument name="index" defaultValue="1" type="string"/>
315315
</arguments>
316316
<waitForPageLoad stepKey="waitForPageLoad"/>
317-
<waitForElement selector="{{section.backgroundType(index, 'video')}}" stepKey="waitForVideoBackground"/>
318-
<waitForElement selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideo"/>
319-
<waitForElement selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="waitForFallbackImageVisible"/>
317+
<waitForElementVisible selector="{{section.backgroundType(index, 'video')}}" stepKey="waitForVideoBackground"/>
318+
<waitForElementVisible selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideo"/>
319+
<waitForElementVisible selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="waitForFallbackImageVisible"/>
320320
<grabAttributeFrom selector="{{section.videoBackgroundFallbackImageSource(index, fallbackImage.fileName)}}" userInput="src" stepKey="fallbackImageSource"/>
321321
<assertRegExp stepKey="assertFallbackImageValueContainsFileInformation">
322322
<expectedResult type="string">/.*\/(pub\/|\/)?media\/{{fallbackImage.path}}\/{{fallbackImage.fileName}}(_\d+)?\.{{fallbackImage.extension}}/</expectedResult>
@@ -399,7 +399,7 @@
399399
<argument name="index" defaultValue="1" type="string"/>
400400
</arguments>
401401
<waitForPageLoad stepKey="waitForPageLoad"/>
402-
<waitForElement selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
402+
<waitForElementVisible selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
403403
<waitForElement selector="{{section.videoBackgroundVideoUrl(index, videoUrl.renderedValue)}}" stepKey="waitForVideoUrl"/>
404404
<grabAttributeFrom selector="{{section.videoBackgroundVideoElement(index)}}" userInput="style" stepKey="videoStyle"/>
405405
<assertContains stepKey="assertVideoPlaying">

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeSliderActionGroup.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,18 @@
2929
<actionGroup name="validateBackgroundAttributesForSlide" extends="validateBackgroundAttributes">
3030
<remove keyForRemoval="waitForBackgroundAttachment"/>
3131
</actionGroup>
32+
<actionGroup name="inlineEditSlideOrBannerButton">
33+
<arguments>
34+
<argument name="section" defaultValue="SlideOnBackend"/>
35+
<argument name="text" defaultValue="{{PageBuilderSlideItemButtonText_Slide1.value}}" type="string"/>
36+
<argument name="index" defaultValue="1" type="string"/>
37+
<argument name="pageBuilderArea" defaultValue="" type="string"/>
38+
</arguments>
39+
<waitForElementVisible selector="{{section.editableButtonItemElement(index)}}" stepKey="waitForButtonVisible"/>
40+
<click selector="{{section.editableButtonItemElement(index)}}" stepKey="clickButtonToEdit"/>
41+
<pressKey selector="{{section.editableButtonItemElement(index)}}" userInput="{{text}}" stepKey="enterButtonText"/>
42+
<waitForElementVisible selector="{{section.buttonText(index, text)}}" stepKey="seeButtonText"/>
43+
<click selector="{{pageBuilderArea}}{{PageBuilderPanel.searchPanel}}" stepKey="unFocusLiveEdit"/>
44+
<waitForPageLoad stepKey="waitForUnFocus"/>
45+
</actionGroup>
3246
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowBackgroundAttributeTest.xml

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@
292292
<annotations>
293293
<features value="PageBuilder"/>
294294
<stories value="Row"/>
295-
<title value="Video Background - Validate Default Values"/>
295+
<title value="Row Video Background - Validate Default Values"/>
296296
<description value="Validate the default values for every attribute in the Video Background section for Row"/>
297297
<severity value="AVERAGE"/>
298298
<useCaseId value="PB-95"/>
@@ -1221,7 +1221,7 @@
12211221
<annotations>
12221222
<features value="PageBuilder"/>
12231223
<stories value="Row"/>
1224-
<title value="Validate Video Background Video Urls"/>
1224+
<title value="Row: Validate Video Background Video Urls"/>
12251225
<description value="Verify that the video background URL field is required, only accepts valid urls, and that the user can set an embedded or non-embedded video background to a YouTube or Vimeo video, or to a stored .mp4 video."/>
12261226
<severity value="BLOCKER"/>
12271227
<useCaseId value="PB-95"/>
@@ -1361,7 +1361,7 @@
13611361
<annotations>
13621362
<features value="PageBuilder"/>
13631363
<stories value="Row"/>
1364-
<title value="Verify User Can Switch Between Background Images and Videos for Rows"/>
1364+
<title value="Row: Verify User Can Switch Between Background Images and Videos"/>
13651365
<description value="Verify that a user can switch between background images and background videos."/>
13661366
<severity value="MAJOR"/>
13671367
<useCaseId value="PB-95"/>
@@ -1739,7 +1739,7 @@
17391739
<annotations>
17401740
<features value="PageBuilder"/>
17411741
<stories value="Row"/>
1742-
<title value="Validate Video Background Infinite Loop Enabled"/>
1742+
<title value="Row: Validate Video Background Infinite Loop Enabled"/>
17431743
<description value="Verify that the video background infinite loop attribute works as intended when enabled."/>
17441744
<severity value="BLOCKER"/>
17451745
<useCaseId value="PB-95"/>
@@ -1821,7 +1821,7 @@
18211821
<annotations>
18221822
<features value="PageBuilder"/>
18231823
<stories value="Row"/>
1824-
<title value="Validate Video Background Infinite Loop Disabled"/>
1824+
<title value="Row: Validate Video Background Infinite Loop Disabled"/>
18251825
<description value="Verify that the video background infinite loop attribute works as intended when disabled."/>
18261826
<severity value="BLOCKER"/>
18271827
<useCaseId value="PB-95"/>
@@ -1877,7 +1877,7 @@
18771877
<annotations>
18781878
<features value="PageBuilder"/>
18791879
<stories value="Row"/>
1880-
<title value="Validate Video Background Play Only When Visible Enabled"/>
1880+
<title value="Row: Validate Video Background Play Only When Visible Enabled"/>
18811881
<description value="Verify that the video background play only when visible attribute works as intended when enabled."/>
18821882
<severity value="CRITICAL"/>
18831883
<useCaseId value="PB-95"/>
@@ -1980,7 +1980,7 @@
19801980
<annotations>
19811981
<features value="PageBuilder"/>
19821982
<stories value="Row"/>
1983-
<title value="Validate Video Background Play Only When Visible Disabled"/>
1983+
<title value="Row: Validate Video Background Play Only When Visible Disabled"/>
19841984
<description value="Verify that the video background play only when visible attribute works as intended when disabled."/>
19851985
<severity value="CRITICAL"/>
19861986
<useCaseId value="PB-95"/>
@@ -2012,7 +2012,6 @@
20122012
<!-- Set Large Min Height on Row 1 -->
20132013
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage1">
20142014
<argument name="contentType" value="PageBuilderRowContentType"/>
2015-
<argument name="contentTypeIndex" value="1"/>
20162015
</actionGroup>
20172016
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty1">
20182017
<argument name="property" value="PageBuilderMinHeightProperty_500px"/>
@@ -2126,7 +2125,7 @@
21262125
<annotations>
21272126
<features value="PageBuilder"/>
21282127
<stories value="Row"/>
2129-
<title value="Validate Video Background Lazy Load Enabled"/>
2128+
<title value="Row: Validate Video Background Lazy Load Enabled"/>
21302129
<description value="Verify that the video background lazy load attribute works as intended when enabled."/>
21312130
<severity value="CRITICAL"/>
21322131
<useCaseId value="PB-95"/>
@@ -2165,7 +2164,7 @@
21652164
<annotations>
21662165
<features value="PageBuilder"/>
21672166
<stories value="Row"/>
2168-
<title value="Validate Video Background Lazy Load Disabled"/>
2167+
<title value="Row: Validate Video Background Lazy Load Disabled"/>
21692168
<description value="Verify that the video background lazy load attribute works as intended when disabled."/>
21702169
<severity value="CRITICAL"/>
21712170
<useCaseId value="PB-95"/>
@@ -2204,7 +2203,7 @@
22042203
<annotations>
22052204
<features value="PageBuilder"/>
22062205
<stories value="Row"/>
2207-
<title value="Validate Video Background Aspect Ratio"/>
2206+
<title value="Row: Validate Video Background Aspect Ratio"/>
22082207
<description value="Verify that the video background aspect ratio is maintained in each appearance."/>
22092208
<severity value="BLOCKER"/>
22102209
<useCaseId value="PB-95"/>
@@ -2290,7 +2289,6 @@
22902289
</actionGroup>
22912290
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
22922291
<!-- Validate Storefront -->
2293-
<amOnUrl url="{{_ENV.MAGENTO_BASE_URL}}" stepKey="goBackToMagento"/>
22942292
<actionGroup ref="NavigateToStorefrontForCreatedPageActionGroup" stepKey="navigateToStorefront">
22952293
<argument name="page" value="$$createCMSPage.identifier$$"/>
22962294
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@
780780
<features value="PageBuilder"/>
781781
<stories value="Slider"/>
782782
<title value="Verify Collage Center Slide Renders When Video Isn't Loaded and There's No Fallback Image"/>
783-
<description value="Validate that the Row renders correctly when the video background video hasn't loaded and there is no fallback image."/>
783+
<description value="Validate that the slide renders correctly when the video background video hasn't loaded and there is no fallback image."/>
784784
<severity value="BLOCKER"/>
785785
<useCaseId value="PB-266"/>
786786
<testCaseId value="MC-31849"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@
657657
<features value="PageBuilder"/>
658658
<stories value="Slider"/>
659659
<title value="Verify Collage Left Slide Renders When Video Isn't Loaded and There's No Fallback Image"/>
660-
<description value="Validate that the Row renders correctly when the video background video hasn't loaded and there is no fallback image."/>
660+
<description value="Validate that the slide renders correctly when the video background video hasn't loaded and there is no fallback image."/>
661661
<severity value="BLOCKER"/>
662662
<useCaseId value="PB-266"/>
663663
<testCaseId value="MC-31847"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@
558558
<features value="PageBuilder"/>
559559
<stories value="Slider"/>
560560
<title value="Verify Collage Right Slide Renders When Video Isn't Loaded and There's No Fallback Image"/>
561-
<description value="Validate that the Row renders correctly when the video background video hasn't loaded and there is no fallback image."/>
561+
<description value="Validate that the slide renders correctly when the video background video hasn't loaded and there is no fallback image."/>
562562
<severity value="BLOCKER"/>
563563
<useCaseId value="PB-266"/>
564564
<testCaseId value="MC-31851"/>

0 commit comments

Comments
 (0)