Skip to content

Commit bdc26e8

Browse files
anthoulaanthoula
committed
MC-5079: Add Box Sizing to Storefront Styles (Border & Height Storefront Issues)
- add new tests to assert slider and slide item with borders and padding is equal to min height - add new slider and slide item css selectors
1 parent 4c62d11 commit bdc26e8

File tree

3 files changed

+105
-0
lines changed

3 files changed

+105
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
<section name="SliderOnStage">
3838
<element name="all" type="button" selector="div[data-role=slider]"/>
3939
<element name="base" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]" parameterized="true"/>
40+
<element name="containerCSS" type="text" selector="[data-role=slider] .slider-container"/>
4041
<element name="hidden" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
4142
<element name="notHidden" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
4243
<element name="slideNavigationDot" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]//div[contains(@class,'navigation-dot')][{{arg2}}]" parameterized="true"/>
@@ -69,6 +70,7 @@
6970
<element name="base" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]" parameterized="true"/>
7071
<element name="baseJS" type="button" selector="document.querySelectorAll('[data-role=slide] div.pagebuilder-slide-wrapper')[{{arg1}} - 1]" parameterized="true"/>
7172
<element name="wrapperJS" type="button" selector="document.querySelectorAll('[data-role=slide] div.pagebuilder-slide-wrapper')[{{arg1}} - 1]" parameterized="true"/>
73+
<element name="wrapperCSS" type="button" selector="[data-role=slide] .pagebuilder-slide-wrapper"/>
7274
<element name="overlayJS" type="button" selector="document.querySelectorAll('[data-role=slide] div.pagebuilder-overlay')[{{arg1}} - 1]" parameterized="true"/>
7375
<element name="slickSlideIndex" type="text" selector="[data-slick-index='{{arg1}}']" parameterized="true"/>
7476
<element name="computedBoxSizing" type="button" selector="return window.getComputedStyle(document.querySelector('[data-role=slide]')).boxSizing"/>
@@ -126,6 +128,7 @@
126128
<element name="base" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]" parameterized="true"/>
127129
<element name="emptySlide" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='content'][contains(@class,'pagebuilder-empty-slide') and text()='Edit Slide Text']" parameterized="true"/>
128130
<element name="wrapperJS" type="button" selector="document.querySelectorAll('[data-role=slider] div.pagebuilder-slide-wrapper')[{{arg1}} - 1]" parameterized="true"/>
131+
<element name="wrapperCSS" type="button" selector="[data-role=slider] .pagebuilder-slide-wrapper"/>
129132
<element name="overlayJS" type="button" selector="document.querySelectorAll('[data-role=slider] div.pagebuilder-overlay')[{{arg1}} - 1]" parameterized="true"/>
130133
<element name="editableButtonItemElement" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//a[@data-element='button']//span[contains(@contenteditable, 'true')]" parameterized="true"/>
131134
<element name="imageSourceByIndex" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]/div[contains(@style,'{{arg2}}')]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,50 @@
554554
<seeElement selector="{{SlideOnFrontend.margins('1', PageBuilderMarginsPropertyDefault.value)}}" stepKey="seeMarginsStorefront"/>
555555
<seeElement selector="{{SlideOnFrontend.posterPadding('1', PageBuilderPaddingProperty40.value)}}" stepKey="seePaddingStorefront"/>
556556
</test>
557+
<test name="SlideItemWithBordersAndPaddingEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
558+
<annotations>
559+
<features value="PageBuilder"/>
560+
<stories value="Slider"/>
561+
<title value="Slide Item - Height is equal to min height"/>
562+
<description value="A user can see Slide item height with borders and padding is equal to min height"/>
563+
<severity value="CRITICAL"/>
564+
<useCaseId value="MC-5079"/>
565+
<testCaseId value="MC-5792"/>
566+
<group value="pagebuilder"/>
567+
<group value="pagebuilder-slide"/>
568+
<group value="pagebuilder-slideItemCommon"/>
569+
</annotations>
570+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
571+
<argument name="contentType" value="PageBuilderSliderContentType"/>
572+
</actionGroup>
573+
<actionGroup ref="expandPageBuilderPanelGroup" after="enterPageTitle" stepKey="expandGroup">
574+
<argument name="group" value="PageBuilderSliderContentType"/>
575+
</actionGroup>
576+
<actionGroup ref="dragContentTypeToStage" after="commentConfigureContentType" stepKey="dragContentTypeToStage">
577+
<argument name="contentType" value="PageBuilderSliderContentType"/>
578+
</actionGroup>
579+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" after="dragContentTypeToStage" stepKey="openEditPanel">
580+
<argument name="section" value="SlideOnBackend"/>
581+
</actionGroup>
582+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
583+
<argument name="property" value="PageBuilderSlideItemMinimumHeight_300"/>
584+
</actionGroup>
585+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
586+
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
587+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
588+
</actionGroup>
589+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
590+
<argument name="content" value="{{SlideOnBackend.wrapperCSS}}"/>
591+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
592+
</actionGroup>
593+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
594+
<argument name="contentType" value="PageBuilderSliderContentType"/>
595+
</actionGroup>
596+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
597+
<argument name="content" value="{{SlideOnFrontend.wrapperCSS}}"/>
598+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
599+
</actionGroup>
600+
</test>
557601
<test name="SlideItemMoveSlideItemsToRearrange">
558602
<annotations>
559603
<features value="PageBuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,64 @@
556556
<waitForPageLoad stepKey="waitForPageLoad4"/>
557557
<seeElement selector="{{SlideOnFrontend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentStorefront"/>
558558
</test>
559+
<test name="SliderWithBordersAndPaddingEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
560+
<annotations>
561+
<features value="PageBuilder"/>
562+
<stories value="Slider"/>
563+
<title value="Slider - Height is equal to min height"/>
564+
<description value="A user can see Slider height with borders and padding is equal to min height"/>
565+
<severity value="CRITICAL"/>
566+
<useCaseId value="MC-5079"/>
567+
<testCaseId value="MC-5779"/>
568+
<group value="pagebuilder"/>
569+
<group value="pagebuilder-slide"/>
570+
<group value="pagebuilder-sliderCommon"/>
571+
</annotations>
572+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
573+
<argument name="contentType" value="PageBuilderSliderContentType"/>
574+
</actionGroup>
575+
<actionGroup ref="expandPageBuilderPanelGroup" after="enterPageTitle" stepKey="expandGroup">
576+
<argument name="group" value="PageBuilderSliderContentType"/>
577+
</actionGroup>
578+
<actionGroup ref="dragContentTypeToStage" after="commentConfigureContentType" stepKey="dragContentTypeToStage">
579+
<argument name="contentType" value="PageBuilderSliderContentType"/>
580+
</actionGroup>
581+
<click selector="{{PageBuilderPanel.searchPanel}}" after="dragContentTypeToStage" stepKey="unFocusSlide"/>
582+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditPanel">
583+
<argument name="contentType" value="PageBuilderSliderContentType"/>
584+
</actionGroup>
585+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
586+
<argument name="property" value="PageBuilderSliderMinHeight_Default"/>
587+
</actionGroup>
588+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" after="saveEditPanelSettings" stepKey="openSlideItemEditPanel">
589+
<argument name="section" value="SlideOnBackend"/>
590+
</actionGroup>
591+
<actionGroup ref="fillSlideOutPanelFieldGeneral" after="openSlideItemEditPanel" stepKey="enterMinHeightPropertySlideItem">
592+
<argument name="property" value="PageBuilderSlideItemMinimumHeight_100"/>
593+
</actionGroup>
594+
<actionGroup ref="saveEditPanelSettings" after="enterMinHeightPropertySlideItem" stepKey="saveEditPanelSettings2"/>
595+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
596+
<argument name="content" value="{{SliderOnStage.containerCSS}}"/>
597+
<argument name="height" value="PageBuilderSliderMinHeight_Default"/>
598+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
599+
<argument name="padding" value="PageBuilderPaddingProperty10"/>
600+
</actionGroup>
601+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
602+
<argument name="content" value="{{SliderOnStage.containerCSS}}"/>
603+
<argument name="height" value="PageBuilderSliderMinHeight_Default"/>
604+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
605+
<argument name="padding" value="PageBuilderPaddingProperty10"/>
606+
</actionGroup>
607+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
608+
<argument name="contentType" value="PageBuilderSliderContentType"/>
609+
</actionGroup>
610+
<actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
611+
<argument name="content" value="{{SliderOnFrontend.all}}"/>
612+
<argument name="height" value="PageBuilderSliderMinHeight_Default"/>
613+
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
614+
<argument name="padding" value="PageBuilderPaddingProperty10"/>
615+
</actionGroup>
616+
</test>
559617
<test name="SliderMoveSlider">
560618
<annotations>
561619
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)