Skip to content

Commit bc89af1

Browse files
committed
#514: User sees content snapshot on Category Page in Admin Panel - Removed setStageOverlay method
1 parent df50e84 commit bc89af1

File tree

3 files changed

+3
-22
lines changed

3 files changed

+3
-22
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/wysiwyg.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ define([
9393
}, this.disableDomObserver.bind(this));
9494

9595
if (this.wysiwygConfigData()['pagebuilder_stage_overlay']) {
96-
this.pageBuilder.setStageOverlay(true);
96+
this.pageBuilder.hasStageOverlay(true);
9797
}
9898
}
9999

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder.js

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/page-builder.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ export default class PageBuilder implements PageBuilderInterface {
3636
public wrapperStyles: KnockoutObservable<{[key: string]: string}> = ko.observable({});
3737
public isAllowedTemplateSave: boolean;
3838
public isAllowedTemplateApply: boolean;
39+
public hasStageOverlay: KnockoutObservable<boolean> = ko.observable(false);
3940
private previousWrapperStyles: {[key: string]: string} = {};
4041
private previousPanelHeight: number;
41-
private hasStageOverlay: KnockoutObservable<boolean> = ko.observable(false);
4242

4343
constructor(config: any, initialValue: string) {
4444
Config.setConfig(config);
@@ -191,15 +191,6 @@ export default class PageBuilder implements PageBuilderInterface {
191191
return saveAsTemplate(this.stage);
192192
}
193193

194-
/**
195-
* Enable overlay for stage element
196-
*
197-
* @param {boolean} flag
198-
*/
199-
public setStageOverlay(flag: boolean): void {
200-
this.hasStageOverlay(flag);
201-
}
202-
203194
/**
204195
* Preload all templates into the window to reduce calls later in the app
205196
*

0 commit comments

Comments
 (0)