MC-4290:Alignment Doesn't Work For Slide, Banners, & Text Placeholders & for Slide Content & Banner Poster Content

Hwashiang Yu · Hwashiang Yu · commit bc3550b8ebc7 · 2018-12-04T17:02:06.000-06:00
- Removed text-align from slide, text, and banner
- Fixed static attribute not applied on initial drop
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/banner/_poster.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/banner/_poster.less
@@ -9,7 +9,6 @@
 
 .pagebuilder-banner-wrapper {
     .pagebuilder-poster-content {
-        text-align: center;
         width: 100%;
     }
 
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_collage-center.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_collage-center.less
@@ -25,7 +25,6 @@
 
             .pagebuilder-empty-slide {
                 padding: 30px;
-                text-align: left;
             }
         }
     }
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_collage-left.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_collage-left.less
@@ -23,7 +23,6 @@
 
             .pagebuilder-empty-slide {
                 padding: 30px;
-                text-align: left;
             }
         }
     }
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_collage-right.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_collage-right.less
@@ -24,7 +24,6 @@
 
             .pagebuilder-empty-slide {
                 padding: 30px;
-                text-align: left;
             }
         }
     }
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_default.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_default.less
@@ -66,7 +66,6 @@
             left: 0;
             pointer-events: none;
             position: absolute;
-            text-align: center;
             top: 0;
             width: 100%;
         }
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_poster.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/slide/_poster.less
@@ -19,7 +19,6 @@
 
         .inline-wysiwyg-textarea,
         .wysiwyg-container {
-            text-align: center;
             width: 100%;
         }
     }
@@ -36,8 +35,7 @@
         justify-content: center;
 
         .pagebuilder-poster-content {
-            max-width: 100%;
-            text-align: center;
+            width: 100%;
         }
     }
 }
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/text/_default.less b/app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/text/_default.less
@@ -28,10 +28,11 @@
         min-height: 50px;
 
         + .placeholder-text {
-            left: 5px;
+            height: 0;
+            line-height: 0;
             pointer-events: none;
-            position: absolute;
-            top: 5px;
+            position: relative;
+            top: -50px;
         }
     }
     > .mce-edit-focus {
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/observable-updater.js b/app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/observable-updater.js
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/observable-updater.ts b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/observable-updater.ts
@@ -150,7 +150,12 @@ export default class ObservableUpdater {
             if ("read" === attributeConfig.persistence_mode) {
                 continue;
             }
-            let value = data[attributeConfig.var];
+            let value;
+            if (!!attributeConfig.static) {
+                value = attributeConfig.value;
+            } else {
+                value = data[attributeConfig.var];
+            }
             const converter = this.converterResolver(attributeConfig);
             if (this.converterPool.get(converter)) {
                 value = this.converterPool.get(converter).toDom(attributeConfig.var, data);
diff --git a/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/banner/_poster.less b/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/banner/_poster.less
@@ -9,7 +9,6 @@
 
 .pagebuilder-banner-wrapper {
     .pagebuilder-poster-content {
-        text-align: center;
         width: 100%;
     }
 }
diff --git a/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/slide/_poster.less b/app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/slide/_poster.less
@@ -9,7 +9,6 @@
 
 .pagebuilder-slide-wrapper {
     .pagebuilder-poster-content {
-        text-align: center;
         width: 100%;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`
`10`	`10`	`.pagebuilder-banner-wrapper {`
`11`	`11`	`.pagebuilder-poster-content {`
`12`		`- text-align: center;`
`13`	`12`	`width: 100%;`
`14`	`13`	`}`
`15`	`14`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@`
`25`	`25`
`26`	`26`	`.pagebuilder-empty-slide {`
`27`	`27`	`padding: 30px;`
`28`		`- text-align: left;`
`29`	`28`	`}`
`30`	`29`	`}`
`31`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`
`24`	`24`	`.pagebuilder-empty-slide {`
`25`	`25`	`padding: 30px;`
`26`		`- text-align: left;`
`27`	`26`	`}`
`28`	`27`	`}`
`29`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`
`25`	`25`	`.pagebuilder-empty-slide {`
`26`	`26`	`padding: 30px;`
`27`		`- text-align: left;`
`28`	`27`	`}`
`29`	`28`	`}`
`30`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@`
`66`	`66`	`left: 0;`
`67`	`67`	`pointer-events: none;`
`68`	`68`	`position: absolute;`
`69`		`- text-align: center;`
`70`	`69`	`top: 0;`
`71`	`70`	`width: 100%;`
`72`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`
`20`	`20`	`.inline-wysiwyg-textarea,`
`21`	`21`	`.wysiwyg-container {`
`22`		`- text-align: center;`
`23`	`22`	`width: 100%;`
`24`	`23`	`}`
`25`	`24`	`}`
`@@ -36,8 +35,7 @@`
`36`	`35`	`justify-content: center;`
`37`	`36`
`38`	`37`	`.pagebuilder-poster-content {`
`39`		`- max-width: 100%;`
`40`		`- text-align: center;`
	`38`	`+ width: 100%;`
`41`	`39`	`}`
`42`	`40`	`}`
`43`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,10 +28,11 @@`
`28`	`28`	`min-height: 50px;`
`29`	`29`
`30`	`30`	`+ .placeholder-text {`
`31`		`- left: 5px;`
	`31`	`+ height: 0;`
	`32`	`+ line-height: 0;`
`32`	`33`	`pointer-events: none;`
`33`		`- position: absolute;`
`34`		`- top: 5px;`
	`34`	`+ position: relative;`
	`35`	`+ top: -50px;`
`35`	`36`	`}`
`36`	`37`	`}`
`37`	`38`	`> .mce-edit-focus {`