Skip to content

Commit b9cf8a4

Browse files
paras89paras89
committed
PB-500 cleanup MFTF coverage
1 parent 03f3fff commit b9cf8a4

File tree

4 files changed

+85
-14
lines changed

4 files changed

+85
-14
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupDuplicateAndHideTest.xml

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,27 @@
9191
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAlignmentLeft">
9292
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
9393
</actionGroup>
94+
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="selectBorder3">
95+
<argument name="property" value="PageBuilderAdvancedBorderPropertyDotted"/>
96+
</actionGroup>
97+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderColor3">
98+
<argument name="property" value="PageBuilderAdvancedBorderColorProperty_FF0000"/>
99+
</actionGroup>
100+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBorderWidth">
101+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty50"/>
102+
</actionGroup>
103+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterBorderRadius">
104+
<argument name="property" value="PageBuilderAdvancedBorderRadiusProperty60"/>
105+
</actionGroup>
106+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterCssClasses">
107+
<argument name="property" value="PageBuilderAdvancedPropertyColumnGroupClass"/>
108+
</actionGroup>
109+
<actionGroup ref="fillSlideOutPanelFieldMargins" stepKey="enterMargins">
110+
<argument name="property" value="PageBuilderMarginsPropertyUnique"/>
111+
</actionGroup>
112+
<actionGroup ref="fillSlideOutPanelFieldPadding" stepKey="enterPadding">
113+
<argument name="property" value="PageBuilderPaddingPropertyUnique5678"/>
114+
</actionGroup>
94115
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
95116
<!-- Open Column One Edit Panel -->
96117
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanelForFirstColumn">
@@ -169,6 +190,29 @@
169190
<seeNumberOfElements selector="{{ColumnOnFrontend.allColumnGroups}}" userInput="2" stepKey="seeNumberOfColumnGroups2"/>
170191
<seeNumberOfElements selector="{{ColumnGroupOnFrontend.columnsInGroup('1')}}" userInput="1" stepKey="seeNumberOfColumnsInGroupOne"/>
171192
<seeNumberOfElements selector="{{ColumnGroupOnFrontend.columnsInGroup('2')}}" userInput="2" stepKey="seeNumberOfColumnsInGroupTwo"/>
193+
<actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateAllAdvancedStorefrontColumnGroupOne">
194+
<argument name="page" value="ColumnGroupOnFrontend"/>
195+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
196+
<argument name="border" value="PageBuilderAdvancedBorderPropertyDotted"/>
197+
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_FF0000"/>
198+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty50"/>
199+
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty60"/>
200+
<argument name="cssClasses" value="PageBuilderAdvancedPropertyColumnGroupClass"/>
201+
<argument name="margin" value="PageBuilderMarginsPropertyUnique"/>
202+
<argument name="padding" value="PageBuilderPaddingPropertyUnique5678"/>
203+
</actionGroup>
204+
<actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateAllAdvancedStorefrontColumnGroup2">
205+
<argument name="page" value="ColumnGroupOnFrontend"/>
206+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
207+
<argument name="border" value="PageBuilderAdvancedBorderPropertyDotted"/>
208+
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_FF0000"/>
209+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty50"/>
210+
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty60"/>
211+
<argument name="cssClasses" value="PageBuilderAdvancedPropertyColumnGroupClass"/>
212+
<argument name="margin" value="PageBuilderMarginsPropertyUnique"/>
213+
<argument name="padding" value="PageBuilderPaddingPropertyUnique5678"/>
214+
<argument name="index" value="2"/>
215+
</actionGroup>
172216
<!-- Open CMS page in Admin -->
173217
<actionGroup ref="navigateToCMSPage" stepKey="navigateToCMSPageAgain">
174218
<argument name="CMSPage" value="$$createCMSPage$$"/>
@@ -181,6 +225,7 @@
181225
<seeElement selector="{{PageBuilderContentTypeOptionsMenu.contentTypeDuplicate(PageBuilderColumnContentType.role, '1')}}" stepKey="waitSecondTimeForColumnOneDuplicateButton"/>
182226
<seeElement selector="{{PageBuilderContentTypeOptionsMenu.contentTypeRemoveDisabled(PageBuilderColumnContentType.role,'1')}}" stepKey="waitSecondForColumnOneRemoveButton"/>
183227
<dontSeeElement selector="{{PageBuilderContentTypeOptionsMenu.contentTypeHide(PageBuilderColumnContentType.role, '1')}}" stepKey="doNotSeeSecondTimeColumnOneHideButton"/>
228+
<!-- Hide Column Group One -->
184229
<actionGroup ref="openOptionsMenu" stepKey="openEditMenuForColumnGroupSecondTime">
185230
<argument name="contentType" value="PageBuilderColumnGroupContentType"/>
186231
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupEditSettingsAndVerifyTest.xml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -134,20 +134,6 @@
134134
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Disabled"/>
135135
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Default"/>
136136
</actionGroup>
137-
<!-- <actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateColumnTwoAllAdvancedStorefront">
138-
<argument name="page" value="ColumnOnFrontend"/>
139-
<argument name="index" value="2"/>
140-
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
141-
<argument name="border" value="PageBuilderAdvancedBorderColorProperty_Empty"/>
142-
<argument name="borderColor" value="PageBuilderAdvancedBorderPropertyNone"/>
143-
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty0"/>
144-
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty0"/>
145-
<argument name="cssClasses" value="PageBuilderAdvancedCssClassesDefaultProperty"/>
146-
<argument name="margin" value="PageBuilderMarginsPropertyDefault"/>
147-
<argument name="padding" value="PageBuilderPaddingPropertyDefault"/>
148-
</actionGroup>
149-
150-
-->
151137
<!-- Verify Column Three -->
152138
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateColumnThreeBackgroundOnStorefront">
153139
<argument name="section" value="ColumnOnFrontend"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupSettingsFrontendTest.xml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
<group value="pagebuilder-column"/>
2121
<group value="pagebuilder-column-group"/>
2222
</annotations>
23+
<after>
24+
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop" before="logout"/>
25+
</after>
2326
<!-- Verify Storefront -->
2427
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
2528
<argument name="contentType" value="PageBuilderColumnGroupContentType"/>
@@ -122,5 +125,26 @@
122125
<argument name="padding" value="PageBuilderPaddingPropertyUnique78910"/>
123126
<argument name="index" value="2"/>
124127
</actionGroup>
128+
<!-- Verify Mobile Background Images -->
129+
<resizeWindow width="767" height="1000" stepKey="resizeWindowToMobile"/>
130+
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateMobileViewBackgroundOnStorefront">
131+
<argument name="section" value="ColumnGroupOnFrontend"/>
132+
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_FC0009"/>
133+
<argument name="backgroundImage" value="PageBuilderColumnGroupMobileImage_PNG"/>
134+
<argument name="backgroundPosition" value="PageBuilderBackgroundPosition_TopCenter"/>
135+
<argument name="backgroundSize" value="PageBuilderBackgroundSize_Contain"/>
136+
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
137+
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachmentProperty"/>
138+
</actionGroup>
139+
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateColumnTwoMobileViewBackgroundOnStorefront">
140+
<argument name="section" value="ColumnOnFrontend"/>
141+
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_21FFFF"/>
142+
<argument name="backgroundImage" value="PageBuilderColumnTwoMobileImage_PNG"/>
143+
<argument name="backgroundPosition" value="PageBuilderBackgroundPosition_BottomLeft"/>
144+
<argument name="backgroundSize" value="PageBuilderBackgroundSize_Cover"/>
145+
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
146+
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Scroll"/>
147+
<argument name="index" value="2"/>
148+
</actionGroup>
125149
</test>
126150
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupSettingsTest.xml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,22 @@
2929
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
3030
</before>
3131
<after>
32+
<actionGroup ref="NavigateToMediaGalleryActionGroup" stepKey="navigateToMediaGallery"/>
33+
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="NavigateToFolder">
34+
<argument name="FolderName" value="{{PageBuilderColumnGroupDesktopImage_PNG.path}}"/>
35+
</actionGroup>
36+
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteDesktopImageFromStorage">
37+
<argument name="Image" value="PageBuilderColumnGroupDesktopImage_PNG"/>
38+
</actionGroup>
39+
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteColumnGroupMobileImageFromStorage">
40+
<argument name="Image" value="PageBuilderColumnGroupMobileImage_PNG"/>
41+
</actionGroup>
42+
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteColumnOneDesktopImageFromStorage">
43+
<argument name="Image" value="PageBuilderColumnOneDesktopImage_PNG"/>
44+
</actionGroup>
45+
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteColumnTwoMobileImageFromStorage">
46+
<argument name="Image" value="PageBuilderColumnTwoMobileImage_PNG"/>
47+
</actionGroup>
3248
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3349
</after>
3450
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnsToRootContainer">

0 commit comments

Comments
 (0)