Skip to content

Commit b8ce51c

Browse files
committed
PB-500 add minHeight and Column Appearance validation to mftf
1 parent 60addb7 commit b8ce51c

File tree

1 file changed

+25
-8
lines changed

1 file changed

+25
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupSettingsFrontendTest.xml

Lines changed: 25 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@
3434
<actualResult type="variable">columnRatioFrontend</actualResult>
3535
</assertEquals>
3636
<seeNumberOfElements selector="{{ColumnOnFrontend.columnGroupWithGridSize('6','1')}}" userInput="1" stepKey="seeColumnGroupWithGridSize6"/>
37+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeColumnGroupMinHeightApplied">
38+
<argument name="selector" value="{{ColumnGroupOnFrontend.advancedConfigurationPath('1')}}"/>
39+
<argument name="expectedProperty" value="{{PageBuilderColumnGroupMinHeightProperty_345.value}}"/>
40+
<argument name="cssProperty" value="minHeight"/>
41+
</actionGroup>
3742
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateBackgroundOnStorefront">
3843
<argument name="section" value="ColumnGroupOnFrontend"/>
3944
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_FC0009"/>
@@ -43,10 +48,6 @@
4348
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
4449
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachmentProperty"/>
4550
</actionGroup>
46-
<!-- <actionGroup ref="validateBackgroundMobileImage" stepKey="validateBackgroundMobileImage">
47-
<argument name="section" value="ColumnGroupOnFrontend"/>
48-
<argument name="backgroundMobileImage" value="PageBuilderColumnGroupMobileImage_PNG"/>
49-
</actionGroup> -->
5051
<actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateAllAdvancedStorefront">
5152
<argument name="page" value="ColumnGroupOnFrontend"/>
5253
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
@@ -59,6 +60,16 @@
5960
<argument name="padding" value="PageBuilderPaddingPropertyUnique5678"/>
6061
</actionGroup>
6162
<!-- Verify Column One -->
63+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeColumnOneMinHeightApplied">
64+
<argument name="selector" value="{{ColumnOnFrontend.advancedConfigurationPath('1')}}"/>
65+
<argument name="expectedProperty" value="{{PageBuilderMinHeightProperty_100.value}}"/>
66+
<argument name="cssProperty" value="minHeight"/>
67+
</actionGroup>
68+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeColumnOneColumnAppearanceApplied">
69+
<argument name="selector" value="{{ColumnOnFrontend.advancedConfigurationPath('1')}}"/>
70+
<argument name="expectedProperty" value="{{PageBuilderColumnStyles.alignmentCenter}}"/>
71+
<argument name="cssProperty" value="alignSelf"/>
72+
</actionGroup>
6273
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateColumnOneBackgroundOnStorefront">
6374
<argument name="section" value="ColumnOnFrontend"/>
6475
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_21FFFF"/>
@@ -80,6 +91,16 @@
8091
<argument name="padding" value="PageBuilderPaddingPropertyUnique6789"/>
8192
</actionGroup>
8293
<!-- Verify Column Two -->
94+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeColumnTwoMinHeightApplied">
95+
<argument name="selector" value="{{ColumnOnFrontend.advancedConfigurationPath('2')}}"/>
96+
<argument name="expectedProperty" value="{{PageBuilderMinHeightProperty_200.value}}"/>
97+
<argument name="cssProperty" value="minHeight"/>
98+
</actionGroup>
99+
<actionGroup ref="ValidateContentTypesStyleEqualsExpectedStyleActionGroup" stepKey="seeColumnTwoColumnAppearanceApplied">
100+
<argument name="selector" value="{{ColumnOnFrontend.advancedConfigurationPath('2')}}"/>
101+
<argument name="expectedProperty" value="{{PageBuilderColumnStyles.alignmentBottom}}"/>
102+
<argument name="cssProperty" value="alignSelf"/>
103+
</actionGroup>
83104
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateColumnTwoBackgroundOnStorefront">
84105
<argument name="section" value="ColumnOnFrontend"/>
85106
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_21FFFF"/>
@@ -89,10 +110,6 @@
89110
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Fixed"/>
90111
<argument name="index" value="2"/>
91112
</actionGroup>
92-
<!-- <actionGroup ref="validateBackgroundMobileImage" stepKey="validateColumnTwoBackgroundMobileImage">
93-
<argument name="section" value="ColumnOnFrontend"/>
94-
<argument name="backgroundMobileImage" value="PageBuilderColumnTwoMobileImage_PNG"/>
95-
</actionGroup> -->
96113
<actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateColumnTwoAllAdvancedStorefront">
97114
<argument name="page" value="ColumnOnFrontend"/>
98115
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyRight"/>

0 commit comments

Comments
 (0)