Skip to content

Commit b84a6dc

Browse files
committed
MC-3870: Background does not conform to border radius for banner, image, contained row & video
Move border styles on banner from main to desktop/mobile_image
1 parent e2dec01 commit b84a6dc

File tree

1 file changed

+32
-16
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type

1 file changed

+32
-16
lines changed

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/banner.xml

Lines changed: 32 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@
2323
reader="Magento_PageBuilder/js/master-format/read/configurable">
2424
<elements>
2525
<element name="main">
26-
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
27-
<style name="border_color" source="border_color"/>
28-
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
29-
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
3026
<style name="display" source="display" converter="Magento_PageBuilder/js/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
3127
<style name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
3228
<attribute name="name" source="data-role"/>
@@ -48,6 +44,10 @@
4844
<attribute name="virtual_overlay_transparency" storage_key="overlay_transparency" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color-transparency" persistence_mode="write"/>
4945
</element>
5046
<element name="desktop_image">
47+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
48+
<style name="border_color" source="border_color"/>
49+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
50+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
5151
<style name="text_align" source="text_align"/>
5252
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
5353
<style name="background_color" source="background_color"/>
@@ -59,6 +59,10 @@
5959
<style name="margins_and_padding" source="padding" converter="Magento_PageBuilder/js/converter/style/paddings" persistence_mode="write"/>
6060
</element>
6161
<element name="mobile_image">
62+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
63+
<style name="border_color" source="border_color"/>
64+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
65+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
6266
<style name="text_align" source="text_align"/>
6367
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
6468
<style name="background_color" source="background_color"/>
@@ -98,10 +102,6 @@
98102
reader="Magento_PageBuilder/js/master-format/read/configurable">
99103
<elements>
100104
<element name="main">
101-
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
102-
<style name="border_color" source="border_color"/>
103-
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
104-
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
105105
<style name="display" source="display" converter="Magento_PageBuilder/js/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
106106
<style name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
107107
<attribute name="name" source="data-role"/>
@@ -123,6 +123,10 @@
123123
<attribute name="virtual_overlay_transparency" storage_key="overlay_transparency" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color-transparency" persistence_mode="write"/>
124124
</element>
125125
<element name="desktop_image">
126+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
127+
<style name="border_color" source="border_color"/>
128+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
129+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
126130
<style name="text_align" source="text_align"/>
127131
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
128132
<style name="background_color" source="background_color"/>
@@ -134,6 +138,10 @@
134138
<style name="margins_and_padding" source="padding" converter="Magento_PageBuilder/js/converter/style/paddings" persistence_mode="write"/>
135139
</element>
136140
<element name="mobile_image">
141+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
142+
<style name="border_color" source="border_color"/>
143+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
144+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
137145
<style name="text_align" source="text_align"/>
138146
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
139147
<style name="background_color" source="background_color"/>
@@ -173,10 +181,6 @@
173181
reader="Magento_PageBuilder/js/master-format/read/configurable">
174182
<elements>
175183
<element name="main">
176-
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
177-
<style name="border_color" source="border_color"/>
178-
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
179-
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
180184
<style name="display" source="display" converter="Magento_PageBuilder/js/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
181185
<style name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
182186
<attribute name="name" source="data-role"/>
@@ -198,6 +202,10 @@
198202
<attribute name="virtual_overlay_transparency" storage_key="overlay_transparency" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color-transparency" persistence_mode="write"/>
199203
</element>
200204
<element name="desktop_image">
205+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
206+
<style name="border_color" source="border_color"/>
207+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
208+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
201209
<style name="text_align" source="text_align"/>
202210
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
203211
<style name="background_color" source="background_color"/>
@@ -209,6 +217,10 @@
209217
<style name="margins_and_padding" source="padding" converter="Magento_PageBuilder/js/converter/style/paddings" persistence_mode="write"/>
210218
</element>
211219
<element name="mobile_image">
220+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
221+
<style name="border_color" source="border_color"/>
222+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
223+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
212224
<style name="text_align" source="text_align"/>
213225
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
214226
<style name="background_color" source="background_color"/>
@@ -249,10 +261,6 @@
249261
reader="Magento_PageBuilder/js/master-format/read/configurable">
250262
<elements>
251263
<element name="main">
252-
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
253-
<style name="border_color" source="border_color"/>
254-
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
255-
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
256264
<style name="display" source="display" converter="Magento_PageBuilder/js/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
257265
<style name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
258266
<attribute name="name" source="data-role"/>
@@ -276,6 +284,10 @@
276284
<attribute name="virtual_overlay_transparency" storage_key="overlay_transparency" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color-transparency" persistence_mode="write"/>
277285
</element>
278286
<element name="desktop_image">
287+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
288+
<style name="border_color" source="border_color"/>
289+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
290+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
279291
<style name="text_align" source="text_align"/>
280292
<style name="background_color" source="background_color"/>
281293
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
@@ -285,6 +297,10 @@
285297
<style name="background_attachment" source="background_attachment"/>
286298
</element>
287299
<element name="mobile_image">
300+
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
301+
<style name="border_color" source="border_color"/>
302+
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
303+
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
288304
<style name="text_align" source="text_align"/>
289305
<style name="background_color" source="background_color"/>
290306
<style name="mobile_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>

0 commit comments

Comments
 (0)