Skip to content

Commit b82a8e6

Browse files
committed
MC-3441: MagentoCE Change Is Breaking PageBuilder Tests
- Fixing failing tests
1 parent d4da457 commit b82a8e6

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderEditFormSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<element name="editFormSave" type="button" selector=".modal-header .page-main-actions [data-form-role='save']" timeout="30"/>
1717
<element name="editPanelSectionName" type="button" selector="//div[@data-index='{{arg1}}']" parameterized="true"/>
1818
<element name="editPanelSectionExpanded" type="button" selector="//div[@data-index='{{arg1}}' and contains(@class,'_show')]" parameterized="true"/>
19-
<element name="panelFieldLabel" type="text" selector='//aside//div[@data-index="{{arg1}}"]/descendant::div[@data-index="{{arg2}}"]/label[not(contains(@style,"display: none;"))] | //aside//div[@data-index="{{arg3}}"]/descendant::*[@class="admin__field-label" or @class="title"][not(contains(@style,"display: none;"))]/span[text()="{{arg4}}"]' parameterized="true" />
19+
<element name="panelFieldLabel" type="text" selector='//aside//div[@data-index="{{arg1}}"]/descendant::div[@data-index="{{arg2}}"]/span[not(contains(@style,"display: none;"))] | //aside//div[@data-index="{{arg3}}"]/descendant::*[@class="admin__field-label" or @class="title"][not(contains(@style,"display: none;"))]/span[text()="{{arg4}}"]' parameterized="true" />
2020
<element name="panelSectionChangedIcon" type="text" selector="[data-index='{{arg1}}'] ._changed .admin__page-nav-item-message-icon" parameterized="true"/>
2121
<element name="panelSectionError" type="text" selector="[data-index='{{arg1}}'] span._error .admin__page-nav-item-message-icon" parameterized="true"/>
2222
<element name="panelFieldControl" type="input" selector='//aside//div[@data-index="{{arg1}}"]/descendant::*[@name="{{arg2}}"]' parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderHtmlSection.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@
4040
<element name="margins" type="text" selector="(//div[@data-role='html'])[{{arg1}}][contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
4141
<element name="padding" type="text" selector="(//div[@data-role='html'])[{{arg1}}][contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
4242
</section>
43-
<section name="HTMLOnConfiguration">
44-
<element name="htmlFieldError" type="text" selector="//div[contains(@class,'pagebuilder_modal_form_pagebuilder_modal_form_modal_insert_form')]//div[@data-index='general']//div[@data-index='html' and contains(@class, '_error')]//div[contains(@class,'')]//textarea[@name='html']"/>
45-
<element name="htmlFieldErrorMessage" type="text" selector="//div[contains(@class,'pagebuilder_modal_form_pagebuilder_modal_form_modal_insert_form')]//div[@data-index='general']//..//../label[.='{{arg1}}']" parameterized="true"/>
46-
</section>
4743
<section name="HtmlOnBackendArbitraryHtml">
4844
<element name="content" type="button" selector="//div[contains(@class, 'pagebuilder-html')][1]//div[contains(text(), '&lt;div class=&quot;my-div&quot;&gt;&lt;/div&gt;')]"/>
4945
</section>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@
147147
<element name="linkUrl" type="button" selector="[href*='{{arg1}}']" parameterized="true"/>
148148
<element name="editButton" type="button" selector="//a[contains(@class, '{{arg1}}')]" parameterized="true"/>
149149
<element name="requiredField" type="text" selector="//div[contains(@class, 'pagebuilder_modal_form_pagebuilder_modal_form_modal')] //div[contains(@class, 'admin__field _required')]" />
150-
<element name="errorField" type="text" selector="//label[contains(@class, 'admin__field-error')]" />
151150
<element name="appearanceSelect" type="button" selector="[name='appearance']"/>
152151
<element name="paddingTopInput" type="button" selector="[name='paddingTop']"/>
153152
<element name="paddingLeftInput" type="button" selector="[name='paddingLeft']"/>

0 commit comments

Comments
 (0)