Skip to content

Commit b623b0e

Browse files
author
Lukasz Borowiec
committed
#512: User edits cms block content in full-screen mode only - merged a merge cms branch
2 parents 469c6b3 + 837f440 commit b623b0e

16 files changed

+32
-45
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCMSBlockCreateAndApplyTemplate.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<actionGroup ref="NavigateToCreatedCMSBlockPageActionGroup" stepKey="navigateToCreatedCMSPage">
2626
<argument name="CMSBlockPage" value="$$createCMSPage$$"/>
2727
</actionGroup>
28-
<remove keyForRemoval="switchToPageBuilderStage"/>
28+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="switchToPageBuilderStage"/>
2929
</before>
3030
<actionGroup ref="savePageBuilderTemplate" stepKey="savePageBuilderTemplate">
3131
<argument name="baseContent" value="{{BlockNewPagePageActionsSection.saveBlock}}"/>
@@ -34,7 +34,7 @@
3434
<actionGroup ref="NavigateToCreatedCMSBlockPageActionGroup" stepKey="navigateToCreatedCMSPage">
3535
<argument name="CMSBlockPage" value="$$createCMSPage$$"/>
3636
</actionGroup>
37-
<remove keyForRemoval="switchToPageBuilderStage"/>
37+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="switchToPageBuilderStage"/>
3838
<actionGroup ref="confirmApplyFromPageBuilderApplyTemplateSlideOut" stepKey="confirmApplyFromPageBuilderApplyTemplateSlideOut">
3939
<argument name="baseContent" value="{{BlockNewPagePageActionsSection.saveBlock}}"/>
4040
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockAddAndEditRowColumnSlideTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,16 @@
3232
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
3333
</actionGroup>
3434
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
35-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
35+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
3636
</before>
3737
<after>
3838
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct"/>
3939
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory"/>
4040
<comment userInput="---merging to remove step---" stepKey="NavigateToAndResetProductGridToDefaultView"/>
4141
</after>
42-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreen"/>
4342
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProduct"/>
4443
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
45-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
44+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
4645
<!-- Go to CMS Page and choose Block -->
4746
<comment userInput="Go to CMS Page and choose Block" stepKey="commentGoToCMSPage" after="seeBackgroundColorSlide2StageAfterSave"/>
4847
<actionGroup ref="NavigateToCreatedCMSPageActionGroup" stepKey="navigateToCreatedCMSPage" after="commentGoToCMSPage">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockFullScreenCoversEntireScreenTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,11 @@
2626
<actionGroup ref="NavigateToCreatedCMSBlockPageActionGroup" stepKey="navigateToAPageWithPageBuilder">
2727
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
2828
</actionGroup>
29-
<comment userInput="---merging to remove step---" stepKey="switchToPageBuilderStage"/>
29+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="switchToPageBuilderStage"/>
3030
</before>
3131
<after>
3232
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct" before="logout"/>
3333
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory" after="deleteCreatedProduct"/>
3434
</after>
35-
<actionGroup ref="openPageBuilderFullScreen" stepKey="openPageBuilderFullScreen"/>
3635
</test>
3736
</tests>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockFullScreenLeftPanelHeightAndFunctionalityTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,11 @@
2626
<actionGroup ref="NavigateToCreatedCMSBlockPageActionGroup" stepKey="navigateToAPageWithPageBuilder">
2727
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
2828
</actionGroup>
29-
<comment userInput="---merging to remove step---" stepKey="switchToPageBuilderStage"/>
29+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="switchToPageBuilderStage"/>
3030
</before>
3131
<after>
3232
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct" before="logout"/>
3333
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory" after="deleteCreatedProduct"/>
3434
</after>
35-
<actionGroup ref="openPageBuilderFullScreen" stepKey="openPageBuilderFullScreen"/>
3635
</test>
3736
</tests>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanAddChildContentTypesFromOnHoverOptionMenusTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,16 @@
3030
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
3131
</actionGroup>
3232
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
33-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
33+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
3434
</before>
3535
<after>
3636
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct"/>
3737
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory"/>
3838
<comment userInput="---merging to remove step---" stepKey="NavigateToAndResetProductGridToDefaultView"/>
3939
</after>
40-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreen"/>
4140
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProduct"/>
4241
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
43-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
42+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
4443
<!-- Go to CMS Page and choose Block -->
4544
<comment userInput="Go to CMS Page and choose Block" stepKey="commentGoToCMSPage" after="see2ButtonItemsStageAfterSave"/>
4645
<actionGroup ref="NavigateToCreatedCMSPageActionGroup" stepKey="navigateToCreatedCMSPage" after="commentGoToCMSPage">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDeleteContentTypesFromOnClickOptionMenusTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,16 @@
3030
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
3131
</actionGroup>
3232
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
33-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
33+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
3434
</before>
3535
<after>
3636
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct"/>
3737
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory"/>
3838
<comment userInput="---merging to remove step---" stepKey="NavigateToAndResetProductGridToDefaultView"/>
3939
</after>
40-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreen"/>
4140
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProduct"/>
4241
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
43-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
44-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreenAfterDelete"/>
42+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
4543
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProductAfterDelete"/>
4644
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSectionAfterDelete"/>
4745
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescriptionAfterDelete"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDeleteContentTypesFromOnHoverOptionMenusTest.xml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,21 +30,19 @@
3030
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
3131
</actionGroup>
3232
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
33-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
33+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
3434
</before>
3535
<after>
3636
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct"/>
3737
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory"/>
3838
<comment userInput="---merging to remove step---" stepKey="NavigateToAndResetProductGridToDefaultView"/>
3939
</after>
40-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreen"/>
4140
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProduct"/>
4241
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
43-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
44-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreenAfterDelete"/>
42+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
4543
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProductAfterDelete"/>
4644
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSectionAfterDelete"/>
47-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescriptionAfterDelete"/>
45+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescriptionAfterDelete"/>
4846
<!-- Go to CMS Page and choose Block -->
4947
<comment userInput="Go to CMS Page and choose Block" stepKey="commentGoToCMSPage" after="dontSeeDividerInStageAfterSave"/>
5048
<actionGroup ref="NavigateToCreatedCMSPageActionGroup" stepKey="navigateToCreatedCMSPage" after="commentGoToCMSPage">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDuplicateContentTypesFromOnClickOptionMenusTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,16 @@
3030
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
3131
</actionGroup>
3232
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
33-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
33+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
3434
</before>
3535
<after>
3636
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct"/>
3737
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory"/>
3838
<comment userInput="---merging to remove step---" stepKey="NavigateToAndResetProductGridToDefaultView"/>
3939
</after>
40-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreen"/>
4140
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProduct"/>
4241
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
43-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
42+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
4443
<!-- Go to CMS Page and choose Block -->
4544
<comment userInput="Go to CMS Page and choose Block" stepKey="commentGoToCMSPage" after="closeEditPanel"/>
4645
<actionGroup ref="NavigateToCreatedCMSPageActionGroup" stepKey="navigateToCreatedCMSPage" after="commentGoToCMSPage">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDuplicateContentTypesFromOnHoverOptionMenusTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,16 @@
3030
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
3131
</actionGroup>
3232
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
33-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
33+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
3434
</before>
3535
<after>
3636
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct"/>
3737
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory"/>
3838
<comment userInput="---merging to remove step---" stepKey="NavigateToAndResetProductGridToDefaultView"/>
3939
</after>
40-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreen"/>
4140
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProduct"/>
4241
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
43-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
42+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
4443
<!-- Go to CMS Page and choose Block -->
4544
<comment userInput="Go to CMS Page and choose Block" stepKey="commentGoToCMSPage" after="seeBackgroundColorRow2StageAfterSave"/>
4645
<actionGroup ref="NavigateToCreatedCMSPageActionGroup" stepKey="navigateToCreatedCMSPage" after="commentGoToCMSPage">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanEditContentTypesFromOnClickOptionMenusTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,16 @@
3030
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
3131
</actionGroup>
3232
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
33-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
33+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
3434
</before>
3535
<after>
3636
<deleteData createDataKey="createPreReqBlock" stepKey="deleteCreatedProduct"/>
3737
<deleteData createDataKey="createCMSPage" stepKey="deleteCreatedCategory"/>
3838
<comment userInput="---merging to remove step---" stepKey="NavigateToAndResetProductGridToDefaultView"/>
3939
</after>
40-
<comment userInput="---merging to remove step---" stepKey="exitPageBuilderFullScreen"/>
4140
<actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveProduct"/>
4241
<comment userInput="---merging to remove step---" stepKey="expandAdminProductSection"/>
43-
<comment userInput="---merging to remove step---" stepKey="openPageBuilderForDescription"/>
42+
<actionGroup ref="AdminOpenPageBuilderFromContentPreviewOverlayActionGroup" stepKey="openPageBuilderForDescription"/>
4443
<!-- Go to CMS Page and choose Block -->
4544
<comment userInput="Go to CMS Page and choose Block" stepKey="commentGoToCMSPage" after="seeBackgroundColorOnEditPanel"/>
4645
<actionGroup ref="NavigateToCreatedCMSPageActionGroup" stepKey="navigateToCreatedCMSPage" after="commentGoToCMSPage">

0 commit comments

Comments
 (0)