MC-3880: Minimum Height & Vertical Alignment Is In Inconsistent Sections On Edit Panel for Each Content Type

- update existing tests

Author: anthoula

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/EditFormActionGroup.xml

@@ -225,7 +225,7 @@
         </arguments>
         <waitForElement time="2" selector="{{EditPanelForm.panelFieldControl(property.section, property.fieldName)}}" stepKey="waitForElementVisible"/>
         <seeElement selector='//li[@name="{{property.value}}"]' stepKey="seeVisualSelect"/>
-        <click selector='//div[@data-index="{{property.section}}" and contains(@class,"_show")]//li[@name="{{property.value}}"]' stepKey="chooseVisualSelectOption"/>
+        <click selector='//div[@data-index="{{property.section}}"]//li[@name="{{property.value}}"]' stepKey="chooseVisualSelectOption"/>
     </actionGroup>
     <actionGroup name="scrollToSlideOutPanelField">
         <arguments>

app/code/Magento/PageBuilder/Test/Mftf/Data/MapData.xml

@@ -806,59 +806,59 @@
     </entity>
     <!-- Height -->
     <entity name="PageBuilderMapHeightDefaultProperty" type="pagebuilder_map_height_property">
-        <data key="name">Map Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="name">Height</data>
+        <data key="section">general</data>
         <data key="fieldName">height</data>
         <data key="value">300</data>
     </entity>
     <entity name="PageBuilderMapHeight_Empty" type="pagebuilder_map_height_property">
         <data key="name">Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">height</data>
         <data key="value"/>
     </entity>
     <entity name="PageBuilderMapHeightProperty350" type="pagebuilder_map_height_property">
         <data key="name">Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">height</data>
         <data key="value">350</data>
     </entity>
     <entity name="PageBuilderMapHeightProperty500px" type="pagebuilder_map_height_property">
         <data key="name">Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">height</data>
         <data key="value">500</data>
     </entity>
     <entity name="PageBuilderMapHeight_Percentage" type="pagebuilder_map_height_property">
         <data key="name">Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">height</data>
         <data key="value">50%</data>
         <data key="errorMessage">Please enter a valid number in this field.</data>
     </entity>
     <entity name="PageBuilderMapHeight_NonNumeric" type="pagebuilder_map_height_property">
         <data key="name">Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">height</data>
         <data key="value">a</data>
         <data key="errorMessage">Please enter a valid number in this field.</data>
     </entity>
     <!-- Show Controls -->
     <entity name="PageBuilderMapShowControls_Default" type="pagebuilder_map_show_controls_property">
-        <data key="name"> Show Controls</data>
-        <data key="section">map_settings</data>
+        <data key="name">Show Controls</data>
+        <data key="section">general</data>
         <data key="fieldName">show_controls</data>
         <data key="value">true</data>
     </entity>
     <entity name="PageBuilderMapShowControls_True" type="pagebuilder_map_show_controls_property">
         <data key="name"> Show Controls</data>
-        <data key="section">map_settings</data>
+        <data key="section">general</data>
         <data key="fieldName">show_controls</data>
         <data key="value">true</data>
     </entity>
     <entity name="PageBuilderMapShowControls_False" type="pagebuilder_map_show_controls_property">
         <data key="name"> Show Controls</data>
-        <data key="section">map_settings</data>
+        <data key="section">general</data>
         <data key="fieldName">show_controls</data>
         <data key="value">false</data>
     </entity>

app/code/Magento/PageBuilder/Test/Mftf/Data/SliderData.xml

@@ -11,78 +11,78 @@
     <!-- AutoPlay -->
     <entity name="PageBuilderSliderAutoPlay_Disabled" type="pagebuilder_slider_autoplay_property">
         <data key="name">Autoplay</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">autoplay</data>
         <data key="value">false</data>
     </entity>
     <entity name="PageBuilderSliderAutoPlay_Enabled" type="pagebuilder_slider_autoplay_property">
         <data key="name">Autoplay</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">autoplay</data>
         <data key="value">true</data>
     </entity>
     <!-- AutoPlay Speed -->
     <entity name="PageBuilderSliderAutoPlaySpeed_Default" type="pagebuilder_slider_autoplay_speed_property">
         <data key="name">Autoplay Speed</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">autoplay_speed</data>
         <data key="value">4000</data>
     </entity>
     <entity name="PageBuilderSliderAutoPlaySpeed_50000" type="pagebuilder_slider_autoplay_speed_property">
         <data key="name">Autoplay Speed</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">autoplay_speed</data>
         <data key="value">50000</data>
     </entity>
     <!-- Fade -->
     <entity name="PageBuilderSliderFade_Enabled" type="pagebuilder_slider_fade_property">
         <data key="name">Fade</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">fade</data>
         <data key="value">true</data>
     </entity>
     <entity name="PageBuilderSliderFade_Disabled" type="pagebuilder_slider_fade_property">
         <data key="name">Fade</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">fade</data>
         <data key="value">false</data>
     </entity>
     <!-- Infinite Loop -->
     <entity name="PageBuilderSliderInfiniteLoop_Enabled" type="pagebuilder_slider_infinite_loop_property">
         <data key="name">Is Infinite</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">is_infinite</data>
         <data key="value">true</data>
     </entity>
     <entity name="PageBuilderSliderInfiniteLoop_Disabled" type="pagebuilder_slider_infinite_loop_property">
         <data key="name">Is Infinite</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">is_infinite</data>
         <data key="value">false</data>
     </entity>
     <!-- Show Arrows -->
     <entity name="PageBuilderSliderShowArrows_Enabled" type="pagebuilder_slider_show_arrows_property">
         <data key="name">Show Arrows</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">show_arrows</data>
         <data key="value">true</data>
     </entity>
     <entity name="PageBuilderSliderShowArrows_Disabled" type="pagebuilder_slider_show_arrows_property">
         <data key="name">Show Arrows</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">show_arrows</data>
         <data key="value">false</data>
     </entity>
     <!-- Show Dots -->
     <entity name="PageBuilderSliderShowDots_Disabled" type="pagebuilder_slider_show_dots_property">
         <data key="name">Show dots</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">show_dots</data>
         <data key="value">false</data>
     </entity>
     <entity name="PageBuilderSliderShowDots_Enabled" type="pagebuilder_slider_show_dots_property">
         <data key="name">Show dots</data>
-        <data key="section">slider_settings</data>
+        <data key="section">settings</data>
         <data key="fieldName">show_dots</data>
         <data key="value">true</data>
     </entity>

app/code/Magento/PageBuilder/Test/Mftf/Data/TabData.xml

@@ -60,28 +60,29 @@
     <!-- Minimum Height -->
     <entity name="PageBuilderTabMinimumHeightDefaultProperty" type="pagebuilder_tab_property">
         <data key="name">Minimum Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">min_height</data>
         <data key="value">300</data>
     </entity>
     <entity name="PageBuilderTabMinimumHeight200Property" type="pagebuilder_tab_property">
         <data key="name">Minimum Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">min_height</data>
         <data key="value">200</data>
     </entity>
     <entity name="PageBuilderTabMinimumHeight600Property" type="pagebuilder_tab_property">
         <data key="name">Minimum Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">min_height</data>
         <data key="value">600</data>
     </entity>
     <entity name="PageBuilderTabMinimumHeight1000Property" type="pagebuilder_tab_property">
         <data key="name">Minimum Height</data>
-        <data key="section">appearance_fieldset</data>
+        <data key="section">general</data>
         <data key="fieldName">min_height</data>
         <data key="value">1000</data>
     </entity>
+    <!-- Background Color -->
     <entity name="PageBuilderTabBackgroundColorPink" type="pagebuilder_row_background_color_property">
         <data key="name">Background Color</data>
         <data key="section">background</data>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderMapSection.xml

@@ -30,7 +30,6 @@
         <element name="commentElement" type="text" selector="(//div[contains(@class,'pagebuilder-map')])[{{arg1}}]//div[contains(concat(' ', normalize-space(@class), ' '), ' gm-style-iw ')]//p" parameterized="true"/>
         <element name="phoneNumberElement" type="text" selector="(//div[contains(@class,'pagebuilder-map')])[{{arg1}}]//div[contains(concat(' ', normalize-space(@class), ' '), ' gm-style-iw ')]//p" parameterized="true"/>
         <element name="addressCityStateZipCountryElement" type="text" selector="(//div[contains(@class,'pagebuilder-map')])[{{arg1}}]//div[contains(concat(' ', normalize-space(@class), ' '), ' gm-style-iw ')]//span" parameterized="true"/>
-        <!-- Map Settings Configuration -->
         <element name="height" type="button" selector="(//div[contains(@class,'pagebuilder-map')])[{{arg1}}]//div[contains(@data-bind,'renderMap') and contains(@style,'height: {{arg2}}px;')]" parameterized="true"/>
         <element name="noHeight" type="button" selector="(//div[contains(@class,'pagebuilder-map')])[{{arg1}}]//div[contains(@data-bind,'renderMap') and not(contains(@style,'height:'))]" parameterized="true"/>
         <element name="showControls" type="text" selector="(//div[contains(@class,'pagebuilder-map')])[{{arg1}}]//div[contains(@data-bind,'renderMap') and @data-show-controls='{{arg2}}']" parameterized="true"/>
@@ -79,7 +78,6 @@
         <element name="commentElement" type="text" selector="(//div[@data-content-type='map'])[{{arg1}}]//div[contains(concat(' ', normalize-space(@class), ' '), ' gm-style-iw ')]//p" parameterized="true"/>
         <element name="phoneNumberElement" type="text" selector="(//div[@data-content-type='map'])[{{arg1}}]//div[contains(concat(' ', normalize-space(@class), ' '), ' gm-style-iw ')]//p" parameterized="true"/>
         <element name="addressCityStateZipCountryElement" type="text" selector="(//div[@data-content-type='map'])[{{arg1}}]//div[contains(concat(' ', normalize-space(@class), ' '), ' gm-style-iw ')]//span" parameterized="true"/>
-        <!-- Map Settings Configuration -->
         <element name="height" type="button" selector="(//div[@data-content-type='map'])[{{arg1}}][contains(@style,'height: {{arg2}}px;')]" parameterized="true"/>
         <element name="noHeight" type="button" selector="(//div[@data-content-type='map'])[{{arg1}}][not(contains(@style,'height:'))]" parameterized="true"/>
         <element name="showControls" type="text" selector="(//div[@data-content-type='map'])[{{arg1}}][@data-show-controls='{{arg2}}']" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTests.xml

@@ -38,7 +38,7 @@
         <actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
             <argument name="contentType" value="PageBuilderRowContentType"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
             <argument name="property" value="PageBuilderMinHeightProperty_500"/>
         </actionGroup>
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentBottomProperty">
@@ -360,7 +360,7 @@
         <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterParallaxBackgroundSpeed">
             <argument name="property" value="PageBuilderRowParallaxSpeed_2"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
             <argument name="property" value="PageBuilderMinHeightProperty_500"/>
         </actionGroup>
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentCenterProperty">
@@ -1103,7 +1103,7 @@
         <actionGroup ref="conditionalClickSlideOutPanelFieldGeneral" stepKey="setBackgroundRepeatColumn1">
             <argument name="property" value="PageBuilderBackgroundRepeat_Enabled"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="setMinHeightColumn1">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="setMinHeightColumn1">
             <argument name="property" value="PageBuilderMinHeightProperty_200"/>
         </actionGroup>
         <actionGroup ref="chooseVisualSelectOption" stepKey="setVerticalAlignmentColumn1">
@@ -1119,7 +1119,7 @@
         <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="setBackgroundColorColumn2">
             <argument name="property" value="PageBuilderBackgroundColor_RGB_Blue"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="setMinHeightColumn2">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="setMinHeightColumn2">
             <argument name="property" value="PageBuilderMinHeightProperty_500"/>
         </actionGroup>
         <actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettingsColumn2"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

@@ -330,7 +330,7 @@
             <argument name="contentType" value="PageBuilderColumnContentType"/>
             <argument name="contentTypeIndex" value="1"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
             <argument name="property" value="PageBuilderMinHeightProperty_300"/>
         </actionGroup>
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentTopProperty">
@@ -436,7 +436,7 @@
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceTopProperty">
             <argument name="property" value="PageBuilderColumnAppearanceProperty_Top"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty500">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty500">
             <argument name="property" value="PageBuilderMinHeightProperty_500"/>
         </actionGroup>
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentTopProperty">
@@ -461,7 +461,7 @@
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceCenterProperty">
             <argument name="property" value="PageBuilderColumnAppearanceProperty_Center"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty300">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty300">
             <argument name="property" value="PageBuilderMinHeightProperty_300"/>
         </actionGroup>
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmenCenterProperty">
@@ -483,7 +483,7 @@
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceCenterBottom">
             <argument name="property" value="PageBuilderColumnAppearanceProperty_Bottom"/>
         </actionGroup>
-        <actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty200">
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty200">
             <argument name="property" value="PageBuilderMinHeightProperty_200"/>
         </actionGroup>
         <actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmenBottomProperty">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapMapSettingsAttributesTest.xml

@@ -180,15 +180,15 @@
         <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterHeightPercentage">
             <argument name="property" value="PageBuilderMapHeight_Percentage"/>
         </actionGroup>
-        <actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateErrorPercentage">
+        <actionGroup ref="saveEditPanelAndValidateFieldErrorGeneralSection" stepKey="validateErrorPercentage">
             <argument name="property" value="PageBuilderMapHeight_Percentage"/>
         </actionGroup>
         <!-- Enter Height: NonNumeric -->
         <comment userInput="Enter Height: NonNumeric" stepKey="commentEnterHeightNonNumeric"/>
         <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterHeightNonNumeric">
             <argument name="property" value="PageBuilderMapHeight_NonNumeric"/>
         </actionGroup>
-        <actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateErrorNonNumeric">
+        <actionGroup ref="saveEditPanelAndValidateFieldErrorGeneralSection" stepKey="validateErrorNonNumeric">
             <argument name="property" value="PageBuilderMapHeight_NonNumeric"/>
         </actionGroup>
     </test>