Skip to content

Commit b53b4c1

Browse files
committed
#559: User sees no predefined gutters
- Fixing PR feedback
1 parent 8600598 commit b53b4c1

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest/BlockRenderColumnDragAndDropMultipleColumnsResizingThroughBlockContentTypeTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
<actualResult type="variable">columnRatio3CMSBlockStage</actualResult>
9696
</assertEquals>
9797
<executeJS function="return Math.round({$columnOneWidthCMSBlockStage}+{$columnTwoWidthCMSBlockStage}+{$columnThreeWidthCMSBlockStage}+{$columnFourWidthCMSBlockStage})" stepKey="totalColumnWidthCMSBlockStage"/>
98-
<executeJS function="return Math.round({{RowOnStage.rowWidthJS('1')}}-{{PageBuilderPaddingPropertyRowDefault.paddingLeft}}-{{PageBuilderPaddingPropertyRowDefault.paddingRight}}-{{PageBuilderRowAffordanceWidth.value}} - 4 * {{PageBuilderMarginsPropertyColumnStage.marginRight}})" stepKey="rowWidthCMSBlockStage"/>
98+
<executeJS function="return Math.round({{RowOnStage.rowWidthJS('1')}}-{{PageBuilderPaddingPropertyRowDefault.paddingLeft}}-{{PageBuilderPaddingPropertyRowDefault.paddingRight}}-{{PageBuilderRowAffordanceWidth.value}} - (4 * {{PageBuilderMarginsPropertyColumnStage.marginRight}}))" stepKey="rowWidthCMSBlockStage"/>
9999
<executeJS function="return Math.abs({$totalColumnWidthCMSBlockStage}-{$rowWidthCMSBlockStage})" stepKey="widthDifferenceCMSBlockStage"/>
100100
<assertLessThanOrEqual stepKey="assertWidthOfAllColumnsCMSBlockStage">
101101
<expectedResult type="int">2</expectedResult>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest/RowHeightAdjustsToContentWhenContentIsSmallerHeadingTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
<after>
3434
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3535
</after>
36-
<!-- Assert row height is 320px when empty -->
37-
<comment userInput="Assert row height is 320px when empty" stepKey="comment1"/>
36+
<!-- Assert row height is 300px when empty -->
37+
<comment userInput="Assert row height is 300px when empty" stepKey="comment1"/>
3838
<executeJS function="document.querySelectorAll('{{RowOnStage.baseCSS}}')[0].setAttribute('divHeight', document.querySelectorAll('{{RowOnStage.baseCSS}}')[0].clientHeight)" stepKey="setEmptyRowHeight"/>
3939
<grabAttributeFrom selector="{{RowOnStage.base('1')}}" userInput="divHeight" stepKey="getEmptyRowHeight"/>
4040
<assertEquals stepKey="assertEmptyRowHeight">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests/SliderFadeCanBeInlineEditedTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@
7474
<expectedResult type="variable">sliderRightPosition</expectedResult>
7575
<actualResult type="variable">slideRightPosition</actualResult>
7676
</assertLessThanOrEqual>
77-
<assertLessThanOrEqual stepKey="assertSlideLeftSideIsGreaterThanSliderLeftSide">
77+
<assertGreaterThanOrEqual stepKey="assertSlideLeftSideIsGreaterThanSliderLeftSide">
7878
<expectedResult type="variable">sliderLeftPosition</expectedResult>
7979
<actualResult type="variable">slideLeftPosition</actualResult>
80-
</assertLessThanOrEqual>
80+
</assertGreaterThanOrEqual>
8181
<!-- Add Content To Slide 2 -->
8282
<comment userInput="Add Content To Slide 2" stepKey="commentAddContentToSlide2"/>
8383
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemContentTest/TabMaintainsDefaultMinimumHeightWithContentTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,8 @@
6666

6767
<!-- Verify on Stage -->
6868
<comment userInput="Verify Tab height on stage" stepKey="verifyTabOnStage"/>
69-
<!-- @todo: Use `{{PageBuilderTabMinimumHeightDefaultProperty.value}}` as `expectedResult` -->
70-
<executeJS function="return {{PageBuilderTabMinimumHeightDefaultProperty.value}}" stepKey="tabExpectedHeight"/>
7169
<executeJS function="return {{TabOnStage.tabContentHeightJS('0')}}" stepKey="tabContentHeightStage"/>
70+
<executeJS function="return {{PageBuilderTabMinimumHeightDefaultProperty.value}}" stepKey="tabExpectedHeight"/>
7271
<assertEquals stepKey="assertTabHeightStage">
7372
<expectedResult type="variable">tabExpectedHeight</expectedResult>
7473
<actualResult type="variable">tabContentHeightStage</actualResult>

app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileDeleteContentTypesFromOnHoverOptionMenusTest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
<argument name="viewportStage" value="mobile"/>
6868
</actionGroup>
6969
<!-- Delete Divider -->
70-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="lostFocus"/>
7170
<actionGroup ref="removeContentTypeFromStage" stepKey="removeContentTypeFromStage">
7271
<argument name="contentType" value="PageBuilderDividerContentType"/>
7372
</actionGroup>

0 commit comments

Comments
 (0)