Skip to content

Commit b2e85ff

Browse files
committed
PB-179: Product Content Type Inner Contents Should Not Align Based On Alignment Configuration
- add coverage for products in carousel
1 parent 77e690d commit b2e85ff

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection/ProductsCarouselOnStageSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<element name="notHidden" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products') and not(contains(@class,'placeholder'))])[{{indexOfProductGroup}}]//parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]"/>
1515
<element name="emptyProductsPlaceholder" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'carousel')])[{{indexOfProductGroup}}]//*[contains(@class,'pagebuilder-products-placeholder')]"/>
1616
<element name="product" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'carousel')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')]"/>
17+
<element name="productJS" type="text" parameterized="true" selector="(document.querySelectorAll('div.pagebuilder-products div[data-appearance=carousel]')[{{indexOfProductGroup}} - 1]).querySelector('ol li.product-item')"/>
1718
<element name="productsInCarouselNotClonedBySlick" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'carousel')])[{{indexOfProductGroup}}]//ol//div[contains(@class,'slick-slide') and not(contains(@class,'slick-cloned'))]//li[contains(@class,'product-item')]"/>
1819
<element name="productInCarouselBySlickSlideIndex" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'carousel')])[{{indexOfProductGroup}}]//ol//*[@data-slick-index='{{indexOfSlickSlide}}']//li[contains(@class,'product-item')]"/>
1920
<element name="productByIndex" type="text" parameterized="true" selector="((//div[contains(@class,'pagebuilder-products')]//div[contains(@data-appearance,'carousel')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection/ProductsOnStorefrontSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<element name="product" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')]"/>
1616
<element name="productJS" type="text" selector="document.querySelectorAll('div[data-content-type=products] ol li.product-item')[{{indexOfProductItem}} - 1]" parameterized="true"/>
1717
<element name="productsInCarouselNotClonedBySlick" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//div[contains(@class,'slick-slide') and not(contains(@class,'slick-cloned'))]//li[contains(@class,'product-item')]"/>
18+
<element name="productsInCarouselNotClonedBySlickJS" type="text" parameterized="true" selector="(document.querySelectorAll('div[data-content-type=products]')[{{indexOfProductGroup}} - 1]).querySelector('ol div.slick-slide:not(.slick-cloned) li.product-item')"/>
1819
<element name="productByIndex" type="text" parameterized="true" selector="((//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>
1920
<element name="productInCarouselNotClonedBySlickByIndex" type="text" parameterized="true" selector="((//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//div[contains(@class,'slick-slide') and not(contains(@class,'slick-cloned'))]//li[contains(@class,'product-item')])[{{indexOfProductItem}}]"/>
2021
<element name="productInCarouselBySlickSlideIndex" type="text" parameterized="true" selector="(//div[contains(@data-content-type,'products')])[{{indexOfProductGroup}}]//ol//*[@data-slick-index='{{indexOfSlickSlide}}']//li[contains(@class,'product-item')]"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCarouselTest/AdminPageBuilderProductsCarouselUpdateAdvancedConfigurationValuesTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,7 @@
4747
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
4848
<argument name="index" value="1"/>
4949
</actionGroup>
50+
<executeJS function="return window.getComputedStyle({{ProductsCarouselOnStage.productJS('1')}}).textAlign" stepKey="grabComputedTextAlign"/>
51+
<executeJS function="return window.getComputedStyle({{ProductsOnStorefront.productsInCarouselNotClonedBySlickJS('1')}}).textAlign" stepKey="grabComputedTextAlignStorefront"/>
5052
</test>
5153
</tests>

0 commit comments

Comments
 (0)