Skip to content

Commit afd4e65

Browse files
committed
MC-3694: Add/Update MFTF Tests
- Fixing schema locations - Fixing some test flakiness
1 parent 38cedc7 commit afd4e65

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeBlockActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear3"/>
2424
<waitForElementVisible selector="{{BlockOnGrid.addSelectedBtn}}" stepKey="waitForAddSelected"/>
2525
<click selector="{{BlockOnGrid.addSelectedBtn}}" stepKey="clickAddSelected"/>
26+
<waitForPageLoad stepKey="waitForPageLoad"/>
2627
</actionGroup>
2728
<actionGroup name="verifyBlockOnStage">
2829
<arguments>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCreateInvoiceTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
*/
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd">
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1010
<test name="AdminCreateInvoiceTest">
1111
<annotations>
1212
<skip>
13-
<issueId>MC-3613</issueId>
13+
<issueId value="MC-3613"/>
1414
</skip>
1515
</annotations>
1616
</test>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,6 +1085,7 @@
10851085
<executeJS function="{{PageBuilderStoreFront.computedHeight(PageBuilderSliderContentType.role, '0')}}" stepKey="slideInitialHeightStorefront"/>
10861086
<switchToPreviousTab stepKey="switchToPreviousTab"/>
10871087
<reloadPage stepKey="reloadPage"/>
1088+
<waitForPageLoad stepKey="waitForPageLoad"/>
10881089
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
10891090
<!-- Edit Slide Content -->
10901091
<comment userInput="Edit Slide Content" stepKey="commentEditSlide"/>
@@ -1118,6 +1119,7 @@
11181119
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
11191120
<switchToNextTab stepKey="switchToNextTab"/>
11201121
<reloadPage stepKey="reloadPage2"/>
1122+
<waitForPageLoad stepKey="waitForPageLoad2"/>
11211123
<seeElement selector="{{SlideOnFrontend.messageContent('1', PageBuilderSlideItemMessage_Long.value)}}" stepKey="seeSlide1ContentStorefront"/>
11221124
<executeJS function="{{PageBuilderStoreFront.computedHeight(PageBuilderSliderContentType.role, '0')}}" stepKey="slideNewHeightStorefront"/>
11231125
<assertGreaterThan stepKey="assertSlideHeightGrewStorefront">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1457,7 +1457,8 @@
14571457
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanel1Settings"/>
14581458
<!-- User Still Sees Slide Item Option Menu If Hovering Over Slider -->
14591459
<comment userInput="User Still Sees Slide Item Option Menu If Hovering Over Slider" stepKey="commentHoverSlider"/>
1460-
<waitForElementVisible selector="{{SlideOnBackend.optionsMenu('1')}}" stepKey="waitForSlideOptionsMenu"/>
1460+
<click selector="{{SliderOnStage.slideNavigationDot('1', '1')}}" stepKey="clickSlideOptionsMenu"/>
1461+
<waitForPageLoad stepKey="waitForPageLoad"/>
14611462
<seeElement selector="{{SlideOnBackend.optionsMenu('1')}}" stepKey="seeSlideOptionsMenu2"/>
14621463
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStageByIndex(PageBuilderSliderContentType.role, '1')}}" stepKey="mouseOverSlider"/>
14631464
<waitForPageLoad stepKey="waitForPageLoad1"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemLayoutTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
-->
88

99
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10-
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd">
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1111
<test name="TabItemValidateLayoutSectionDefaultValues">
1212
<annotations>
1313
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)