Skip to content

Commit af675f6

Browse files
author
hannahnida
committed
#558: Developer can style content types output differently per viewport - General Mftf fixes
2 parents 6bd9471 + 6725818 commit af675f6

File tree

3 files changed

+23
-4
lines changed

3 files changed

+23
-4
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10+
<actionGroup name="ValidateAdvancedConfigurationNotSetActionGroup" extends="ValidateAdvancedConfigurationWithAllUpdatedNotVisibleActionGroup">
11+
<annotations>
12+
<description value="Validates Advanced configuration was not set"/>
13+
</annotations>
14+
<waitForElementVisible selector="{{page.noCssClasses(index)}}" stepKey="waitForCSSClasses"/>
15+
<remove keyForRemoval="dontSeeCSSClasses"/>
16+
</actionGroup>
17+
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedStyleWithNoConfigurationActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="validateAdvancedStyleWithNoConfiguration" deprecated="Styles are not inline, use ValidateAdvancedConfigurationWithAllUpdatedNotVisibleActionGroup">
10+
<actionGroup name="validateAdvancedStyleWithNoConfiguration" deprecated="Styles are not inline, use ValidateAdvancedConfigurationNotSetActionGroup">
1111
<arguments>
1212
<argument name="page" defaultValue=""/>
1313
<argument name="index" defaultValue="1" type="string"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest/AdvancedConfigurationRemoveAllAttributesTest.xml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,23 +110,25 @@
110110
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
111111
<!-- Stage: Check All Attributes -->
112112
<comment userInput="Stage: Check All Attributes" stepKey="commentStageCheck2"/>
113-
<actionGroup ref="ValidateAdvancedConfigurationWithAllUpdatedNotVisibleActionGroup" stepKey="validateStage3">
113+
<actionGroup ref="ValidateAdvancedConfigurationNotSetActionGroup" stepKey="validateStage3">
114114
<argument name="page" value="TextOnStage"/>
115+
<argument name="defaultAlignment" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
115116
</actionGroup>
116117
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen2"/>
117118
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage2"/>
118119
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
119120
<!-- Stage: Check All Attributes -->
120121
<comment userInput="Validate Stage After Save" stepKey="commentStageAfterSave3"/>
121-
<actionGroup ref="ValidateAdvancedConfigurationWithAllUpdatedNotVisibleActionGroup" stepKey="validateStage4">
122+
<actionGroup ref="ValidateAdvancedConfigurationNotSetActionGroup" stepKey="validateStage4">
122123
<argument name="page" value="TextOnStage"/>
124+
<argument name="defaultAlignment" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
123125
</actionGroup>
124126
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
125127
<argument name="contentType" value="PageBuilderTextContentType"/>
126128
</actionGroup>
127129
<!-- Storefront: Check All Attributes -->
128130
<comment userInput="Storefront: Check All Attributes" stepKey="commentStorefrontCheck"/>
129-
<actionGroup ref="ValidateAdvancedConfigurationWithAllUpdatedNotVisibleActionGroup" stepKey="validateStorefront">
131+
<actionGroup ref="ValidateAdvancedConfigurationNotSetActionGroup" stepKey="validateStorefront">
130132
<argument name="page" value="TextOnStorefront"/>
131133
</actionGroup>
132134
</test>

0 commit comments

Comments
 (0)