Skip to content

Commit aea6518

Browse files
committed
MC-5474: Anchor tag name is used on banner/slide/image wrapper when no link is specified by admin
Do string type checking on potential array
1 parent f3e187a commit aea6518

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/attribute/link-href.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/link-href.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export default class CreateValueForHref implements ConverterInterface {
7272

7373
if (isHrefId && link) {
7474
href = this.convertToWidget(link[linkType], linkType);
75-
} else if (link[linkType]) {
75+
} else if (typeof link[linkType] === "string") {
7676
href = link[linkType];
7777
}
7878

0 commit comments

Comments
 (0)