Skip to content

Commit ade61c7

Browse files
bluemwhitewbluemwhitew
committed
#425: Infinite Loop Disabled on Slider Does Not Work Correctly
- Removing Instances of `useCaseId` and `testCaseId` - Replacing Instances of `seeElement` with `waitForElementVisible`
1 parent 122eb6d commit ade61c7

File tree

2 files changed

+20
-24
lines changed

2 files changed

+20
-24
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests/SliderValidateInfiniteLoopDisabled.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
<title value="Slider - Validate Infinite Looping (Disabled)"/>
1414
<description value="A user should not be able to navigate before the first slide, or after the last slide when Infinite Loop is disabled."/>
1515
<severity value="BLOCKER"/>
16-
<useCaseId value=""/>
17-
<testCaseId value=""/>
1816
<group value="pagebuilder"/>
1917
<group value="pagebuilder-slide"/>
2018
<group value="pagebuilder-sliderCommon"/>
@@ -24,12 +22,12 @@
2422
<argument name="property" value="PageBuilderSliderInfiniteLoop_Disabled"/>
2523
</actionGroup>
2624
<!-- Validate Stage: Slider Settings -->
27-
<seeElement selector="{{SliderOnStage.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Disabled.value)}}" stepKey="seeInfiniteLoopStage"/>
25+
<waitForElementVisible selector="{{SliderOnStage.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Disabled.value)}}" stepKey="seeInfiniteLoopStage"/>
2826
<!-- Validate Storefront: Slider Settings -->
29-
<seeElement selector="{{SliderOnFrontend.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Disabled.value)}}" stepKey="seeInfiniteLoopStorefront"/>
27+
<waitForElementVisible selector="{{SliderOnFrontend.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Disabled.value)}}" stepKey="seeInfiniteLoopStorefront"/>
3028
<!-- Validate Storefront: Slide 1 -->
31-
<seeElement selector="{{SliderOnFrontend.previousSlideArrowDisabled('1')}}" stepKey="seePreviousSlideArrow"/>
29+
<waitForElementVisible selector="{{SliderOnFrontend.previousSlideArrowDisabled('1')}}" stepKey="seePreviousSlideArrow"/>
3230
<!-- Validate Storefront: Slide 2 -->
33-
<seeElement selector="{{SliderOnFrontend.nextSlideArrowDisabled('1')}}" stepKey="seeNextSlideArrow2"/>
31+
<waitForElementVisible selector="{{SliderOnFrontend.nextSlideArrowDisabled('1')}}" stepKey="seeNextSlideArrow2"/>
3432
</test>
3533
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests/SliderValidateInfiniteLoopEnabled.xml

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
<title value="Slider - Validate Infinite Looping (Enabled)"/>
1414
<description value="A user should be able to navigate before the first slide, and after the last slide when Infinite Loop is enabled."/>
1515
<severity value="BLOCKER"/>
16-
<useCaseId value=""/>
17-
<testCaseId value=""/>
1816
<group value="pagebuilder"/>
1917
<group value="pagebuilder-slide"/>
2018
<group value="pagebuilder-sliderCommon"/>
@@ -80,37 +78,37 @@
8078
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
8179
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
8280
<!-- Validate Stage: Slider Settings -->
83-
<seeElement selector="{{SliderOnStage.autoPlay('1', PageBuilderSliderAutoPlay_Disabled.value)}}" stepKey="seeAutoPlayStage"/>
84-
<seeElement selector="{{SliderOnStage.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Enabled.value)}}" stepKey="seeInfiniteLoopStage"/>
85-
<seeElement selector="{{SliderOnStage.showArrows('1', PageBuilderSliderShowArrows_Enabled.value)}}" stepKey="seeArrowsStage"/>
86-
<seeElement selector="{{SliderOnStage.showDots('1', PageBuilderSliderShowDots_Enabled.value)}}" stepKey="seeDotsStage"/>
81+
<waitForElementVisible selector="{{SliderOnStage.autoPlay('1', PageBuilderSliderAutoPlay_Disabled.value)}}" stepKey="seeAutoPlayStage"/>
82+
<waitForElementVisible selector="{{SliderOnStage.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Enabled.value)}}" stepKey="seeInfiniteLoopStage"/>
83+
<waitForElementVisible selector="{{SliderOnStage.showArrows('1', PageBuilderSliderShowArrows_Enabled.value)}}" stepKey="seeArrowsStage"/>
84+
<waitForElementVisible selector="{{SliderOnStage.showDots('1', PageBuilderSliderShowDots_Enabled.value)}}" stepKey="seeDotsStage"/>
8785
<!-- Validate Stage: Slide 1 -->
8886
<click selector="{{SliderOnStage.slideNavigationDot('1', '1')}}" stepKey="clickSlide1Stage"/>
8987
<waitForPageLoad stepKey="waitForPageLoad"/>
90-
<seeElement selector="{{SlideOnBackend.messageContent('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeSlide1ContentStage"/>
88+
<waitForElementVisible selector="{{SlideOnBackend.messageContent('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeSlide1ContentStage"/>
9189
<!-- Validate Stage: Slide 2 -->
9290
<click selector="{{SliderOnStage.nextSlideArrow('1')}}" stepKey="clickSlide2Stage"/>
9391
<waitForPageLoad stepKey="waitForPageLoad2"/>
94-
<seeElement selector="{{SlideOnBackend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentStage"/>
92+
<waitForElementVisible selector="{{SlideOnBackend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentStage"/>
9593
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
9694
<argument name="contentType" value="PageBuilderSliderContentType"/>
9795
</actionGroup>
9896
<!-- Validate Storefront: Slider Settings -->
99-
<seeElement selector="{{SliderOnFrontend.autoPlay('1', PageBuilderSliderAutoPlay_Disabled.value)}}" stepKey="seeAutoPlayStorefront"/>
100-
<seeElement selector="{{SliderOnFrontend.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Enabled.value)}}" stepKey="seeInfiniteLoopStorefront"/>
101-
<seeElement selector="{{SliderOnFrontend.showArrows('1', PageBuilderSliderShowArrows_Enabled.value)}}" stepKey="seeArrowsStorefront"/>
102-
<seeElement selector="{{SliderOnFrontend.showDots('1', PageBuilderSliderShowDots_Enabled.value)}}" stepKey="seeDotsStorefront"/>
97+
<waitForElementVisible selector="{{SliderOnFrontend.autoPlay('1', PageBuilderSliderAutoPlay_Disabled.value)}}" stepKey="seeAutoPlayStorefront"/>
98+
<waitForElementVisible selector="{{SliderOnFrontend.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Enabled.value)}}" stepKey="seeInfiniteLoopStorefront"/>
99+
<waitForElementVisible selector="{{SliderOnFrontend.showArrows('1', PageBuilderSliderShowArrows_Enabled.value)}}" stepKey="seeArrowsStorefront"/>
100+
<waitForElementVisible selector="{{SliderOnFrontend.showDots('1', PageBuilderSliderShowDots_Enabled.value)}}" stepKey="seeDotsStorefront"/>
103101
<!-- Validate Storefront: Slide 1 -->
104102
<click selector="{{SliderOnFrontend.slideNavigationDot('1', '1')}}" stepKey="clickSlide1Storefront"/>
105103
<waitForPageLoad stepKey="waitForPageLoad3"/>
106-
<seeElement selector="{{SlideOnFrontend.messageContent('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeSlide1ContentStorefront"/>
107-
<seeElement selector="{{SliderOnFrontend.previousSlideArrowEnabled('1')}}" stepKey="seePreviousSlideArrow"/>
108-
<seeElement selector="{{SliderOnFrontend.nextSlideArrowEnabled('1')}}" stepKey="seeNextSlideArrow"/>
104+
<waitForElementVisible selector="{{SlideOnFrontend.messageContent('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeSlide1ContentStorefront"/>
105+
<waitForElementVisible selector="{{SliderOnFrontend.previousSlideArrowEnabled('1')}}" stepKey="seePreviousSlideArrow"/>
106+
<waitForElementVisible selector="{{SliderOnFrontend.nextSlideArrowEnabled('1')}}" stepKey="seeNextSlideArrow"/>
109107
<!-- Validate Storefront: Slide 2 -->
110108
<click selector="{{SliderOnFrontend.nextSlideArrow('1')}}" stepKey="clickSlide2Storefront"/>
111109
<waitForPageLoad stepKey="waitForPageLoad4"/>
112-
<seeElement selector="{{SlideOnFrontend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentStorefront"/>
113-
<seeElement selector="{{SliderOnFrontend.previousSlideArrowEnabled('1')}}" stepKey="seePreviousSlideArrow2"/>
114-
<seeElement selector="{{SliderOnFrontend.nextSlideArrowEnabled('1')}}" stepKey="seeNextSlideArrow2"/>
110+
<waitForElementVisible selector="{{SlideOnFrontend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentStorefront"/>
111+
<waitForElementVisible selector="{{SliderOnFrontend.previousSlideArrowEnabled('1')}}" stepKey="seePreviousSlideArrow2"/>
112+
<waitForElementVisible selector="{{SliderOnFrontend.nextSlideArrowEnabled('1')}}" stepKey="seeNextSlideArrow2"/>
115113
</test>
116114
</tests>

0 commit comments

Comments
 (0)