MC-4116: Update slider to use new background images logic

- update integration tests

Author: anthoula

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/AdvancedSliderItem.php

@@ -60,6 +60,8 @@ public function render(array $itemData, array $additionalData = []) : string
 
         $formData = $itemData['formData'] ?? [];
         $backgroundImages = '';
+        $backgroundImagesAttr = '{}';
+
         if (isset($eavData['background_image'])) {
             $backgroundImages = $eavData['background_image'];
         } elseif (isset($eavData['image'])) {
@@ -74,12 +76,6 @@ public function render(array $itemData, array $additionalData = []) : string
                 . '}}\",\"'
                 . 'mobile_image\":\"'
                 . '{}\"}';
-        } else {
-            $backgroundImagesAttr = '{\"'
-                . 'desktop_image\":\"'
-                . '{}\",\"'
-                . 'mobile_image\":\"'
-                . '{}\"}';
         }
 
         $margin = $this->styleExtractor->extractStyle($formData, ['margin']);

dev/tests/integration/testsuite/Magento/PageBuilder/_files/advanced_slider.html

@@ -1 +1 @@
-<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="0" data-autoplay-speed="0" data-fade="0" data-is-infinite="0" data-show-arrows="0" data-show-dots="0" class="one two pagebuilder-slider" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="slide" data-appearance="poster" class="one two" style="margin: 2px 3px 4px 1px;"><div data-element="link" data-href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{}\&quot;,\&quot;mobile_image\&quot;:\&quot;{}\&quot;}" class="pagebuilder-slide-wrapper" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent" style="padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div><button data-element="button" type="button" class="pagebuilder-slide-button pagebuilder-button-primary" style="opacity: 1; visibility: visible;">Domain</button></div></div></div></div></div></div></div></div>
+<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="0" data-autoplay-speed="0" data-fade="0" data-is-infinite="0" data-show-arrows="0" data-show-dots="0" class="one two pagebuilder-slider" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="slide" data-appearance="poster" class="one two" style="margin: 2px 3px 4px 1px;"><div data-element="link" data-href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent" style="padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div><button data-element="button" type="button" class="pagebuilder-slide-button pagebuilder-button-primary" style="opacity: 1; visibility: visible;">Domain</button></div></div></div></div></div></div></div></div>

dev/tests/integration/testsuite/Magento/PageBuilder/_files/advanced_slider_no_link_text.html

@@ -1 +1 @@
-<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="link" data-href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{}\&quot;,\&quot;mobile_image\&quot;:\&quot;{}\&quot;}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></div></div></div></div></div>
+<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="link" data-href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></div></div></div></div></div>

dev/tests/integration/testsuite/Magento/PageBuilder/_files/advanced_slider_overlay.html

@@ -1 +1 @@
-<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="link" data-href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{}\&quot;,\&quot;mobile_image\&quot;:\&quot;{}\&quot;}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="rgba(0,0,0,0.5)" style="background-color: rgba(0,0,0,0.5);"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></div></div></div></div></div>
+<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="link" data-href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="rgba(0,0,0,0.5)" style="background-color: rgba(0,0,0,0.5);"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></div></div></div></div></div>