Skip to content

Commit ad244d7

Browse files
committed
#558: Content Types Output Style Attribute Removal
- Code Review Feedback/Amends (Thanks, @BarnyShergold)
1 parent c5f9154 commit ad244d7

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

app/code/Magento/PageBuilder/Setup/Converters/PageBuilderStripStyles.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ private function generateInternalStyles(array $styleMap): string
6666
/**
6767
* @inheritDoc
6868
*/
69-
public function convert($value)
69+
public function convert($value): string
7070
{
7171
libxml_use_internal_errors(true);
7272
$document = new DOMDocument();

app/code/Magento/PageBuilder/Setup/Patch/Data/UpgradePageBuilderStripStyles.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use Magento\PageBuilder\Setup\UpgradeContentHelper;
1515

1616
/**
17-
* ...
17+
* Patch Upgrade Mechanism for Converting Inline Styles to Internal
1818
*/
1919
class UpgradePageBuilderStripStyles implements DataPatchInterface
2020
{
@@ -26,9 +26,8 @@ class UpgradePageBuilderStripStyles implements DataPatchInterface
2626
/**
2727
* @param UpgradeContentHelper $helper
2828
*/
29-
public function __construct(
30-
UpgradeContentHelper $helper
31-
) {
29+
public function __construct(UpgradeContentHelper $helper)
30+
{
3231
$this->helper = $helper;
3332
}
3433

@@ -48,15 +47,15 @@ public function apply()
4847
/**
4948
* @inheritdoc
5049
*/
51-
public function getAliases()
50+
public function getAliases(): array
5251
{
5352
return [];
5453
}
5554

5655
/**
5756
* @inheritdoc
5857
*/
59-
public static function getDependencies()
58+
public static function getDependencies(): array
6059
{
6160
return [];
6261
}

0 commit comments

Comments
 (0)