Skip to content

Commit ac1558a

Browse files
committed
MC-3348: Unskip delete image tests
- update selectors to use index
1 parent c6a6fb1 commit ac1558a

File tree

5 files changed

+5
-3
lines changed

5 files changed

+5
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
</arguments>
9999
<attachFile userInput="{{property.value}}" selector="{{section.uploadImageInput(index)}}" stepKey="attachImageFromLocalToStage"/>
100100
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear"/>
101-
<waitForElementVisible selector="{{section.imageSource(property.fileName)}}" stepKey="waitForMainImageSource1"/>
101+
<waitForElementVisible selector="{{section.imageSourceByIndex(index, property.fileName)}}" stepKey="waitForMainImageSource1"/>
102102
</actionGroup>
103103
<actionGroup name="inlineEditWYSIWYGFromStage">
104104
<arguments>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBannerSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
<element name="editableButtonOnStage" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]//button//span[@contenteditable='true']" parameterized="true"/>
8383
<element name="wysiwygLinkUrl" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]//a[@href='{{arg2}}']" parameterized="true"/>
8484
<element name="imageOnStage" type="text" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]//img[contains(@src,'{{var1}}')]" parameterized="true"/>
85-
<element name="imageSource" type="text" selector="(//div[@data-role='banner'])[1]/div[contains(@style,'{{arg1}}')]" parameterized="true"/>
85+
<element name="imageSourceByIndex" type="text" selector="(//div[@data-role='banner'])[{{arg1}}]/div[contains(@style,'{{arg2}}')]" parameterized="true"/>
8686
<element name="uploadImageInput" type="button" selector="//div[contains(@class,'pagebuilder-image-uploader-container')]//input[@name='background_image']"/>
8787
<!-- Appearance Configuration -->
8888
<element name="appearance" type="text" selector="(//div[contains(@class,'pagebuilder-banner') and @data-element='main'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@
142142
<element name="base" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]" parameterized="true"/>
143143
<element name="emptySlide" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//div[@data-element='content'][contains(@class,'pagebuilder-empty-slide') and text()='Edit Slide Text']" parameterized="true"/>
144144
<element name="editableButtonItemElement" type="button" selector="(//div[@data-role='slide'])[{{arg1}}]//a[@data-element='button']//span[contains(@contenteditable, 'true')]" parameterized="true"/>
145-
<element name="imageSource" type="text" selector="(//div[@data-role='slide'])[1]/div[contains(@style,'{{arg1}}')]" parameterized="true"/>
145+
<element name="imageSourceByIndex" type="text" selector="(//div[@data-role='slide'])[{{arg1}}]/div[contains(@style,'{{arg2}}')]" parameterized="true"/>
146146
<element name="openOptionsMenu" type="button" selector="(//div[contains(@class,'navigation-dot')])[{{arg1}}]" parameterized="true"/>
147147
<element name="optionsMenu" type="button" selector="(//div[contains(@class,'navigation-dot')])[{{arg1}}]//div[@class='pagebuilder-options-wrapper']" parameterized="true"/>
148148
<element name="optionsMenuButton" type="button" selector="(//div[contains(@class,'navigation-dot')])[{{arg1}}]//li[contains(@class,'pagebuilder-options-link')]//a[contains(@class,'{{arg2}}')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2076,6 +2076,7 @@
20762076
<argument name="Image" value="PageBuilderBackgroundImage_JPG"/>
20772077
</actionGroup>
20782078
<click selector="{{MediaGallerySection.CancelBtn}}" stepKey="closeSlideOut2"/>
2079+
<waitForPageLoad stepKey="waitForPageLoad"/>
20792080
<actionGroup ref="seeNoImageUploadedOnSlideOut" stepKey="validateNoBackgroundImage">
20802081
<argument name="property" value="PageBuilderBackgroundImage_JPG"/>
20812082
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
<argument name="Image" value="PageBuilderImageProperty_StageJPG"/>
118118
</actionGroup>
119119
<click selector="{{MediaGallerySection.CancelBtn}}" stepKey="closeSlideOut4"/>
120+
<waitForPageLoad stepKey="waitForPageLoad3"/>
120121
<actionGroup ref="seeNoImageUploadedOnSlideOut" stepKey="validateNoImage1">
121122
<argument name="property" value="PageBuilderImageProperty_StageJPG"/>
122123
</actionGroup>

0 commit comments

Comments
 (0)