Skip to content

Commit ab785ff

Browse files
committed
MC-5835: [Sec] XSS in Page Builder
Add ProductConditionsInvulnerableToXSS
1 parent 902becd commit ab785ff

File tree

1 file changed

+50
-0
lines changed

1 file changed

+50
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsTest.xml

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1359,4 +1359,54 @@
13591359
<expectedResult type="variable">productActionsWidthFrontend</expectedResult>
13601360
</assertGreaterThan>
13611361
</test>
1362+
<test name="ProductConditionsInvulnerableToXSS">
1363+
<annotations>
1364+
<features value="PageBuilder"/>
1365+
<stories value="Products"/>
1366+
<title value="Product Content Type is invulnerable to XSS via product condition payload injection"/>
1367+
<description value="As a Content Manager I want Product Content Type to be invulnerable to XSS via product condition payload injection so that the security of my admin experience is retained"/>
1368+
<severity value="CRITICAL"/>
1369+
<useCaseId value="MC-5835"/>
1370+
<testCaseId value="MC-6486"/>
1371+
<group value="pagebuilder"/>
1372+
<group value="pagebuilder-products"/>
1373+
<group value="pagebuilder-security"/>
1374+
</annotations>
1375+
<before>
1376+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1377+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1378+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1379+
</before>
1380+
<after>
1381+
<actionGroup ref="logout" stepKey="logout"/>
1382+
</after>
1383+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1384+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1385+
</actionGroup>
1386+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1387+
<argument name="group" value="PageBuilderProductsContentType"/>
1388+
</actionGroup>
1389+
<actionGroup ref="dragContentTypeToStage" stepKey="dragProductsOntoStage">
1390+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1391+
</actionGroup>
1392+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
1393+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1394+
</actionGroup>
1395+
<actionGroup ref="addCategoryConditionToProductsBlock" stepKey="addCategory">
1396+
<argument name="page" value="ProductsContentTypeForm"/>
1397+
<argument name="category" value="&gt;&lt;img src=x onerror=throw(1)&gt;"/>
1398+
</actionGroup>
1399+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1400+
<!-- Validate Stage -->
1401+
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
1402+
<dontSeeJsError stepKey="doNotSeeAnyJSErrorsOnStage"/>
1403+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
1404+
<dontSeeJsError stepKey="doNotSeeAnyJSErrorsOnStageAfterSaving"/>
1405+
<!-- Validate Storefront -->
1406+
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
1407+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1408+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1409+
</actionGroup>
1410+
<dontSeeJsError stepKey="doNotSeeAnyJSErrorsOnStorefront"/>
1411+
</test>
13621412
</tests>

0 commit comments

Comments
 (0)