Skip to content

Commit aa44396

Browse files
committed
#425: Infinite Loop Disabled on Slider Does Not Work Correctly
- Adding `nextSlide` - Refactoring
1 parent a4f3305 commit aa44396

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
9+
<actionGroup name="nextSlide">
10+
<arguments>
11+
<argument name="sliderSection" defaultValue="SliderOnStage"/>
12+
<argument name="sliderIndex" defaultValue="1" type="string"/>
13+
</arguments
14+
<waitForElementVisible selector="{{sliderSection.nextSlideArrow(sliderIndex)}}" stepKey="waitForNextSlideArrow"/>
15+
<click selector="{{sliderSection.nextSlideArrow(sliderIndex)}}" stepKey="clickNextSlideArrow"/>
16+
<waitForPageLoad stepKey="waitForPageLoad"/>
17+
</actionGroup>
18+
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests/SliderValidateInfiniteLoopEnabled.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@
8888
</actionGroup>
8989
<waitForElementVisible selector="{{SlideOnBackend.messageContent('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeSlide1ContentStage"/>
9090
<!-- Validate Stage: Slide 2 -->
91-
<click selector="{{SliderOnStage.nextSlideArrow('1')}}" stepKey="clickSlide2Stage"/>
92-
<waitForPageLoad stepKey="waitForPageLoad2"/>
91+
<actionGroup ref="nextSlide" stepKey="clickSlide2Stage"/>
9392
<waitForElementVisible selector="{{SlideOnBackend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentStage"/>
9493
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
9594
<argument name="contentType" value="PageBuilderSliderContentType"/>
@@ -109,8 +108,9 @@
109108
<waitForElementVisible selector="{{SliderOnFrontend.previousSlideArrowEnabled('1')}}" stepKey="seePreviousSlideArrow"/>
110109
<waitForElementVisible selector="{{SliderOnFrontend.nextSlideArrowEnabled('1')}}" stepKey="seeNextSlideArrow"/>
111110
<!-- Validate Storefront: Slide 2 -->
112-
<click selector="{{SliderOnFrontend.nextSlideArrow('1')}}" stepKey="clickSlide2Storefront"/>
113-
<waitForPageLoad stepKey="waitForPageLoad4"/>
111+
<actionGroup ref="nextSlide" stepKey="clickSlide2Storefront">
112+
<argument name="sliderSection" value="SliderOnFrontend"/>
113+
</actionGroup>
114114
<waitForElementVisible selector="{{SlideOnFrontend.messageContent('2', PageBuilderSlideItemContent_Slide2.value)}}" stepKey="seeSlide2ContentStorefront"/>
115115
<waitForElementVisible selector="{{SliderOnFrontend.previousSlideArrowEnabled('1')}}" stepKey="seePreviousSlideArrow2"/>
116116
<waitForElementVisible selector="{{SliderOnFrontend.nextSlideArrowEnabled('1')}}" stepKey="seeNextSlideArrow2"/>

0 commit comments

Comments
 (0)