Skip to content

Commit a90a74b

Browse files
committed
MC-4137: TinyMCE Issues within inline WYSIWYG
1 parent d136823 commit a90a74b

File tree

2 files changed

+1
-63
lines changed

2 files changed

+1
-63
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTextSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,6 @@
100100
<element name="noMargins" type="text" selector="(//div[@data-content-type='text'])[{{arg1}}][not(contains(@style,'margin:'))]" parameterized="true"/>
101101
<element name="padding" type="text" selector="(//div[@data-content-type='text'])[{{arg1}}][contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
102102
<element name="noPadding" type="text" selector="(//div[@data-content-type='text'])[{{arg1}}][not(contains(@style,'padding:'))]" parameterized="true"/>
103-
<element name="emptyText" type="text" selector="//div[@data-content-type='text']/p[not(text())]"/>
103+
<element name="emptyText" type="text" selector="//div[@data-content-type='text' and not(text())]"/>
104104
</section>
105105
</sections>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 0 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -2018,68 +2018,6 @@
20182018
<seeElement selector="{{BannerOnBackend.emptyBanner('1')}}" stepKey="seeBannerPlaceholder2"/>
20192019
<dontSeeElementInDOM selector="{{BannerOnBackend.imageOnStage('1',PageBuilderBackgroundImage_JPG.fileName)}}" stepKey="dontSeeImageInDOM2"/>
20202020
</test>
2021-
<test name="BannerInlineEditStaysFocusedWhileDraggingAndDropping">
2022-
<annotations>
2023-
<features value="PageBuilder"/>
2024-
<stories value="Banner"/>
2025-
<title value="Banner - Inline Edit Stays Focused While Dragging And Dropping"/>
2026-
<description value="Verify that the Banner inline edit stays in focus while users drag and drop content"/>
2027-
<severity value="MINOR"/>
2028-
<useCaseId value="MC-937"/>
2029-
<testCaseId value="MC-3840"/>
2030-
<group value="pagebuilder"/>
2031-
<group value="pagebuilder-banner"/>
2032-
</annotations>
2033-
<before>
2034-
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG"/>
2035-
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4"/>
2036-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2037-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2038-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2039-
</before>
2040-
<after>
2041-
<actionGroup ref="logout" stepKey="logout"/>
2042-
</after>
2043-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
2044-
<argument name="contentType" value="PageBuilderBannerContentType"/>
2045-
</actionGroup>
2046-
<!-- Add Banner -->
2047-
<comment userInput="Add Banner" stepKey="commentAddBanner"/>
2048-
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
2049-
<argument name="contentType" value="PageBuilderBannerContentType"/>
2050-
</actionGroup>
2051-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragContentTypeIntoContainer">
2052-
<argument name="contentType" value="PageBuilderBannerContentType"/>
2053-
</actionGroup>
2054-
<!-- Activate Inline Edit -->
2055-
<comment userInput="Activate Inline Edit" stepKey="commentInlineEdit"/>
2056-
<click selector="{{PageBuilderStage.inlineWYSIWYGEditor(PageBuilderBannerContentType.role, '1')}}" stepKey="focusOnEditorArea"/>
2057-
<waitForElementVisible selector="{{PageBuilderStage.inlineWYSIWYGEditorPanel(PageBuilderBannerContentType.role, '1')}}" stepKey="waitForEditorPanel"/>
2058-
<!-- Add Columns -->
2059-
<comment userInput="Add Columns" stepKey="commentAddColumns"/>
2060-
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection2">
2061-
<argument name="contentType" value="PageBuilderColumnContentType"/>
2062-
</actionGroup>
2063-
<actionGroup ref="dragContentTypeToStage" stepKey="dragContentTypeToStage">
2064-
<argument name="contentType" value="PageBuilderColumnContentType"/>
2065-
</actionGroup>
2066-
<!-- Verify Editor Still In Focus -->
2067-
<comment userInput="Verify Editor Still In Focus" stepKey="commentEditorInFocus"/>
2068-
<seeElement selector="{{PageBuilderStage.inlineWYSIWYGEditorPanel(PageBuilderBannerContentType.role, '1')}}" stepKey="seeEditorPanel"/>
2069-
<!-- Verify Content Type Option Menus Are Hidden -->
2070-
<comment userInput="Verify Content Type Option Menus Are Hidden" stepKey="commentOptionsHidden"/>
2071-
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStage(PageBuilderBannerContentType.role)}}" stepKey="mouseOverBanner"/>
2072-
<waitForPageLoad stepKey="waitForPageLoad"/>
2073-
<seeElementInDOM selector="{{PageBuilderContentTypeOptionsMenu.contentTypeOptionsMenu(PageBuilderBannerContentType.role)}}" stepKey="seeBannerOptionsInDOM"/>
2074-
<dontSeeElement selector="{{PageBuilderContentTypeOptionsMenu.contentTypeOptionsMenu(PageBuilderBannerContentType.role)}}" stepKey="dontSeeBannerOptions"/>
2075-
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStage(PageBuilderColumnContentType.role)}}" stepKey="mouseOverColumn"/>
2076-
<waitForPageLoad stepKey="waitForPageLoad2"/>
2077-
<seeElementInDOM selector="{{PageBuilderContentTypeOptionsMenu.contentTypeOptionsMenu(PageBuilderColumnContentType.role)}}" stepKey="seeColumnOptionsInDOM"/>
2078-
<dontSeeElement selector="{{PageBuilderContentTypeOptionsMenu.contentTypeOptionsMenu(PageBuilderColumnContentType.role)}}" stepKey="dontSeeColumnOptions"/>
2079-
<!-- Verify Editor Still In Focus 2 -->
2080-
<comment userInput="Verify Editor Still In Focus 2" stepKey="commentEditorInFocus2"/>
2081-
<seeElement selector="{{PageBuilderStage.inlineWYSIWYGEditorPanel(PageBuilderBannerContentType.role, '1')}}" stepKey="seeEditorPanel2"/>
2082-
</test>
20832021
<test name="BannerContentVariableCanWrap">
20842022
<annotations>
20852023
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)