Skip to content

Commit a80e407

Browse files
committed
use core Configuration as one entry point to get openDialogUrl
1 parent 383f584 commit a80e407

File tree

2 files changed

+7
-13
lines changed
  • app/code/Magento/PageBuilder

2 files changed

+7
-13
lines changed

app/code/Magento/PageBuilder/Model/Config/ContentType/AdditionalData/Provider/Uploader/OpenDialogUrl.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
use Magento\PageBuilder\Model\Config\ContentType\AdditionalData\ProviderInterface;
1212
use Magento\Backend\Model\Url;
13+
use Magento\Ui\Component\Form\Element\DataType\Media\OpenDialogUrl as OpenDialogConfig;
1314

1415
/**
1516
* Provides open dialog URL for media gallery slideout
@@ -22,20 +23,20 @@ class OpenDialogUrl implements ProviderInterface
2223
private $urlBuilder;
2324

2425
/**
25-
* @var string
26+
* @var OpenDialogConfig
2627
*/
27-
private $openDialogPath;
28+
private $openDialogConfig;
2829

2930
/**
3031
* @param Url $urlBuilder
31-
* @param array $openDialogPath
32+
* @param OpenDialogConfig $openDialogCOnfig
3233
*/
3334
public function __construct(
3435
Url $urlBuilder,
35-
array $openDialogPath
36+
OpenDialogConfig $openDialogConfig
3637
) {
3738
$this->urlBuilder = $urlBuilder;
38-
$this->openDialogPath = array_shift($openDialogPath);
39+
$this->openDialogConfig = $openDialogConfig;
3940
}
4041

4142
/**
@@ -44,7 +45,7 @@ public function __construct(
4445
public function getData(string $itemName) : array
4546
{
4647
return [
47-
$itemName => $this->urlBuilder->getUrl($this->openDialogPath, ['_secure' => true])
48+
$itemName => $this->urlBuilder->getUrl($this->openDialogConfig->getOpenDialogUrl(), ['_secure' => true])
4849
];
4950
}
5051
}

app/code/Magento/PageBuilder/etc/adminhtml/di.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,6 @@
1212
<type name="Magento\Catalog\Block\Product\ImageFactory">
1313
<plugin name="designLoader" type="Magento\PageBuilder\Plugin\DesignLoader" />
1414
</type>
15-
<type name="Magento\PageBuilder\Model\Config\ContentType\AdditionalData\Provider\Uploader\OpenDialogUrl">
16-
<arguments>
17-
<argument name="openDialogPath" xsi:type="array">
18-
<item name="default" xsi:type="string">cms/wysiwyg_images/index</item>
19-
</argument>
20-
</arguments>
21-
</type>
2215
<virtualType name="Magento\PageBuilder\Block\Adminhtml\ContentType\Edit\ModalCloseButton" type="Magento\PageBuilder\Block\Adminhtml\ContentType\Edit\CloseButton">
2316
<arguments>
2417
<argument name="targetName" xsi:type="string">ns = pagebuilder_modal_form, index = modal</argument>

0 commit comments

Comments
 (0)