Skip to content

Commit a6bc082

Browse files
sumesh-GLsumesh-GL
committed
AC-12719: [PageBuilder] MFTF Test Failure - videos playing assertion fails
Revert unwanted changes
1 parent 130db26 commit a6bc082

File tree

7 files changed

+38
-15
lines changed

7 files changed

+38
-15
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup/ValidateVideoBackgroundPlayingActionGroup.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright 2020 Adobe
5-
* All rights reserved.
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
66
*/
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -13,11 +13,13 @@
1313
</annotations>
1414
<arguments>
1515
<argument name="section" defaultValue="RowOnStage"/>
16+
<argument name="videoUrl" defaultValue="PageBuilderVideoBackgroundUrl_Empty"/>
1617
<argument name="index" defaultValue="1" type="string"/>
1718
</arguments>
1819
<waitForPageLoad stepKey="waitForPageLoad"/>
1920
<wait time="5" stepKey="waitToPreventVideoFlakiness"/>
2021
<waitForElementVisible selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
22+
<waitForElement selector="{{section.videoBackgroundVideoUrl(index, videoUrl.renderedValue)}}" stepKey="waitForVideoUrl"/>
2123
<grabAttributeFrom selector="{{section.videoBackgroundVideoElement(index)}}" userInput="style" stepKey="videoStyle"/>
2224
<assertStringContainsString stepKey="assertVideoPlaying">
2325
<expectedResult type="string">transform: translate3d(</expectedResult>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup/ValidateVideoBackgroundWithAllAttributesActionGroup.xml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright 2020 Adobe
5-
* All rights reserved.
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
66
*/
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -14,6 +14,7 @@
1414
<arguments>
1515
<argument name="section" defaultValue="RowOnStage"/>
1616
<argument name="backgroundColor" defaultValue="{{PageBuilderBackgroundColor_Default.rgb}}" type="string"/>
17+
<argument name="videoUrl" defaultValue="PageBuilderVideoBackgroundUrl_Empty"/>
1718
<argument name="overlayColor" defaultValue="{{PageBuilderVideoBackgroundOverlayColor_Empty.rgb}}" type="string"/>
1819
<argument name="infiniteLoop" defaultValue="PageBuilderVideoBackgroundInfiniteLoop_Enabled"/>
1920
<argument name="lazyLoad" defaultValue="PageBuilderVideoBackgroundLazyLoad_Enabled"/>
@@ -31,6 +32,7 @@
3132
</assertEquals>
3233
<wait time="5" stepKey="waitToPreventVideoFlakiness"/>
3334
<waitForElementVisible selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
35+
<waitForElement selector="{{section.videoBackgroundVideoUrl(index, videoUrl.renderedValue)}}" stepKey="waitForVideoUrl"/>
3436
<grabAttributeFrom selector="{{section.videoBackgroundJarallaxContainer(index)}}" userInput="style" stepKey="jarallaxStyle"/>
3537
<assertStringContainsString stepKey="assertHeight">
3638
<expectedResult type="string">height: 100%;</expectedResult>
@@ -62,6 +64,7 @@
6264
<waitForElementVisible selector="{{section.videoBackgroundLazyLoad(index, lazyLoad.value)}}" stepKey="waitForLazyLoad"/>
6365
<waitForElementVisible selector="{{section.videoBackgroundPlayOnlyWhenVisible(index, playOnlyWhenVisible.value)}}" stepKey="waitForPlayOnlyWhenVisible"/>
6466
<waitForElement selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="waitForFallbackImage"/>
67+
<waitForElementNotVisible selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="waitForFallbackImageNotVisible"/>
6568
<grabAttributeFrom selector="{{section.videoBackgroundFallbackImageSource(index, fallbackImage.fileName)}}" userInput="src" stepKey="fallbackImageSource"/>
6669
<assertRegExp stepKey="assertFallbackImageValueContainsFileInformation">
6770
<expectedResult type="string">/.*\/(pub\/|\/)?media\/{{fallbackImage.path}}\/{{fallbackImage.fileName}}(_\d+)?\.{{fallbackImage.extension}}/</expectedResult>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup/ValidateVideoBackgroundWithOnlyVideoUrlActionGroup.xml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright 2020 Adobe
5-
* All rights reserved.
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
66
*/
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -13,6 +13,7 @@
1313
</annotations>
1414
<arguments>
1515
<argument name="section" defaultValue="RowOnStage"/>
16+
<argument name="videoUrl" defaultValue="PageBuilderVideoBackgroundUrl_Empty"/>
1617
<argument name="infiniteLoop" defaultValue="PageBuilderVideoBackgroundInfiniteLoop_Enabled"/>
1718
<argument name="lazyLoad" defaultValue="PageBuilderVideoBackgroundLazyLoad_Enabled"/>
1819
<argument name="playOnlyWhenVisible" defaultValue="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Enabled"/>
@@ -29,6 +30,7 @@
2930
<wait time="5" stepKey="waitToPreventVideoFlakiness"/>
3031
<scrollToTopOfPage stepKey="scrollToTopToAvoidFlakiness" />
3132
<waitForElement selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
33+
<waitForElement selector="{{section.videoBackgroundVideoUrl(index, videoUrl.renderedValue)}}" stepKey="waitForVideoUrl"/>
3234
<grabAttributeFrom selector="{{section.videoBackgroundJarallaxContainer(index)}}" userInput="style" stepKey="jarallaxStyle"/>
3335
<assertStringContainsString stepKey="assertHeight">
3436
<expectedResult type="string">height: 100%;</expectedResult>
@@ -48,14 +50,15 @@
4850
<actualResult type="variable">$videoStyle</actualResult>
4951
</assertStringContainsString>
5052
<assertStringContainsString stepKey="assertVideoPlaying">
51-
<expectedResult type="string">transform-style: preserve-3d</expectedResult>
53+
<expectedResult type="string">transform: translate3d(</expectedResult>
5254
<actualResult type="variable">$videoStyle</actualResult>
5355
</assertStringContainsString>
5456
<dontSeeElementInDOM selector="{{section.videoBackgroundOverlayElement(index)}}" stepKey="dontSeeOverlayColorInDOM"/>
5557
<waitForElementVisible selector="{{section.videoBackgroundInfiniteLoop(index, infiniteLoop.value)}}" stepKey="waitForInfiniteLoop"/>
5658
<waitForElementVisible selector="{{section.videoBackgroundLazyLoad(index, lazyLoad.value)}}" stepKey="waitForLazyLoad"/>
5759
<waitForElementVisible selector="{{section.videoBackgroundPlayOnlyWhenVisible(index, playOnlyWhenVisible.value)}}" stepKey="waitForPlayOnlyWhenVisible"/>
5860
<waitForElement selector="{{section.videoBackgroundNoFallbackImage(index)}}" stepKey="waitForNoFallbackImage"/>
61+
<dontSeeElement selector="{{section.videoBackgroundNoFallbackImage(index)}}" stepKey="dontSeeFallbackImage"/>
5962
<dontSeeElementInDOM selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="dontSeeFallbackImageInDOM"/>
6063
</actionGroup>
6164
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/EditFormActionGroup/SeeInFieldSlideOutPropertyActionGroup.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright 2020 Adobe
5-
* All rights reserved.
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
66
*/
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -13,5 +13,6 @@
1313
</arguments>
1414
<waitForElement time="2" selector="{{EditPanelForm.panelFieldControl(property.section, property.fieldName)}}" stepKey="waitForElementVisible"/>
1515
<see userInput="{{property.name}}" selector="{{EditPanelForm.panelFieldLabel(property.section, property.fieldName, property.section, property.name)}}" stepKey="seePropertyLabel"/>
16+
<seeInField selector="{{EditPanelForm.panelFieldControl(property.section, property.fieldName)}}" userInput="{{property.value}}" stepKey="seeInFieldProperty"/>
1617
</actionGroup>
1718
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowBackgroundAttributeTest/RowValidateVideoBackgroundLazyLoadDisabled.xml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright 2020 Adobe
5-
* All rights reserved.
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
66
*/
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -30,6 +30,10 @@
3030
<argument name="section" value="RowOnStage"/>
3131
<argument name="index" value="4"/>
3232
</actionGroup>
33+
<actionGroup ref="validateVideoBackgroundLoaded" stepKey="validateVideoNotPlayingStage1">
34+
<argument name="section" value="RowOnStage"/>
35+
<argument name="index" value="4"/>
36+
</actionGroup>
3337
<actionGroup ref="validateVideoBackgroundLoaded" stepKey="validateVideoPlayingStage2">
3438
<argument name="section" value="RowOnStage"/>
3539
<argument name="index" value="4"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowBackgroundAttributeTest/RowValidateVideoBackgroundLazyLoadEnabled.xml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright 2020 Adobe
5-
* All rights reserved.
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
66
*/
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -31,6 +31,10 @@
3131
<argument name="section" value="RowOnStage"/>
3232
<argument name="index" value="4"/>
3333
</actionGroup>
34+
<actionGroup ref="validateVideoBackgroundNotLoaded" stepKey="validateVideoNotPlayingStage1">
35+
<argument name="section" value="RowOnStage"/>
36+
<argument name="index" value="4"/>
37+
</actionGroup>
3438
<actionGroup ref="validateVideoBackgroundLoaded" stepKey="validateVideoPlayingStage2">
3539
<argument name="section" value="RowOnStage"/>
3640
<argument name="index" value="4"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowBackgroundAttributeTest/RowValidateVideoBackgroundPlayOnlyWhenVisibleEnabled.xml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright 2020 Adobe
5-
* All rights reserved.
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
66
*/
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -93,6 +93,12 @@
9393
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
9494
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
9595
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
96+
<!-- Stage: Validate Video is not Playing -->
97+
<actionGroup ref="validateVideoBackgroundLoadedButNotPlaying" stepKey="validateVideoNotPlayingStage1">
98+
<argument name="section" value="RowOnStage"/>
99+
<argument name="videoUrl" value="PageBuilderVideoBackgroundUrl_YouTube_NonEmbedded"/>
100+
<argument name="index" value="4"/>
101+
</actionGroup>
96102
<actionGroup ref="ScrollToActionGroup" stepKey="scrollRow4Stage">
97103
<argument name="cssSelector" value="{{RowOnStage.affordanceCSS}}"/>
98104
<argument name="index" value="4"/>

0 commit comments

Comments
 (0)