Skip to content

Commit a1d6e18

Browse files
committed
Merge branch 'MC-3864-fix-colour-alpha' into cms-team-1-delivery
# Conflicts: # app/code/Magento/PageBuilder/docs/master-format.md # app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/column.xml # app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/row.xml # app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/tab_item.xml
2 parents b7515c2 + c64a09f commit a1d6e18

File tree

9 files changed

+32
-154
lines changed

9 files changed

+32
-154
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/BackgroundFormData.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@
7474
<data key="section">background</data>
7575
<data key="fieldName">background_color</data>
7676
<data key="value">rgba(0, 0, 254, 0.92)</data>
77-
<data key="rgb">rgb(0, 0, 254)</data>
78-
<data key="hex">#0000fe</data>
79-
<data key="editPanelValue">#0000fe</data>
77+
<data key="rgb">rgba(0, 0, 254, 0.92)</data>
78+
<data key="hex">rgba(0, 0, 254, 0.92)</data>
79+
<data key="editPanelValue">rgba(0, 0, 254, 0.92)</data>
8080
</entity>
8181
<entity name="PageBuilderBackgroundColor_HSL_Orange" type="pagebuilder_background_color_property">
8282
<data key="name">Background Color</data>

app/code/Magento/PageBuilder/docs/master-format.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,8 @@ Contained:
8282
Attributes
8383
1. data-enable-parallax [1, 0]
8484
2. data-parallax-speed [0-1]
85-
3. data-background-color-format [hex, rgb, hsl, hsv, name, none]
86-
4. data-background-images `{"desktop_image":"{{media url}}","mobile_image":"{{media url}}"}`
87-
5. class
85+
3. data-background-images `{"desktop_image":"{{media url}}","mobile_image":"{{media url}}"}`
86+
4. class
8887

8988
Full Width:
9089
```
@@ -106,9 +105,8 @@ Attributes
106105
3. data-appearance [full-width, full-bleed]
107106
4. data-enable-parallax [1, 0]
108107
5. data-parallax-speed [0-1]
109-
6. data-background-color-format [hex, rgb, hsl, hsv, name, none]
110-
7. data-background-images `{"desktop_image":"{{media url}}","mobile_image":"{{media url}}"}`
111-
8. class
108+
6. data-background-images `{"desktop_image":"{{media url}}","mobile_image":"{{media url}}"}`
109+
7. class
112110

113111
Inline styles
114112
1. background-color

app/code/Magento/PageBuilder/view/adminhtml/web/js/mass-converter/preferred-color-format.js

Lines changed: 0 additions & 47 deletions
This file was deleted.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/mass-converter/preferred-color-format.ts

Lines changed: 0 additions & 35 deletions
This file was deleted.

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/banner.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
<element name="desktop_image">
5151
<style name="text_align" source="text_align"/>
5252
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
53-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
53+
<style name="background_color" source="background_color"/>
5454
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
5555
<style name="background_position" source="background_position"/>
5656
<style name="background_size" source="background_size"/>
@@ -61,7 +61,7 @@
6161
<element name="mobile_image">
6262
<style name="text_align" source="text_align"/>
6363
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
64-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
64+
<style name="background_color" source="background_color"/>
6565
<style name="mobile_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
6666
<style name="background_position" source="background_position"/>
6767
<style name="background_size" source="background_size"/>
@@ -125,7 +125,7 @@
125125
<element name="desktop_image">
126126
<style name="text_align" source="text_align"/>
127127
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
128-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
128+
<style name="background_color" source="background_color"/>
129129
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
130130
<style name="background_position" source="background_position"/>
131131
<style name="background_size" source="background_size"/>
@@ -136,7 +136,7 @@
136136
<element name="mobile_image">
137137
<style name="text_align" source="text_align"/>
138138
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
139-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
139+
<style name="background_color" source="background_color"/>
140140
<style name="mobile_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
141141
<style name="background_position" source="background_position"/>
142142
<style name="background_size" source="background_size"/>
@@ -200,7 +200,7 @@
200200
<element name="desktop_image">
201201
<style name="text_align" source="text_align"/>
202202
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
203-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
203+
<style name="background_color" source="background_color"/>
204204
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
205205
<style name="background_position" source="background_position"/>
206206
<style name="background_size" source="background_size"/>
@@ -211,7 +211,7 @@
211211
<element name="mobile_image">
212212
<style name="text_align" source="text_align"/>
213213
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
214-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
214+
<style name="background_color" source="background_color"/>
215215
<style name="mobile_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
216216
<style name="background_position" source="background_position"/>
217217
<style name="background_size" source="background_size"/>
@@ -277,7 +277,7 @@
277277
</element>
278278
<element name="desktop_image">
279279
<style name="text_align" source="text_align"/>
280-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
280+
<style name="background_color" source="background_color"/>
281281
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
282282
<style name="background_position" source="background_position"/>
283283
<style name="background_size" source="background_size"/>
@@ -286,7 +286,7 @@
286286
</element>
287287
<element name="mobile_image">
288288
<style name="text_align" source="text_align"/>
289-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
289+
<style name="background_color" source="background_color"/>
290290
<style name="mobile_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>
291291
<style name="background_position" source="background_position"/>
292292
<style name="background_size" source="background_size"/>

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/column.xml

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
reader="Magento_PageBuilder/js/master-format/read/configurable">
3535
<elements>
3636
<element name="main">
37-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
37+
<style name="background_color" source="background_color"/>
3838
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/container-background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image" persistence_mode="write"/>
3939
<style name="background_position" source="background_position"/>
4040
<style name="background_size" source="background_size"/>
@@ -67,11 +67,6 @@
6767
</element>
6868
</elements>
6969
<converters>
70-
<converter name="preferred_color_format" component="Magento_PageBuilder/js/mass-converter/preferred-color-format">
71-
<config>
72-
<item name="background_color_format" value="background_color_format"/>
73-
</config>
74-
</converter>
7570
<converter name="background_images" component="Magento_PageBuilder/js/mass-converter/background-images">
7671
<config>
7772
<item name="attribute_name" value="background_images"/>
@@ -87,7 +82,7 @@
8782
reader="Magento_PageBuilder/js/master-format/read/configurable">
8883
<elements>
8984
<element name="main">
90-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
85+
<style name="background_color" source="background_color"/>
9186
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/container-background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image" persistence_mode="write"/>
9287
<style name="background_position" source="background_position"/>
9388
<style name="background_size" source="background_size"/>
@@ -120,11 +115,6 @@
120115
</element>
121116
</elements>
122117
<converters>
123-
<converter name="preferred_color_format" component="Magento_PageBuilder/js/mass-converter/preferred-color-format">
124-
<config>
125-
<item name="background_color_format" value="background_color_format"/>
126-
</config>
127-
</converter>
128118
<converter name="background_images" component="Magento_PageBuilder/js/mass-converter/background-images">
129119
<config>
130120
<item name="attribute_name" value="background_images"/>
@@ -140,7 +130,7 @@
140130
reader="Magento_PageBuilder/js/master-format/read/configurable">
141131
<elements>
142132
<element name="main">
143-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
133+
<style name="background_color" source="background_color"/>
144134
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/container-background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image" persistence_mode="write"/>
145135
<style name="background_position" source="background_position"/>
146136
<style name="background_size" source="background_size"/>
@@ -173,11 +163,6 @@
173163
</element>
174164
</elements>
175165
<converters>
176-
<converter name="preferred_color_format" component="Magento_PageBuilder/js/mass-converter/preferred-color-format">
177-
<config>
178-
<item name="background_color_format" value="background_color_format"/>
179-
</config>
180-
</converter>
181166
<converter name="background_images" component="Magento_PageBuilder/js/mass-converter/background-images">
182167
<config>
183168
<item name="attribute_name" value="background_images"/>
@@ -193,7 +178,7 @@
193178
reader="Magento_PageBuilder/js/master-format/read/configurable">
194179
<elements>
195180
<element name="main">
196-
<style name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
181+
<style name="background_color" source="background_color"/>
197182
<style name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/container-background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image" persistence_mode="write"/>
198183
<style name="background_position" source="background_position"/>
199184
<style name="background_size" source="background_size"/>
@@ -226,11 +211,6 @@
226211
</element>
227212
</elements>
228213
<converters>
229-
<converter name="preferred_color_format" component="Magento_PageBuilder/js/mass-converter/preferred-color-format">
230-
<config>
231-
<item name="background_color_format" value="background_color_format"/>
232-
</config>
233-
</converter>
234214
<converter name="background_images" component="Magento_PageBuilder/js/mass-converter/background-images">
235215
<config>
236216
<item name="attribute_name" value="background_images"/>

0 commit comments

Comments
 (0)