Skip to content

Commit a0dd8a0

Browse files
committed
MC-3309: Build stabilization for MC-1416
- Fixed some tests
1 parent b625b61 commit a0dd8a0

File tree

4 files changed

+14
-11
lines changed

4 files changed

+14
-11
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TextData.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<data key="section">General</data>
2222
<data key="fieldName">text</data>
2323
<data key="cmsPageLinkName" unique="suffix">cms-page-link-</data>
24-
<data key="value">Text</data>
24+
<data key="value"></data>
2525
</entity>
2626
<entity name="PageBuilderTextContentTypeEmpty" type="pagebuilder_text_property">
2727
<data key="name">Text</data>
@@ -33,6 +33,7 @@
3333
<!-- Variables -->
3434
<entity name="TinyMCEVariableBaseURL" type="pagebuilder_text_variable_property">
3535
<data key="variableName">default:web/unsecure/base_url</data>
36+
<data key="variableNameEncoded">d2ViL3Vuc2VjdXJlL2Jhc2VfdXJs</data>
3637
<data key="editPanelValue">Base URL</data>
3738
<data key="stageValue">{{config path=&quot;web/unsecure/base_url&quot;}}</data>
3839
</entity>
@@ -50,6 +51,7 @@
5051
<data key="widgetType">Magento\Cms\Block\Widget\Page\Link</data>
5152
<data key="editPanelValue">CMS Page Link</data>
5253
<data key="stageValue">{{widget type=&quot;Magento\\Cms\\Block\\Widget\\Page\\Link&quot; template=&quot;widget/link/link_block.phtml&quot; page_id=</data>
54+
<data key="stageValueEncoded">e3t3aWRnZXQgdHlwZT0iTWFnZW50b1xDbXNcQmxvY2tcV2lkZ2V0XFBhZ2VcTGluayIgdGVtcGxhdGU9IndpZGdldC9saW5rL2xpbmtfYmxvY2sucGh0bWwiIHBhZ2VfaWQ9</data>
5355
</entity>
5456
<entity name="PageBuilderTextArea_WidgetCMSPageLink" type="pagebuilder_text_widget_property">
5557
<data key="widgetType">Magento\Cms\Block\Widget\Page\Link</data>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTextSection.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div" parameterized="true"/>
1212
<element name="textAreaText" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//div[.='{{arg2}}']" parameterized="true"/>
1313
<element name="textAreaTextContains" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div[contains(.,'{{arg2}}')]" parameterized="true"/>
14-
<element name="text" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div//span[contains(.,'{{arg2}}')]" parameterized="true"/>
14+
<element name="text" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div//*[contains(.,'{{arg2}}')]" parameterized="true"/>
15+
<element name="mcePlaceholder" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div//*[starts-with(@id, '{{arg2}}')]" parameterized="true"/>
1516
<element name="placeholder" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//div[contains(@class, 'placeholder-text') and text()='Edit Text']" parameterized="true"/>
1617
<element name="tinymce" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg}}]//div[contains(@class, 'inline-wysiwyg')]" parameterized="true"/>
1718
<element name="importantStyle" type="text" selector="//span[text()='Important']"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderCommonTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1522,7 +1522,7 @@
15221522
<!--Switch to iFrame 1-->
15231523
<comment userInput="Switch to iFrame" stepKey="commentSwitchToIFrame1"/>
15241524
<switchToIFrame selector="{{TextOnConfiguration.tinyMCEIFrame}}" stepKey="switchToIFrame1"/>
1525-
<waitForElementVisible selector="{{TextOnConfiguration.tinyMCEVariable(TinyMCEVariableBaseURL.editPanelValue, '1')}}" stepKey="waitForVariable2"/>
1525+
<waitForElementVisible selector="{{TextOnConfiguration.tinyMCEVariable(TinyMCEVariableCountry.editPanelValue, '1')}}" stepKey="waitForVariable2"/>
15261526
<switchToIFrame stepKey="exitIFrame1"/>
15271527
<!--Add widget to PageBuilder-->
15281528
<comment userInput="Add widget to PageBuilder" stepKey="addWidgetToPageBuilder"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -514,8 +514,8 @@
514514
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
515515
<!-- Validate Stage -->
516516
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
517-
<waitForElementVisible selector="{{TextOnStage.text('1', TinyMCEVariableBaseURL.stageValue)}}" stepKey="waitForVariableStage"/>
518-
<waitForElementVisible selector="{{TextOnStage.text('1', TinyMCEWidgetCMSPageLink.stageValue)}}" stepKey="waitForWidgetStage"/>
517+
<waitForElementVisible selector="{{TextOnStage.mcePlaceholder('1', TinyMCEVariableBaseURL.variableNameEncoded)}}" stepKey="waitForVariableStage"/>
518+
<waitForElementVisible selector="{{TextOnStage.mcePlaceholder('1', TinyMCEWidgetCMSPageLink.stageValueEncoded)}}" stepKey="waitForWidgetStage"/>
519519
<waitForElementVisible selector="{{TextOnStage.text('1', PageBuilderTextProperty.value)}}" stepKey="waitForTextStage"/>
520520
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
521521
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
@@ -524,7 +524,7 @@
524524
<!-- Validate Storefront -->
525525
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
526526
<waitForElementVisible selector="{{TextOnStorefront.text('1', _ENV.MAGENTO_BASE_URL)}}" stepKey="waitForVariableStorefront"/>
527-
<waitForElementVisible selector="div.block-cms-link a[href='{{_ENV.MAGENTO_BASE_URL}}text{{PageBuilderPageTitle.pageName}}']" stepKey="waitForWidgetStorefront"/>
527+
<waitForElementVisible selector="div.block-cms-link a[href='{{_ENV.MAGENTO_BASE_URL}}/text{{PageBuilderPageTitle.pageName}}']" stepKey="waitForWidgetStorefront"/>
528528
<waitForElementVisible selector="{{TextOnStorefront.text('1', PageBuilderTextProperty.value)}}" stepKey="waitForTextStorefront"/>
529529
</test>
530530
<test name="TextDelete">
@@ -941,7 +941,7 @@
941941
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
942942
<argument name="index" value="2"/>
943943
</actionGroup>
944-
<waitForElementVisible selector="{{TextOnStage.text('1', PageBuilderTextProperty.value)}}" stepKey="waitForTextStage"/>
944+
<waitForElementVisible selector="{{TextOnStage.text('2', PageBuilderTextProperty.value)}}" stepKey="waitForTextStage"/>
945945
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage2">
946946
<argument name="contentType" value="PageBuilderTextContentType"/>
947947
<argument name="contentTypeIndex" value="2"/>
@@ -993,7 +993,7 @@
993993
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
994994
<argument name="index" value="2"/>
995995
</actionGroup>
996-
<waitForElementVisible selector="{{TextOnStage.text('1', PageBuilderTextProperty.value)}}" stepKey="waitForTextStage2"/>
996+
<waitForElementVisible selector="{{TextOnStage.text('2', PageBuilderTextProperty.value)}}" stepKey="waitForTextStage2"/>
997997
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage3">
998998
<argument name="contentType" value="PageBuilderTextContentType"/>
999999
<argument name="contentTypeIndex" value="2"/>
@@ -1045,7 +1045,7 @@
10451045
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
10461046
<argument name="index" value="2"/>
10471047
</actionGroup>
1048-
<waitForElementVisible selector="{{TextOnStorefront.text('1', PageBuilderTextProperty.value)}}" stepKey="waitForTextStorefront"/>
1048+
<waitForElementVisible selector="{{TextOnStorefront.text('2', PageBuilderTextProperty.value)}}" stepKey="waitForTextStorefront"/>
10491049
</test>
10501050
<test name="TextValidateGeneralDefaultSettings">
10511051
<annotations>
@@ -1085,12 +1085,12 @@
10851085
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
10861086
<!-- Validate Stage -->
10871087
<comment userInput="Validate Stage" stepKey="commentValidateStage1"/>
1088-
<waitForElementVisible selector="{{TextOnStage.textAreaText('1', PageBuilderTextContentTypeDefault.value)}}" stepKey="waitForTextStage"/>
1088+
<waitForElementVisible selector="{{TextOnStage.text('1', PageBuilderTextContentTypeDefault.value)}}" stepKey="waitForTextStage"/>
10891089
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
10901090
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
10911091
<!-- Validate Stage After Save -->
10921092
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
1093-
<waitForElementVisible selector="{{TextOnStage.textAreaText('1', PageBuilderTextContentTypeDefault.value)}}" stepKey="waitForTextStage2"/>
1093+
<waitForElementVisible selector="{{TextOnStage.text('1', PageBuilderTextContentTypeDefault.value)}}" stepKey="waitForTextStage2"/>
10941094
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
10951095
<argument name="contentType" value="PageBuilderTextContentType"/>
10961096
</actionGroup>

0 commit comments

Comments
 (0)