Skip to content

Commit a0c9d5f

Browse files
committed
#559: User sees no predefined gutters - Banner tests fixes
1 parent 33b93eb commit a0c9d5f

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OverlayActionGroup/ValidateOverlayAndButtonCollageActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<argument name="element"/>
1717
<argument name="elementIndex" defaultValue="1" type="string"/>
1818
<argument name="elementBorderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0"/>
19-
<argument name="elementPadding" defaultValue="PageBuilderAdvancedMarginsAndPaddingPropertyDefaultSlide"/>
19+
<argument name="elementPadding" defaultValue="PageBuilderPaddingPropertyDefault"/>
2020
<argument name="overlayPadding" defaultValue="PageBuilderPaddingPropertyOverlayDefault"/>
2121
<argument name="diffThreshold" defaultValue="0" type="string"/>
2222
</arguments>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OverlayActionGroup/ValidateOverlayAndButtonPosterActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<argument name="elementIndex" defaultValue="1" type="string"/>
1818
<argument name="elementBorderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0"/>
1919
<argument name="elementPadding" defaultValue="PageBuilderPaddingPropertyDefault"/>
20-
<argument name="overlayPadding" defaultValue="PageBuilderAdvancedMarginsAndPaddingPropertyDefaultSlide"/>
20+
<argument name="overlayPadding" defaultValue="PageBuilderPaddingPropertyOverlayDefault"/>
2121
<argument name="diffThreshold" defaultValue="0" type="string"/>
2222
</arguments>
2323
<!-- Validate Element Width -->

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OverlayActionGroup/ValidateOverlayPositionCollageRightActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<arguments>
1212
<argument name="page"/>
1313
<argument name="index" defaultValue="1" type="string"/>
14-
<argument name="padding" defaultValue="PageBuilderPaddingProperty40"/>
14+
<argument name="padding" defaultValue="PageBuilderPaddingPropertyDefault"/>
1515
<argument name="expectedOverlayWidth" defaultValue="540" type="string"/>
1616
<argument name="acceptableOffset" defaultValue="2" type="string"/>
1717
</arguments>

app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBannerCollageCenteredAppearanceThroughBlockContentTypeTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
<!-- Validate CMS Block Stage Mobile Viewport -->
2929
<seeElement selector="{{BannerOnBackend.appearance('1', PageBuilderAppearance_CollageCentered.value)}}" stepKey="seeAppearanceCMSBlockStage"/>
30-
<executeJS function="return Math.abs({{BannerOnBackend.wrapperJS('1')}}.getBoundingClientRect().width - {{PageBuilderPaddingProperty40.paddingLeft}} - {{PageBuilderPaddingProperty40.paddingRight}})" stepKey="widthOfWrapperMinusPaddingCMSBlockStage" before="validateOverlayPositionCMSBlockStage"/>
30+
<executeJS function="return Math.abs({{BannerOnBackend.wrapperJS('1')}}.getBoundingClientRect().width)" stepKey="widthOfWrapperMinusPaddingCMSBlockStage" before="validateOverlayPositionCMSBlockStage"/>
3131
<actionGroup ref="validateOverlayPositionCollageCenter" stepKey="validateOverlayPositionCMSBlockStage">
3232
<argument name="page" value="BannerOnBackend"/>
3333
<argument name="expectedOverlayWidth" value="{$widthOfWrapperMinusPaddingCMSBlockStage}"/>
@@ -56,7 +56,7 @@
5656

5757
<!-- Validate CMS Page Stage Mobile Viewport -->
5858
<seeElement selector="{{BannerOnFrontend.appearance('1', PageBuilderAppearance_CollageCentered.value)}}" stepKey="seeAppearanceCMSPageStage"/>
59-
<executeJS function="return Math.abs({{BannerOnFrontend.wrapperJS('1')}}.getBoundingClientRect().width - {{PageBuilderPaddingProperty40.paddingLeft}} - {{PageBuilderPaddingProperty40.paddingRight}})" stepKey="widthOfWrapperMinusPaddingCMSPageStage" before="validateOverlayPositionCMSPageStage"/>
59+
<executeJS function="return Math.abs({{BannerOnFrontend.wrapperJS('1')}}.getBoundingClientRect().width)" stepKey="widthOfWrapperMinusPaddingCMSPageStage" before="validateOverlayPositionCMSPageStage"/>
6060
<actionGroup ref="validateOverlayPositionCollageCenter" stepKey="validateOverlayPositionCMSPageStage">
6161
<argument name="page" value="BannerOnFrontend"/>
6262
<argument name="expectedOverlayWidth" value="{$widthOfWrapperMinusPaddingCMSPageStage}"/>
@@ -94,7 +94,7 @@
9494
<executeJS function="return Math.abs(Math.round({$buttonLeftPositionCMSPageStorefront}-{$overlayLeftPositionCMSPageStorefront}-30))" stepKey="buttonMinusOverlayMinusPaddingCMSPageStorefront"/>
9595

9696
<!-- Validate CMS Page Storefront Mobile -->
97-
<executeJS function="return Math.abs({{BannerOnFrontend.wrapperJS('1')}}.getBoundingClientRect().width - {{PageBuilderPaddingProperty40.paddingLeft}} - {{PageBuilderPaddingProperty40.paddingRight}})" stepKey="widthOfWrapperMinusPaddingCMSPageStorefrontMobile" before="validateOverlayPositionCMSPageStorefrontMobile"/>
97+
<executeJS function="return Math.abs({{BannerOnFrontend.wrapperJS('1')}}.getBoundingClientRect().width)" stepKey="widthOfWrapperMinusPaddingCMSPageStorefrontMobile" before="validateOverlayPositionCMSPageStorefrontMobile"/>
9898
<actionGroup ref="validateOverlayPositionCollageCenter" stepKey="validateOverlayPositionCMSPageStorefrontMobile">
9999
<argument name="page" value="BannerOnFrontend"/>
100100
<argument name="expectedOverlayWidth" value="{$widthOfWrapperMinusPaddingCMSPageStorefrontMobile}"/>

0 commit comments

Comments
 (0)