Skip to content

Commit a06b03e

Browse files
dhaeckerdhaecker
committed
MC-3475: Create MFTF Tests
- Skipping failing tests in mainline - Fixing faulty modal selectors - Fixing incorrect schema locations
1 parent dd46d83 commit a06b03e

File tree

4 files changed

+42
-6
lines changed

4 files changed

+42
-6
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStageSection.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
<element name="stageWrapper" type="button" selector="//div[@class='pagebuilder-stage-wrapper']"/>
1717
<element name="stageWrapperFullScreen" type="button" selector="div.pagebuilder-stage-wrapper.stage-full-screen"/>
1818
<element name="stageWidthJS" type="button" selector="document.querySelector('div[class~=\'stage-container\']').clientWidth"/>
19-
<element name="modal" type="text" selector='aside.modal-popup.prompt._show'/>
20-
<element name="modalOk" type="button" selector="aside.modal-popup.prompt._show button.action-primary.action-accept"/>
21-
<element name="modalCancel" type="button" selector="aside.modal-popup.prompt._show button.action-secondary.action-dismiss"/>
22-
<element name="modalX" type="button" selector="aside.modal-popup.prompt._show button.action-close"/>
19+
<element name="modal" type="text" selector='aside.modal-popup._show'/>
20+
<element name="modalOk" type="button" selector="aside.modal-popup._show button.action-primary.action-accept"/>
21+
<element name="modalCancel" type="button" selector="aside.modal-popup._show button.action-secondary.action-dismiss"/>
22+
<element name="modalX" type="button" selector="aside.modal-popup._show button.action-close"/>
2323
<!-- It's safer to click the label, as Selenium will complain if it's not clicking the exact element -->
24-
<element name="modalDoNotShowThisAgain" type="input" selector="aside.modal-popup.prompt._show input[name='modal-dnsa'] + label"/>
24+
<element name="modalDoNotShowThisAgain" type="input" selector="aside.modal-popup._show input[name='modal-dnsa'] + label"/>
2525
<element name="errorModal" type="button" selector="//div[@class='modal-content']//div[contains(text(), '{{arg1}}')]" parameterized="true"/>
2626
<element name="dropAreaInStage" type="button" selector='(//div[contains(@class, "type-container") and contains(@class, "pagebuilder-row")])[1]//div[contains(@class,"pagebuilder-empty-container")][1]'/>
2727
<element name="dropZone" type="button" selector='(//div[contains(@class, "{{arg1}}-container")])[{{arg2}}]//div[contains(@class,"pagebuilder-drop-indicator")][{{arg3}}]' parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,6 +1098,9 @@
10981098
<testCaseId value="MAGETWO-89355"/>
10991099
<group value="pagebuilder"/>
11001100
<group value="pagebuilder-advancedConfig"/>
1101+
<skip>
1102+
<issueId value="MC-3720"/>
1103+
</skip>
11011104
</annotations>
11021105
<before>
11031106
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -1405,6 +1408,9 @@
14051408
<testCaseId value="MAGETWO-89356"/>
14061409
<group value="pagebuilder"/>
14071410
<group value="pagebuilder-advancedConfig"/>
1411+
<skip>
1412+
<issueId value="MC-3720"/>
1413+
</skip>
14081414
</annotations>
14091415
<before>
14101416
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -1812,6 +1818,9 @@
18121818
<testCaseId value="MAGETWO-89358"/>
18131819
<group value="pagebuilder"/>
18141820
<group value="pagebuilder-advancedConfig"/>
1821+
<skip>
1822+
<issueId value="MC-3720"/>
1823+
</skip>
18151824
</annotations>
18161825
<before>
18171826
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -2133,6 +2142,9 @@
21332142
<testCaseId value="MAGETWO-89359"/>
21342143
<group value="pagebuilder"/>
21352144
<group value="pagebuilder-advancedConfig"/>
2145+
<skip>
2146+
<issueId value="MC-3720"/>
2147+
</skip>
21362148
</annotations>
21372149
<before>
21382150
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderCommonTest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1324,6 +1324,9 @@
13241324
<group value="pagebuilder"/>
13251325
<group value="pagebuilder-common"/>
13261326
<group value="pagebuilder-urlInput"/>
1327+
<skip>
1328+
<issueId value="MC-3720"/>
1329+
</skip>
13271330
</annotations>
13281331
<before>
13291332
<magentoCLI command="config:set general/store_information/country_id US" stepKey="setValueForCountryVariable"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
-->
88

99
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10-
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd">
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1111
<test name="TextAddWYSIWYGContentTypeToTabOnStage">
1212
<annotations>
1313
<features value="PageBuilder"/>
@@ -20,6 +20,9 @@
2020
<group value="pagebuilder"/>
2121
<group value="pagebuilder-text"/>
2222
<group value="pagebuilder-tabs-content"/>
23+
<skip>
24+
<issueId value="MC-3720"/>
25+
</skip>
2326
</annotations>
2427
<before>
2528
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -144,6 +147,9 @@
144147
<testCaseId value="MC-3464"/>
145148
<group value="pagebuilder"/>
146149
<group value="pagebuilder-text"/>
150+
<skip>
151+
<issueId value="MC-3720"/>
152+
</skip>
147153
</annotations>
148154
<before>
149155
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />
@@ -238,6 +244,9 @@
238244
<testCaseId value="MC-3466"/>
239245
<group value="pagebuilder"/>
240246
<group value="pagebuilder-text"/>
247+
<skip>
248+
<issueId value="MC-3720"/>
249+
</skip>
241250
</annotations>
242251
<before>
243252
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />
@@ -313,6 +322,9 @@
313322
<testCaseId value="MC-3467"/>
314323
<group value="pagebuilder"/>
315324
<group value="pagebuilder-text"/>
325+
<skip>
326+
<issueId value="MC-3720"/>
327+
</skip>
316328
</annotations>
317329
<before>
318330
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />
@@ -378,6 +390,9 @@
378390
<testCaseId value="MC-3468"/>
379391
<group value="pagebuilder"/>
380392
<group value="pagebuilder-text"/>
393+
<skip>
394+
<issueId value="MC-3720"/>
395+
</skip>
381396
</annotations>
382397
<before>
383398
<createData entity="_defaultCmsPage" stepKey="createCMSPageA" />
@@ -1358,6 +1373,9 @@
13581373
<group value="pagebuilder"/>
13591374
<group value="pagebuilder-text"/>
13601375
<group value="pagebuilder-customBeforeAfter"/>
1376+
<skip>
1377+
<issueId value="MC-3720"/>
1378+
</skip>
13611379
</annotations>
13621380
<before>
13631381
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -1605,6 +1623,9 @@
16051623
<group value="pagebuilder"/>
16061624
<group value="pagebuilder-text"/>
16071625
<group value="pagebuilder-column-content"/>
1626+
<skip>
1627+
<issueId value="MC-3720"/>
1628+
</skip>
16081629
</annotations>
16091630
<before>
16101631
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />

0 commit comments

Comments
 (0)