Skip to content

Commit 9f8fee2

Browse files
committed
MC-10833: Resolve TypeScript errors
- Merge in beta-release
1 parent 304701e commit 9f8fee2

File tree

10 files changed

+12
-21
lines changed

10 files changed

+12
-21
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/banner/preview.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import events from "Magento_PageBuilder/js/events";
99
import Config from "../../config";
1010
import HideShowOption from "../../content-type-menu/hide-show-option";
1111
import {OptionsInterface} from "../../content-type-menu/option.types";
12-
import {DataObject} from "../../data-store";
1312
import Uploader from "../../uploader";
1413
import WysiwygFactory from "../../wysiwyg/factory";
1514
import WysiwygInterface from "../../wysiwyg/wysiwyg-interface";
@@ -19,6 +18,7 @@ import BasePreview from "../preview";
1918
* @api
2019
*/
2120
export default class Preview extends BasePreview {
21+
public buttonPlaceholder: string = $t("Edit Button Text");
2222

2323
/**
2424
* Wysiwyg instance
@@ -35,8 +35,6 @@ export default class Preview extends BasePreview {
3535
*/
3636
private textarea: HTMLTextAreaElement;
3737

38-
private buttonPlaceholder: string = $t("Edit Button Text");
39-
4038
/**
4139
* Return an array of options
4240
*

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/button-item/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import BasePreview from "../preview";
1515
* @api
1616
*/
1717
export default class Preview extends BasePreview {
18-
private buttonPlaceholder: string = $t("Edit Button Text");
18+
public buttonPlaceholder: string = $t("Edit Button Text");
1919

2020
/**
2121
* Use the conditional remove to disable the option when the parent has a single child

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/image/preview.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import events from "Magento_PageBuilder/js/events";
77
import HideShowOption from "../../content-type-menu/hide-show-option";
88
import {OptionsInterface} from "../../content-type-menu/option.types";
9-
import {DataObject} from "../../data-store";
109
import Uploader from "../../uploader";
1110
import BasePreview from "../preview";
1211

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/products/preview.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import ContentTypeInterface from "../../content-type";
1111
import ContentTypeConfigInterface from "../../content-type-config.types";
1212
import HideShowOption from "../../content-type-menu/hide-show-option";
1313
import {OptionsInterface} from "../../content-type-menu/option.types";
14-
import {DataObject} from "../../data-store";
1514
import ObservableUpdater from "../observable-updater";
1615
import BasePreview from "../preview";
1716

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {PreviewSortableSortUpdateEventParams} from "../../binding/sortable-child
1111
import Config from "../../config";
1212
import ConditionalRemoveOption from "../../content-type-menu/conditional-remove-option";
1313
import {OptionsInterface} from "../../content-type-menu/option.types";
14-
import {DataObject} from "../../data-store";
1514
import Uploader from "../../uploader";
1615
import delayUntil from "../../utils/delay-until";
1716
import WysiwygFactory from "../../wysiwyg/factory";
@@ -24,7 +23,7 @@ import SliderPreview from "../slider/preview";
2423
* @api
2524
*/
2625
export default class Preview extends BasePreview {
27-
private buttonPlaceholder: string = $t("Edit Button Text");
26+
public buttonPlaceholder: string = $t("Edit Button Text");
2827
/**
2928
* Wysiwyg instance
3029
*/

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/tabs/preview.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import HideShowOption from "../../content-type-menu/hide-show-option";
1919
import Option from "../../content-type-menu/option";
2020
import {OptionsInterface} from "../../content-type-menu/option.types";
2121
import ContentTypeInterface from "../../content-type.types";
22-
import {DataObject} from "../../data-store";
2322
import delayUntil from "../../utils/delay-until";
2423
import deferred, {DeferredInterface} from "../../utils/promise-deferred";
2524
import {

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/src.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
import Config from "../../config";
7-
import {DataObject} from "../../data-store";
87
import {decodeUrl} from "../../utils/image";
98
import {get} from "../../utils/object";
109
import {convertUrlToPathIfOtherUrlIsOnlyAPath} from "../../utils/url";

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/drag-drop/sortable.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import ContentTypeInterface from "../content-type";
1010
import ContentTypeCollectionInterface from "../content-type-collection.types";
1111
import createContentType from "../content-type-factory";
1212
import Preview from "../content-type/preview";
13-
import Stage from "../stage";
1413
import {hideDropIndicators, showDropIndicators} from "./drop-indicators";
1514
import {getAllowedContainersClasses} from "./matrix";
1615
import {moveContentType} from "./move-content-type";

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/panel/group.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66
import ko from "knockout";
77

88
export class Group {
9-
private hidden: KnockoutObservable<boolean> = ko.observable(false);
10-
private id: KnockoutObservable<number> = ko.observable();
11-
private code: KnockoutObservable<string> = ko.observable("");
12-
private label: KnockoutObservable<string> = ko.observable("");
13-
private icon: KnockoutObservable<string> = ko.observable("");
14-
private sort: KnockoutObservable<number> = ko.observable();
15-
private contentTypes: KnockoutObservableArray<[any]> = ko.observableArray([]);
16-
private active: KnockoutObservable<boolean> = ko.observable(false);
17-
private stageId: string;
9+
public hidden: KnockoutObservable<boolean> = ko.observable(false);
10+
public id: KnockoutObservable<number> = ko.observable();
11+
public code: KnockoutObservable<string> = ko.observable("");
12+
public label: KnockoutObservable<string> = ko.observable("");
13+
public icon: KnockoutObservable<string> = ko.observable("");
14+
public sort: KnockoutObservable<number> = ko.observable();
15+
public contentTypes: KnockoutObservableArray<[any]> = ko.observableArray([]);
16+
public active: KnockoutObservable<boolean> = ko.observable(false);
17+
public stageId: string;
1818

1919
/**
2020
* Group constructor

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/wysiwyg/factory.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import $ from "jquery";
77
import {AdditionalDataConfigInterface} from "../content-type-config.types";
88
import DataStore from "../data-store";
99
import loadModule from "../utils/loader";
10-
import Wysiwyg from "./tinymce4";
1110
import WysiwygInterface, {WysiwygConstructorInterface} from "./wysiwyg-interface";
1211

1312
/**

0 commit comments

Comments
 (0)