Skip to content

Commit 9b6ca7c

Browse files
Merge remote-tracking branch 'owls/MC-3429-remove-anchor' into cms-team-2-sprint-14
2 parents a94f38b + 723217d commit 9b6ca7c

File tree

21 files changed

+10
-1274
lines changed

21 files changed

+10
-1274
lines changed

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/Anchor.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ public function render(array $itemData, array $additionalData = []) : string
4545
$eavData = $this->eavAttributeLoader->load($itemData['entityId']);
4646

4747
$rootElementAttributes = [
48-
'data-element' => 'main',
49-
'data-role' => 'anchor',
50-
'data-appearance' => 'default',
5148
'class' => $eavData['css_classes'] ?? '',
5249
'id' => $eavData['anchor_id']
5350
];
@@ -59,11 +56,14 @@ public function render(array $itemData, array $additionalData = []) : string
5956
}
6057
}
6158

62-
$rootElementHtml = '<div';
59+
$anchorHtml = '<div';
6360
foreach ($rootElementAttributes as $attributeName => $attributeValue) {
64-
$rootElementHtml .= $attributeValue ? " $attributeName=\"$attributeValue\"" : '';
61+
$anchorHtml .= $attributeValue ? " $attributeName=\"$attributeValue\"" : '';
6562
}
66-
$rootElementHtml .= '></div>';
63+
$anchorHtml .= '></div>';
64+
65+
$rootElementHtml = '<div data-element="main" data-role="html" data-appearance="default">';
66+
$rootElementHtml .= $anchorHtml . '</div>';
6767

6868
return $rootElementHtml;
6969
}

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeAnchorActionGroup.xml

Lines changed: 0 additions & 28 deletions
This file was deleted.

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/PanelActionGroup.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,13 @@
2929
<see userInput="Column" selector="{{PageBuilderPanel.layoutGroupContentType}}" stepKey="seeLayoutGroupColumn"/>
3030
<see userInput="Tabs" selector="{{PageBuilderPanel.layoutGroupContentType}}" stepKey="seeLayoutGroupTabs"/>
3131
<click selector="{{PageBuilderPanel.elementsGroup}}" stepKey="clickElementsGroup"/>
32-
<seeNumberOfElements selector="{{PageBuilderPanel.allGroupContentTypes('elements')}}" userInput="7" stepKey="seeNumberOfElementsGroupContentTypes"/>
32+
<seeNumberOfElements selector="{{PageBuilderPanel.allGroupContentTypes('elements')}}" userInput="6" stepKey="seeNumberOfElementsGroupContentTypes"/>
3333
<see userInput="Elements" selector="{{PageBuilderPanel.elementsGroup}}" stepKey="seeElementsGroup"/>
3434
<see userInput="Text" selector="{{PageBuilderPanel.elementsGroupContentType}}" stepKey="seeElementsGroupText"/>
3535
<see userInput="Heading" selector="{{PageBuilderPanel.elementsGroupContentType}}" stepKey="seeElementsGroupHeading"/>
3636
<see userInput="Buttons" selector="{{PageBuilderPanel.elementsGroupContentType}}" stepKey="seeElementsGroupButtons"/>
3737
<see userInput="Divider" selector="{{PageBuilderPanel.elementsGroupContentType}}" stepKey="seeElementsGroupDivider"/>
3838
<see userInput="Newsletter" selector="{{PageBuilderPanel.elementsGroupContentType}}" stepKey="seeElementsGroupNewsletter"/>
39-
<see userInput="Anchor" selector="{{PageBuilderPanel.elementsGroupContentType}}" stepKey="seeElementsGroupAnchor"/>
4039
<see userInput="HTML Code" selector="{{PageBuilderPanel.elementsGroupContentType}}" stepKey="seeElementsGroupHtml"/>
4140
<click selector="{{PageBuilderPanel.mediaGroup}}" stepKey="clickMediaGroup"/>
4241
<seeNumberOfElements selector="{{PageBuilderPanel.allGroupContentTypes('media')}}" userInput="5" stepKey="seeNumberOfMediaGroupContentTypes"/>

app/code/Magento/PageBuilder/Test/Mftf/Data/AnchorData.xml

Lines changed: 0 additions & 33 deletions
This file was deleted.

app/code/Magento/PageBuilder/Test/Mftf/Data/BannerData.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,6 @@
8181
<data key="fieldName">link_url[default]</data>
8282
<data key="value">http://url.magento/</data>
8383
</entity>
84-
<entity name="PageBuilderBannerLink_Anchor" type="pagebuilder_banner_linkUrl_property">
85-
<data key="name">Link</data>
86-
<data key="section">contents</data>
87-
<data key="fieldName">link_url</data>
88-
<data key="value">#my-anchor-id</data>
89-
</entity>
9084
<entity name="PageBuilderBannerNewTabDefaultProperty" type="pagebuilder_banner_newTab_property">
9185
<data key="name">Open in new tab</data>
9286
<data key="section">contents</data>

app/code/Magento/PageBuilder/Test/Mftf/Data/ContentTypeData.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,6 @@
7777
<data key="role">newsletter</data>
7878
<data key="pageNamePrefix">newsletter</data>
7979
</entity>
80-
<entity name="PageBuilderAnchorContentType" type="pagebuilder_content_type">
81-
<data key="name">Anchor</data>
82-
<data key="section">Elements</data>
83-
<data key="role">anchor</data>
84-
<data key="pageNamePrefix">anchor</data>
85-
</entity>
8680
<entity name="PageBuilderHtmlContentType" type="pagebuilder_content_type">
8781
<data key="name">HTML Code</data>
8882
<data key="section">Elements</data>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderAnchorSection.xml

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)