Skip to content

Commit 98ffb69

Browse files
author
hannahnida
committed
#558: Developer can style content types output differently per viewport - Action Groups changes
1 parent 1a981c5 commit 98ffb69

File tree

40 files changed

+179
-347
lines changed

40 files changed

+179
-347
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedConfigurationAllOptionsActionGroup.xml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,29 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="ValidateAdvancedConfigurationAllOptionsActionGroup">
1111
<annotations>
12-
<description value="You should be to make static checks of values."/>
12+
<description value="Validates styles from Advanced configuration in content type settings"/>
1313
</annotations>
1414
<arguments>
1515
<argument name="page" defaultValue=""/>
16-
<argument name="alignment" defaultValue="PageBuilderAdvancedAlignmentPropertyDefault.value"/>
17-
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone.value"/>
16+
<argument name="alignment" defaultValue="PageBuilderAdvancedAlignmentPropertyDefault"/>
17+
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
1818
<argument name="borderColor" defaultValue=""/>
19-
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthPropertyDefault.value"/>
20-
<argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty.value"/>
19+
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthPropertyDefault"/>
20+
<argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
2121
<argument name="cssClasses" defaultValue=""/>
22-
<argument name="margin" defaultValue="PageBuilderMarginsPropertyDefault.value"/>
23-
<argument name="padding" defaultValue="PageBuilderPaddingPropertyDefault.value"/>
22+
<argument name="margin" defaultValue="PageBuilderMarginsPropertyDefault"/>
23+
<argument name="padding" defaultValue="PageBuilderPaddingPropertyDefault"/>
2424
<argument name="index" defaultValue="1" type="string"/>
2525
</arguments>
2626
<waitForElementVisible selector="{{page.base(index)}}" stepKey="waitForElementVisible"/>
2727
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).textAlign" stepKey="grabAlignmentValue"/>
2828
<assertEquals stepKey="assertAlignment">
29-
<expectedResult type="string">{{alignment}}</expectedResult>
29+
<expectedResult type="string">{{alignment.value}}</expectedResult>
3030
<actualResult type="variable">grabAlignmentValue</actualResult>
3131
</assertEquals>
3232
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderStyle" stepKey="grabBorderStyleValue"/>
3333
<assertEquals stepKey="assertBorderStyle">
34-
<expectedResult type="string">{{border}}</expectedResult>
34+
<expectedResult type="string">{{border.value}}</expectedResult>
3535
<actualResult type="variable">grabBorderStyleValue</actualResult>
3636
</assertEquals>
3737
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderColor" stepKey="grabBorderColorValue"/>
@@ -41,23 +41,23 @@
4141
</assertEquals>
4242
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderWidth.replace(&quot;px&quot;, &quot;&quot;)" stepKey="grabBorderWidthValue"/>
4343
<assertEquals stepKey="assertBorderWidth">
44-
<expectedResult type="string">{{borderWidth}}</expectedResult>
44+
<expectedResult type="string">{{borderWidth.value}}</expectedResult>
4545
<actualResult type="variable">grabBorderWidthValue</actualResult>
4646
</assertEquals>
4747
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderRadius.replace(/px/g, &quot;&quot;)" stepKey="grabBorderRadiusValue"/>
4848
<assertEquals stepKey="assertBorderRadius">
49-
<expectedResult type="string">{{borderRadius}}</expectedResult>
49+
<expectedResult type="string">{{borderRadius.value}}</expectedResult>
5050
<actualResult type="variable">grabBorderRadiusValue</actualResult>
5151
</assertEquals>
5252
<waitForElementVisible selector="{{page.cssClasses(index, cssClasses.value)}}" stepKey="waitForCSSClassesVisible"/>
5353
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).margin.replace(/px/g, &quot;&quot;)" stepKey="grabMarginValue"/>
5454
<assertEquals stepKey="assertMargin">
55-
<expectedResult type="string">{{margin}}</expectedResult>
55+
<expectedResult type="string">{{margin.value}}</expectedResult>
5656
<actualResult type="variable">grabMarginValue</actualResult>
5757
</assertEquals>
5858
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).padding.replace(/px/g, &quot;&quot;)" stepKey="grabPaddingValue"/>
5959
<assertEquals stepKey="assertPadding">
60-
<expectedResult type="string">{{padding}}</expectedResult>
60+
<expectedResult type="string">{{padding.value}}</expectedResult>
6161
<actualResult type="variable">grabPaddingValue</actualResult>
6262
</assertEquals>
6363
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedConfigurationWithAlignmentActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="ValidateAdvancedConfigurationWithAlignmentActionGroup" extends="ValidateAdvancedConfigurationAllOptionsActionGroup">
1111
<annotations>
12-
<description value="Validate alignment property."/>
12+
<description value="Validates styles from Advanced configuration in without border and css classes"/>
1313
</annotations>
1414
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).color" stepKey="grabColorValue" after="grabBorderColorValue"/>
1515
<remove keyForRemoval="assertBorderColor"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedConfigurationWithAllUpdatedNotVisibleActionGroup.xml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="ValidateAdvancedConfigurationWithAllUpdatedNotVisibleActionGroup">
1111
<annotations>
12-
<description value="Validate updated values with default values."/>
12+
<description value="Validates Advanced configuration was not set"/>
1313
</annotations>
1414
<arguments>
1515
<argument name="page" defaultValue=""/>
16-
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone.value"/>
17-
<argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty.value"/>
18-
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0.value"/>
19-
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyStart.value"/>
16+
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
17+
<argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
18+
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0"/>
19+
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyStart"/>
2020
<argument name="defaultMargin" defaultValue="0" type="string"/>
2121
<argument name="defaultPadding" defaultValue="0" type="string"/>
2222
<argument name="cssClasses" defaultValue=""/>
@@ -26,12 +26,12 @@
2626
<dontSeeElement selector="{{page.base(index)}}" stepKey="dontSeeElement"/>
2727
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).textAlign" stepKey="grabAlignmentValue"/>
2828
<assertEquals stepKey="assertDefaultAlignmentVisible">
29-
<expectedResult type="string">{{defaultAlignment}}</expectedResult>
29+
<expectedResult type="string">{{defaultAlignment.value}}</expectedResult>
3030
<actualResult type="variable">grabAlignmentValue</actualResult>
3131
</assertEquals>
3232
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderStyle" stepKey="grabBorderStyleValue"/>
3333
<assertEquals stepKey="assertNoBorderStyle">
34-
<expectedResult type="string">{{border}}</expectedResult>
34+
<expectedResult type="string">{{border.value}}</expectedResult>
3535
<actualResult type="variable">grabBorderStyleValue</actualResult>
3636
</assertEquals>
3737
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderColor" stepKey="grabBorderColorValue"/>
@@ -42,12 +42,12 @@
4242
</assertEquals>
4343
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderWidth.replace(&quot;px&quot;, &quot;&quot;)" stepKey="grabBorderWidthValue"/>
4444
<assertEquals stepKey="assertNoBorderWidth">
45-
<expectedResult type="string">{{borderWidth}}</expectedResult>
45+
<expectedResult type="string">{{borderWidth.value}}</expectedResult>
4646
<actualResult type="variable">grabBorderWidthValue</actualResult>
4747
</assertEquals>
4848
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).borderRadius.replace(&quot;px&quot;, &quot;&quot;)" stepKey="grabBorderRadiusValue"/>
4949
<assertEquals stepKey="assertNoBorderRadius">
50-
<expectedResult type="string">{{borderRadius}}</expectedResult>
50+
<expectedResult type="string">{{borderRadius.value}}</expectedResult>
5151
<actualResult type="variable">grabBorderRadiusValue</actualResult>
5252
</assertEquals>
5353
<waitForElement selector="{{page.cssClasses(index, cssClasses.value)}}" stepKey="waitForCSSClasses"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedConfigurationWithBorderColorActionGroup.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="ValidateAdvancedConfigurationWithBorderColorActionGroup" extends="ValidateAdvancedConfigurationAllOptionsActionGroup">
1111
<annotations>
12-
<description value="Validate Border color value."/>
12+
<description value="Validates Advanced configuration without Alignment and Css classes"/>
1313
</annotations>
1414
<arguments>
15-
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft.value"/>
15+
<argument name="page" defaultValue=""/>
16+
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft"/>
17+
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
1618
</arguments>
17-
<remove keyForRemoval="assertAlignment"/>
18-
<assertEquals stepKey="assertDefaultAlignment" after="grabAlignmentValue">
19-
<expectedResult type="string">{{defaultAlignment}}</expectedResult>
19+
<assertEquals stepKey="assertAlignment">
20+
<expectedResult type="string">{{defaultAlignment.value}}</expectedResult>
2021
<actualResult type="variable">grabAlignmentValue</actualResult>
2122
</assertEquals>
22-
<remove keyForRemoval="waitForCSSClassesVisible"/>
23-
<waitForElementVisible selector="{{page.noCssClasses(index)}}" stepKey="waitForCSSClassesVisible" after="assertBorderRadius"/>
23+
<waitForElementVisible selector="{{page.noCssClasses(index)}}" stepKey="waitForCSSClassesVisible"/>
2424
</actionGroup>
2525
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedConfigurationWithCssClassesActionGroup.xml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,20 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="ValidateAdvancedConfigurationWithCssClassesActionGroup" extends="ValidateAdvancedConfigurationAllOptionsActionGroup">
1111
<annotations>
12-
<description value="Validate Css classes property."/>
12+
<description value="Validates Advanced configuration without alignment and border"/>
1313
</annotations>
1414
<arguments>
15-
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft.value"/>
16-
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0.value"/>
17-
<argument name="cssClasses" defaultValue="PageBuilderAdvancedCssClassesProperty_Empty"/>
15+
<argument name="page" defaultValue=""/>
16+
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft"/>
17+
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
18+
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0"/>
1819
</arguments>
19-
<remove keyForRemoval="assertAlignment"/>
20-
<assertEquals stepKey="assertDefaultAlignmentVisible" after="grabAlignmentValue">
21-
<expectedResult type="string">{{defaultAlignment}}</expectedResult>
20+
<assertEquals stepKey="assertAlignment">
21+
<expectedResult type="string">{{defaultAlignment.value}}</expectedResult>
2222
<actualResult type="variable">grabAlignmentValue</actualResult>
2323
</assertEquals>
2424
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).color" stepKey="grabColorValue" after="grabBorderColorValue"/>
25-
<remove keyForRemoval="assertBorderColor"/>
26-
<assertEquals stepKey="assertBorderColorVisible" after="grabColorValue">
25+
<assertEquals stepKey="assertBorderColor">
2726
<expectedResult type="variable">grabBorderColorValue</expectedResult>
2827
<actualResult type="variable">grabColorValue</actualResult>
2928
</assertEquals>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedConfigurationWithNoAlignmentActionGroup.xml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,25 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" extends="ValidateAdvancedConfigurationAllOptionsActionGroup">
10+
<actionGroup name="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" extends="ValidateAdvancedConfigurationAllOptionsActionGroup">
1111
<annotations>
12-
<description value="Validate all options without alignment property."/>
12+
<description value="Validate Advanced Configuration without Alignment, Css classes and Border"/>
1313
</annotations>
1414
<arguments>
15-
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft.value"/>
16-
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0.value"/>
15+
<argument name="page" defaultValue=""/>
16+
<argument name="defaultAlignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft"/>
17+
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
18+
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthProperty0"/>
1719
</arguments>
18-
<remove keyForRemoval="assertAlignment"/>
19-
<assertEquals stepKey="assertDefaultAlignmentVisible" after="grabAlignmentValue">
20-
<expectedResult type="string">{{defaultAlignment}}</expectedResult>
20+
<assertEquals stepKey="assertAlignment">
21+
<expectedResult type="string">{{defaultAlignment.value}}</expectedResult>
2122
<actualResult type="variable">grabAlignmentValue</actualResult>
2223
</assertEquals>
2324
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedConfigurationPath(index)}}', document.body).iterateNext()).color" stepKey="grabColorValue" after="grabBorderColorValue"/>
24-
<remove keyForRemoval="assertBorderColor"/>
25-
<assertEquals stepKey="assertBorderColorVisible" after="grabColorValue">
25+
<assertEquals stepKey="assertBorderColor">
2626
<expectedResult type="variable">grabBorderColorValue</expectedResult>
2727
<actualResult type="variable">grabColorValue</actualResult>
2828
</assertEquals>
29-
<remove keyForRemoval="waitForCSSClassesVisible"/>
30-
<waitForElementVisible selector="{{page.noCssClasses(index)}}" stepKey="waitForCSSClassesVisible" after="assertBorderRadius"/>
29+
<waitForElementVisible selector="{{page.noCssClasses(index)}}" stepKey="waitForCSSClassesVisible"/>
3130
</actionGroup>
3231
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedConfigurationWithNoAlignmentEmptyBorderRadiusActionGroup.xml

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)