Skip to content

Commit 98425b3

Browse files
committed
MC-35103: Tracking Page Builder actions
- Refactor: introduce objectToCheck
1 parent c949a8f commit 98425b3

File tree

1 file changed

+13
-8
lines changed
  • app/code/Magento/PageBuilderAdminAnalytics/view/adminhtml/web/js/page-builder

1 file changed

+13
-8
lines changed

app/code/Magento/PageBuilderAdminAnalytics/view/adminhtml/web/js/page-builder/events-mixin.js

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ define(['underscore'], function (_underscore) {
1212
event,
1313
getAction,
1414
isAdminAnalyticsEnabled,
15-
visibilityHasChanged;
15+
hasVisibilityChanged,
16+
objectToCheck;
1617

1718
/**
1819
* Invokes custom code to track information regarding Page Builder usage
@@ -26,6 +27,7 @@ define(['underscore'], function (_underscore) {
2627
isAdminAnalyticsEnabled =
2728
!_underscore.isUndefined(window.digitalData) &&
2829
!_underscore.isUndefined(window._satellite);
30+
objectToCheck = '';
2931

3032
if (name.indexOf('readyAfter') !== -1 && isAdminAnalyticsEnabled) {
3133
window.digitalData.page.url = window.location.href;
@@ -38,17 +40,19 @@ define(['underscore'], function (_underscore) {
3840
console.log("antes", name);
3941
action = getAction(name, args);
4042

43+
if (objectToCheck === '') objectToCheck = args.contentType;
44+
4145
if (!_underscore.isUndefined(args) && !_underscore.isUndefined(args.contentType) &&
42-
!_underscore.isUndefined(args.contentType.config && action !== '')
46+
!_underscore.isUndefined(objectToCheck.config) && action !== ''
4347
) {
4448
console.log('justo antes de event');
4549
event = {
46-
element: args.contentType.config.label,
47-
type: args.contentType.config.name,
50+
element: objectToCheck.config.label,
51+
type: objectToCheck.config.name,
4852
action: action,
4953
widget: {
50-
name: args.contentType.config.form,
51-
type: args.contentType.config.menu_section
54+
name: objectToCheck.config.form,
55+
type: objectToCheck.config.menu_section
5256
},
5357
feature: 'page-builder-tracker'
5458
};
@@ -80,14 +84,15 @@ define(['underscore'], function (_underscore) {
8084

8185
if (arrayName.length === 3) {
8286
arrayNameObject = arrayName[1];
83-
triggeredAction = visibilityHasChanged(args[arrayNameObject]) ? 'hide/show': '';
87+
triggeredAction = hasVisibilityChanged(args[arrayNameObject]) ? 'hide/show': '';
88+
objectToCheck = args[arrayNameObject];
8489
}
8590
}
8691

8792
return triggeredAction;
8893
};
8994

90-
visibilityHasChanged = function(objectWrapper) {
95+
hasVisibilityChanged = function(objectWrapper) {
9196
var state,
9297
previousState;
9398

0 commit comments

Comments
 (0)