Skip to content

Commit 96bf7a9

Browse files
Merge branch 'develop' into ACQE-6192_mainline_PR_deployment
2 parents e827e81 + 1bf74cb commit 96bf7a9

File tree

5 files changed

+6
-24
lines changed

5 files changed

+6
-24
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeButtonActionGroup/ValidateButtonItemsSameSizeActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<argument name="firstButtonIndex" defaultValue="1" type="string"/>
1616
<argument name="secondButtonIndex" defaultValue="2" type="string"/>
1717
</arguments>
18+
<waitForPageLoad stepKey="waitForPageLoadToAssert"/>
1819
<comment userInput="validateButtonItemsSameSize" stepKey="comment"/>
1920
<waitForElementVisible selector="{{buttonGroupPage.base(buttonGroupIndex)}}" stepKey="waitForButtonGroup"/>
2021
<seeElement selector="{{buttonGroupPage.sameSizeValue(buttonGroupIndex, PageBuilderButtonGroupSameSize_Enabled.value)}}" stepKey="seeButtonSameSizeValue"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderButtonGroupAppearanceTest/ButtonGroupValidateSameSizeWhenSwitchingActiveTabTest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
<group value="pagebuilder-buttons"/>
2121
<group value="pagebuilder-buttonGroup"/>
2222
<group value="pagebuilder-tabs-content"/>
23-
<group value="pr_exclude"/>
2423
</annotations>
2524
<before>
2625
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderCommonTest/AdminPageBuilderPageButtonLinkTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
<waitForElementVisible selector="{{PageBuilderLinkAttributeAdmin.LinkItemSelected($createCMSPageA.title$)}}" stepKey="seeSearchResultHighlighted"/>
8181

8282
<!--Select another page from dropdown-->
83+
<scrollTo selector="{{PageBuilderLinkAttributeAdmin.LinkItemSelected($createCMSPageA.title$)}}" stepKey="scrollToLinks"/>
8384
<waitForElementClickable selector="{{PageBuilderLinkAttributeAdmin.LinkItemSelected($createCMSPageA.title$)}}" stepKey="waitForCMSPageBClickable"/>
8485
<click selector="{{PageBuilderLinkAttributeAdmin.SearchResult($createCMSPageB.title$)}}" stepKey="clickCMSPageBOnSearchResult"/>
8586
<grabTextFrom selector="{{PageBuilderLinkAttributeAdmin.DropdownInput}}" stepKey="textFromDropDown2"/>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/products/_default.less

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@
2727
margin-left: -20px;
2828
}
2929

30-
.product-items {
31-
&:extend(.abs-reset-list all);
32-
}
33-
3430
.product-item {
3531
display: inline-block;
3632
max-width: 100%;
@@ -40,8 +36,6 @@
4036
vertical-align: top;
4137
width: 200px;
4238

43-
&:extend(.abs-add-box-sizing all);
44-
4539
a,
4640
button,
4741
.swatch-attribute-options {
@@ -192,24 +186,16 @@
192186
}
193187

194188
&.towishlist {
195-
&:extend(.abs-actions-addto all);
196-
.lib-icon-font-symbol(
197-
@_icon-font-content: @icon-wishlist-full,
198-
@_icon-font-position: before
199-
);
189+
.lib-icon-font-symbol(@_icon-font-content: @icon-wishlist-full, @_icon-font-position: before);
200190
}
201191

202192
&.tocompare {
203-
.lib-icon-font-symbol(
204-
@_icon-font-content: @icon-compare-full,
205-
@_icon-font-position: before
206-
);
193+
.lib-icon-font-symbol(@_icon-font-content: @icon-compare-full, @_icon-font-position: before);
207194
}
208195
}
209196
}
210197

211198
.product-item-name {
212-
&:extend(.abs-product-link all);
213199
-moz-hyphens: auto;
214200
-ms-hyphens: auto;
215201
-webkit-hyphens: auto;
@@ -251,11 +237,7 @@
251237
}
252238

253239
.rating-summary {
254-
.lib-rating-summary(
255-
@_icon-font: 'luma-icons',
256-
@_icon-font-size: 16px,
257-
@_icon-letter-spacing: 2px
258-
);
240+
.lib-rating-summary(@_icon-font: 'luma-icons', @_icon-font-size: 16px, @_icon-letter-spacing: 2px);
259241
.lib-rating-summary-label-hide();
260242

261243
display: inline-block;
@@ -274,7 +256,6 @@
274256
overflow: hidden;
275257
position: relative;
276258
z-index: 1;
277-
&:extend(.abs-reset-image-wrapper all);
278259
}
279260

280261
.product-image-container {

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/validator-rules-mixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ define([
6767
* @return {Boolean}
6868
*/
6969
function validateCssClass(str) {
70-
return (/^[a-zA-Z _\-\d]+$/i).test(str);
70+
return (/^[a-zA-Z\d\-_/:.[\]&@()! ]+$/i).test(str);
7171
}
7272

7373
/**

0 commit comments

Comments
 (0)