MC-5410: Banner & Slide Are Missing <A> Tag For Link Attribute On Storefront

Convert data-target attribute to target

Author: danmooney2

app/code/Magento/PageBuilder/view/adminhtml/web/js/property/link.js

@@ -34,7 +34,7 @@ export default class Link implements PropertyReaderInterface {
 
         return {
             [attributeLinkType]: href,
-            setting: (element.getAttribute("data-target") || element.getAttribute("target")) === "_blank",
+            setting: element.getAttribute("target") === "_blank",
             type: attributeLinkType,
         };
     }

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/property/link.ts

@@ -1 +1 @@
-<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="never" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 0px;"><div data-element="link" href="http://domain.com/" data-target="_blank"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div></div></div></div></div>
+<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="never" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 0px;"><div data-element="link" href="http://domain.com/" target="_blank"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div></div></div></div></div>