Merge pull request #42 from magento-l3/MC-37476

MC-37476: "Magento\PageBuilder\Plugin\Filter\TemplatePlugin" mismatching strict type

Author: eug123

app/code/Magento/PageBuilder/Plugin/Filter/TemplatePlugin.php

@@ -7,6 +7,9 @@
 
 namespace Magento\PageBuilder\Plugin\Filter;
 
+use Magento\PageBuilder\Model\Filter\Template as TemplateFilter;
+use Magento\Framework\Filter\Template as FrameworkTemplateFilter;
+
 /**
  * Plugin to the template filter to process any background images added by Page Builder
  */
@@ -17,30 +20,30 @@ class TemplatePlugin
     const HTML_CONTENT_TYPE_PATTERN = '/data-content-type="html"/si';
 
     /**
-     * @var \Magento\PageBuilder\Model\Filter\Template
+     * @var TemplateFilter
      */
     private $templateFilter;
 
     /**
-     * @param \Magento\PageBuilder\Model\Filter\Template $templateFilter
+     * @param TemplateFilter $templateFilter
      */
     public function __construct(
-        \Magento\PageBuilder\Model\Filter\Template $templateFilter
+        TemplateFilter $templateFilter
     ) {
         $this->templateFilter = $templateFilter;
     }
 
     /**
      * After filter of template data apply transformations
      *
-     * @param \Magento\Framework\Filter\Template $subject
+     * @param FrameworkTemplateFilter $subject
      * @param string $result
      *
      * @return string
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterFilter(\Magento\Framework\Filter\Template $subject, string $result) : string
+    public function afterFilter(FrameworkTemplateFilter $subject, $result)
     {
-        return $this->templateFilter->filter($result);
+        return $this->templateFilter->filter((string) $result);
     }
 }

app/code/Magento/PageBuilder/Test/Unit/Plugin/Filter/TemplatePluginTest.php

@@ -0,0 +1,56 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\PageBuilder\Test\Unit\Plugin\Filter;
+
+use Magento\PageBuilder\Model\Filter\Template as TemplateFilter;
+use Magento\Framework\Filter\Template as FrameworkTemplateFilter;
+use Magento\PageBuilder\Plugin\Filter\TemplatePlugin;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Test for page builder template filter plugin
+ */
+class TemplatePluginTest extends TestCase
+{
+    /**
+     * @var FrameworkTemplateFilter|MockObject
+     */
+    private $frameworkTemplateFilter;
+
+    /**
+     * @var TemplateFilter|MockObject
+     */
+    private $templateFilter;
+
+    /**
+     * @var TemplatePlugin
+     */
+    private $templatePlugin;
+
+    /**
+     * @inheritDoc
+     */
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->frameworkTemplateFilter = $this->createMock(FrameworkTemplateFilter::class);
+        $this->templateFilter = $this->createMock(TemplateFilter::class);
+        $this->templatePlugin = new TemplatePlugin($this->templateFilter);
+    }
+
+    public function testAfterFilter(): void
+    {
+        $result = null;
+        $this->templateFilter->expects($this->once())
+            ->method('filter')
+            ->with('')
+            ->willReturn('');
+        $this->assertSame('', $this->templatePlugin->afterFilter($this->frameworkTemplateFilter, $result));
+    }
+}