Skip to content

Commit 944f6da

Browse files
dhaeckerdhaecker
committed
PB-266: Video background for Slide
- MFTF: removing slide specific data - MFTF: adding descriptive slide selector parameters - MFTF: updating severities
1 parent 009f944 commit 944f6da

8 files changed

+234
-246
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeSliderActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
<comment userInput="---merging to remove step---" stepKey="waitForBackgroundAttachment"/>
2828
</actionGroup>
2929
<actionGroup name="validateBackgroundAttributesForSlide" extends="validateBackgroundAttributes">
30-
<comment userInput="---merging to remove step---" stepKey="waitForBackgroundAttachment"/>
30+
<remove keyForRemoval="waitForBackgroundAttachment"/>
3131
</actionGroup>
3232
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/SlideData.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,6 @@
7171
<data key="fieldName">background_color</data>
7272
<data key="stageValue">rgb(250, 250, 250)</data>
7373
</entity>
74-
<!-- Background Type -->
75-
<entity name="PageBuilderSlideItemBackgroundType_Image" type="pagebuilder_slide_item_background_type_property">
76-
<data key="name">Background Type</data>
77-
<data key="section">background</data>
78-
<data key="fieldName">background_type</data>
79-
<data key="value">image</data>
80-
</entity>
81-
<entity name="PageBuilderSlideItemBackgroundType_Video" type="pagebuilder_slide_item_background_type_property">
82-
<data key="name">Background Type</data>
83-
<data key="section">background</data>
84-
<data key="fieldName">background_type</data>
85-
<data key="value">video</data>
86-
</entity>
8774
<!-- Link -->
8875
<entity name="PageBuilderSlideItemLinkURL_Empty" type="pagebuilder_slide_item_link_url_property">
8976
<data key="name">Link</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 184 additions & 184 deletions
Large diffs are not rendered by default.

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,7 @@
727727
<stories value="Slider"/>
728728
<title value="Validate Collage Center Slide with No Fallback Image, Disabled Infinite Loop, Disabled Play Only When Visible, and Disabled Lazy Load"/>
729729
<description value="Validate video background with no fallback image, disabled infinite loop, disabled play only when visible, and disabled lazy load."/>
730-
<severity value="MAJOR"/>
730+
<severity value="BLOCKER"/>
731731
<useCaseId value="PB-266"/>
732732
<testCaseId value="MC-31835"/>
733733
<group value="pagebuilder"/>
@@ -745,7 +745,7 @@
745745
<stories value="Slider"/>
746746
<title value="Validate Video Background in Collage Center Slide"/>
747747
<description value="Set all video background attributes for a Collage Center Slide and validate on stage and storefront."/>
748-
<severity value="CRITICAL"/>
748+
<severity value="BLOCKER"/>
749749
<useCaseId value="PB-266"/>
750750
<testCaseId value="MC-31839"/>
751751
<group value="pagebuilder"/>
@@ -763,7 +763,7 @@
763763
<stories value="Slider"/>
764764
<title value="Validate Video Background Fallback Image Renders When Video Isn't Loaded in Collage Center Slide"/>
765765
<description value="Validate that the video background fallback image loads and renders in a Collage Center Slide when the video hasn't loaded."/>
766-
<severity value="MAJOR"/>
766+
<severity value="BLOCKER"/>
767767
<useCaseId value="PB-266"/>
768768
<testCaseId value="MC-31848"/>
769769
<group value="pagebuilder"/>
@@ -781,7 +781,7 @@
781781
<stories value="Slider"/>
782782
<title value="Verify Collage Center Slide Renders When Video Isn't Loaded and There's No Fallback Image"/>
783783
<description value="Validate that the Row renders correctly when the video background video hasn't loaded and there is no fallback image."/>
784-
<severity value="AVERAGE"/>
784+
<severity value="BLOCKER"/>
785785
<useCaseId value="PB-266"/>
786786
<testCaseId value="MC-31849"/>
787787
<group value="pagebuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@
604604
<stories value="Slider"/>
605605
<title value="Validate Collage Left Slide with No Fallback Image, Disabled Infinite Loop, Disabled Play Only When Visible, and Disabled Lazy Load"/>
606606
<description value="Validate video background with no fallback image, disabled infinite loop, disabled play only when visible, and disabled lazy load."/>
607-
<severity value="MAJOR"/>
607+
<severity value="BLOCKER"/>
608608
<useCaseId value="PB-266"/>
609609
<testCaseId value="MC-31834"/>
610610
<group value="pagebuilder"/>
@@ -622,7 +622,7 @@
622622
<stories value="Slider"/>
623623
<title value="Validate Video Background in Collage Left Slide"/>
624624
<description value="Set all video background attributes for a Collage Left Slide and validate on stage and storefront."/>
625-
<severity value="CRITICAL"/>
625+
<severity value="BLOCKER"/>
626626
<useCaseId value="PB-266"/>
627627
<testCaseId value="MC-31842"/>
628628
<group value="pagebuilder"/>
@@ -640,7 +640,7 @@
640640
<stories value="Slider"/>
641641
<title value="Validate Video Background Fallback Image Renders When Video Isn't Loaded in Collage Left Slide"/>
642642
<description value="Validate that the video background fallback image loads and renders in a Collage Left Slide when the video hasn't loaded."/>
643-
<severity value="MAJOR"/>
643+
<severity value="BLOCKER"/>
644644
<useCaseId value="PB-266"/>
645645
<testCaseId value="MC-31846"/>
646646
<group value="pagebuilder"/>
@@ -658,7 +658,7 @@
658658
<stories value="Slider"/>
659659
<title value="Verify Collage Left Slide Renders When Video Isn't Loaded and There's No Fallback Image"/>
660660
<description value="Validate that the Row renders correctly when the video background video hasn't loaded and there is no fallback image."/>
661-
<severity value="AVERAGE"/>
661+
<severity value="BLOCKER"/>
662662
<useCaseId value="PB-266"/>
663663
<testCaseId value="MC-31847"/>
664664
<group value="pagebuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@
505505
<stories value="Slider"/>
506506
<title value="Validate Collage Right Slide with No Fallback Image, Disabled Infinite Loop, Disabled Play Only When Visible, and Disabled Lazy Load"/>
507507
<description value="Validate video background with no fallback image, disabled infinite loop, disabled play only when visible, and disabled lazy load."/>
508-
<severity value="MAJOR"/>
508+
<severity value="BLOCKER"/>
509509
<useCaseId value="PB-266"/>
510510
<testCaseId value="MC-31833"/>
511511
<group value="pagebuilder"/>
@@ -523,7 +523,7 @@
523523
<stories value="Slider"/>
524524
<title value="Validate Video Background in Collage Right Slide"/>
525525
<description value="Set all video background attributes for a Collage Right Slide and validate on stage and storefront."/>
526-
<severity value="CRITICAL"/>
526+
<severity value="BLOCKER"/>
527527
<useCaseId value="PB-266"/>
528528
<testCaseId value="MC-31840"/>
529529
<group value="pagebuilder"/>
@@ -541,9 +541,10 @@
541541
<stories value="Slider"/>
542542
<title value="Validate Video Background Fallback Image Renders When Video Isn't Loaded in Collage Right Slide"/>
543543
<description value="Validate that the video background fallback image loads and renders in a Collage Right Slide when the video hasn't loaded."/>
544-
<severity value="MAJOR"/>
544+
<severity value="BLOCKER"/>
545545
<useCaseId value="PB-266"/>
546546
<testCaseId value="MC-31850"/>
547+
<group value="pagebuilder"/>
547548
<group value="pagebuilder-slide"/>
548549
<group value="pagebuilder-sliderCollageRight"/>
549550
<group value="pagebuilder-video-background"/>
@@ -558,7 +559,7 @@
558559
<stories value="Slider"/>
559560
<title value="Verify Collage Right Slide Renders When Video Isn't Loaded and There's No Fallback Image"/>
560561
<description value="Validate that the Row renders correctly when the video background video hasn't loaded and there is no fallback image."/>
561-
<severity value="AVERAGE"/>
562+
<severity value="BLOCKER"/>
562563
<useCaseId value="PB-266"/>
563564
<testCaseId value="MC-31851"/>
564565
<group value="pagebuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,7 +1698,7 @@
16981698
<stories value="Slider"/>
16991699
<title value="Validate Poster Slide with No Fallback Image, Disabled Infinite Loop, Disabled Play Only When Visible, and Disabled Lazy Load"/>
17001700
<description value="Validate video background with no fallback image, disabled infinite loop, disabled play only when visible, and disabled lazy load."/>
1701-
<severity value="MAJOR"/>
1701+
<severity value="BLOCKER"/>
17021702
<useCaseId value="PB-266"/>
17031703
<testCaseId value="MC-31830"/>
17041704
<group value="pagebuilder"/>
@@ -1738,7 +1738,7 @@
17381738
<argument name="property" value="PageBuilderMinHeightProperty_200px"/>
17391739
</actionGroup>
17401740
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
1741-
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
1741+
<argument name="property" value="PageBuilderBackgroundType_Video"/>
17421742
</actionGroup>
17431743
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterVideoUrl">
17441744
<argument name="property" value="PageBuilderVideoBackgroundUrl_YouTube_Embedded"/>
@@ -1825,7 +1825,7 @@
18251825
<stories value="Slider"/>
18261826
<title value="Validate Video Background in Poster Slide"/>
18271827
<description value="Set all video background attributes for a Poster Slide and validate on stage and storefront."/>
1828-
<severity value="CRITICAL"/>
1828+
<severity value="BLOCKER"/>
18291829
<useCaseId value="PB-266"/>
18301830
<testCaseId value="MC-31841"/>
18311831
<group value="pagebuilder"/>
@@ -1876,7 +1876,7 @@
18761876
<argument name="property" value="PageBuilderBackgroundColor_Pink"/>
18771877
</actionGroup>
18781878
<actionGroup ref="chooseVisualSelectOption" stepKey="setBackgroundType">
1879-
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
1879+
<argument name="property" value="PageBuilderBackgroundType_Video"/>
18801880
</actionGroup>
18811881
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterVideoUrl">
18821882
<argument name="property" value="PageBuilderVideoBackgroundUrl_YouTube_Embedded"/>
@@ -1940,7 +1940,7 @@
19401940
<argument name="property" value="PageBuilderBackgroundColor_Pink"/>
19411941
</actionGroup>
19421942
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeBackgroundType">
1943-
<argument name="property" value="PageBuilderSlideItemBackgroundType_Video"/>
1943+
<argument name="property" value="PageBuilderBackgroundType_Video"/>
19441944
</actionGroup>
19451945
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeVideoUrl">
19461946
<argument name="property" value="PageBuilderVideoBackgroundUrl_YouTube_Embedded"/>
@@ -1982,7 +1982,7 @@
19821982
<stories value="Slider"/>
19831983
<title value="Validate Video Background Fallback Image Renders When Video Isn't Loaded in Poster Slide"/>
19841984
<description value="Validate that the video background fallback image loads and renders in a Poster Slide when the video hasn't loaded."/>
1985-
<severity value="MAJOR"/>
1985+
<severity value="BLOCKER"/>
19861986
<useCaseId value="PB-266"/>
19871987
<testCaseId value="MC-31844"/>
19881988
<group value="pagebuilder"/>
@@ -2078,7 +2078,7 @@
20782078
<stories value="Slider"/>
20792079
<title value="Verify Poster Slide Renders When Video Isn't Loaded and There's No Fallback Image"/>
20802080
<description value="Validate that the Row renders correctly when the video background video hasn't loaded and there is no fallback image."/>
2081-
<severity value="AVERAGE"/>
2081+
<severity value="BLOCKER"/>
20822082
<useCaseId value="PB-266"/>
20832083
<testCaseId value="MC-31845"/>
20842084
<group value="pagebuilder"/>

0 commit comments

Comments
 (0)