Skip to content

Commit 93d72e9

Browse files
committed
Merge branch 'MAGETWO-75104-Slide-and-Banner-Image-from-Stage' of github.com:magento-trigger/magento2-page-builder into MAGETWO-75104-Slide-and-Banner-Image-from-Stage
2 parents 6702ea1 + 0b36295 commit 93d72e9

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
</section>
132132
<section name="SlideOnBackend">
133133
<element name="optionTitle" type="button" selector=".pagebuilder-slider .navigation-dot.active .option-title"/>
134-
<element name="collageOverlay" type="button" selector=".pagebuilder-collage-overlay"/>
134+
<element name="collageOverlayGeneral" type="button" selector=".pagebuilder-collage-overlay"/>
135135
<element name="slideAppearancePoster" type="button" selector="[data-slick-index='{{arg1}}'] .pagebuilder-poster-content" parameterized="true"/>
136136
<element name="slideAppearanceCollageLeft" type="button" selector="[data-slick-index='{{arg1}}'] .pagebuilder-slide [style*='40px calc(50% + 40px) 40px 40px']" parameterized="true"/>
137137
<element name="slideAppearanceCollageCenter" type="button" selector="[data-slick-index='{{arg1}}'] .pagebuilder-slide [style*='40px calc(25% + 40px)']" parameterized="true"/>
@@ -186,7 +186,6 @@
186186
<element name="slideBorderRadiusStyle" type="button" selector="div[style*='border-radius: {{arg1}}']" parameterized="true"/>
187187
<element name="editFormBackgroundImagePreview" type="button" selector="//input[@name='background_image']/ancestor::div[@class='admin__field-control']/descendant::img"/>
188188
<element name="editFormBackgroundMobileImagePreview" type="button" selector="//input[@name='mobile_image']/ancestor::div[@class='admin__field-control']/descendant::img"/>
189-
<element name="collageOverlay" type="button" selector=".pagebuilder-collage-overlay"/>
190189
</section>
191190
<section name="SlideOnConfigurationPanel">
192191
<element name="tinyMCEIFrame" type="text" selector="pagebuilder_slide_form_content_ifr"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1073,7 +1073,8 @@
10731073
<title value="Add image into Banner from the Stage"/>
10741074
<description value="A user should be able to add image to Banner stage."/>
10751075
<severity value="CRITICAL"/>
1076-
<testCaseId value="MAGETWO-75104"/>
1076+
<testCaseId value="MAGETWO-92118"/>
1077+
<useCaseId value="MAGETWO-75104"/>
10771078
<group value="pagebuilder"/>
10781079
<group value="pagebuilder-banner"/>
10791080
<group value="pagebuilder-bannerCommon"/>
@@ -1143,7 +1144,8 @@
11431144
<title value="Add image into Banner from the Stage"/>
11441145
<description value="A user should be able to add image to Banner stage when switching between appearance type"/>
11451146
<severity value="CRITICAL"/>
1146-
<testCaseId value="MAGETWO-75104"/>
1147+
<useCaseId value="MAGETWO-75104"/>
1148+
<testCaseId value="MAGETWO-92118"/>
11471149
<group value="pagebuilder"/>
11481150
<group value="pagebuilder-banner"/>
11491151
<group value="pagebuilder-bannerCommon"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideCommonTest.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,8 @@
10481048
<title value="Add image into Slider from the Stage"/>
10491049
<description value="A user should be able to add image to Slider stage."/>
10501050
<severity value="CRITICAL"/>
1051-
<testCaseId value="MAGETWO-75104"/>
1051+
<useCaseId value="MAGETWO-75104"/>
1052+
<testCaseId value="MAGETWO-92116"/>
10521053
<group value="pagebuilder"/>
10531054
<group value="pagebuilder-slider"/>
10541055
<group value="pagebuilder-sliderCommon"/>
@@ -1120,7 +1121,8 @@
11201121
<title value="Add image into Slider from the Stage"/>
11211122
<description value="A user should be able to add image to Slider stage when switching between appearance type."/>
11221123
<severity value="CRITICAL"/>
1123-
<testCaseId value="MAGETWO-75104"/>
1124+
<useCaseId value="MAGETWO-75104"/>
1125+
<testCaseId value="MAGETWO-92116"/>
11241126
<group value="pagebuilder"/>
11251127
<group value="pagebuilder-slider"/>
11261128
<group value="pagebuilder-sliderCommon"/>
@@ -1147,7 +1149,7 @@
11471149
<argument name="property" value="PageBuilderSlideCollageLeftProperty"/>
11481150
</actionGroup>
11491151
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
1150-
<click selector="{{SlideOnBackend.collageOverlay}}" stepKey="clickSliderInStage1"/>
1152+
<click selector="{{SlideOnBackend.collageOverlayGeneral}}" stepKey="clickSliderInStage1"/>
11511153
<comment userInput="Verify there are 2 buttons when hovering" stepKey="commentVerifyButtons1" />
11521154
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons1" >
11531155
<argument name="contentBlockType" value="PageBuilderSliderContentBlock"/>
@@ -1161,7 +1163,7 @@
11611163
<argument name="property" value="PageBuilderSlideCollageCenteredProperty"/>
11621164
</actionGroup>
11631165
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
1164-
<click selector="{{SlideOnBackend.collageOverlay}}" stepKey="clickSliderInStage2"/>
1166+
<click selector="{{SlideOnBackend.collageOverlayGeneral}}" stepKey="clickSliderInStage2"/>
11651167
<comment userInput="Verify there are 2 buttons when hovering" stepKey="commentVerifyButtons2" />
11661168
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons2" >
11671169
<argument name="contentBlockType" value="PageBuilderSliderContentBlock"/>
@@ -1176,7 +1178,7 @@
11761178
</actionGroup>
11771179
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
11781180
<!--Verify there are 2 buttons when hovering-->
1179-
<click selector="{{SlideOnBackend.collageOverlay}}" stepKey="clickSliderInStage3"/>
1181+
<click selector="{{SlideOnBackend.collageOverlayGeneral}}" stepKey="clickSliderInStage3"/>
11801182
<comment userInput="Verify there are 2 buttons when hovering" stepKey="commentVerifyButtons3" />
11811183
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons3" >
11821184
<argument name="contentBlockType" value="PageBuilderSliderContentBlock"/>

0 commit comments

Comments
 (0)