Skip to content

Commit 9340e8d

Browse files
dhaeckerdhaecker
committed
PB-207: Empty "Category" or "SKU" condition option causes error on save
- Adding tests and action group for saving empty products content type
1 parent 93f14e9 commit 9340e8d

File tree

3 files changed

+114
-0
lines changed

3 files changed

+114
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,14 @@
5555
<grabMultiple selector="{{page.product(index)}}" stepKey="grabProducts"/>
5656
<assertCount stepKey="assertCount" expected="{{count}}" expectedType="int" actualType="variable" actual="grabProducts"/>
5757
</actionGroup>
58+
<actionGroup name="validateEmptyProductsContainer">
59+
<arguments>
60+
<argument name="page" defaultValue="ProductsOnStage"/>
61+
<argument name="productGroupIndex" defaultValue="1" type="string"/>
62+
</arguments>
63+
<waitForElement selector="{{page.emptyProductsPlaceholder(productGroupIndex)}}" stepKey="waitForEmptyProducts"/>
64+
<see userInput="{{PageBuilderProductsMessage.noProductsFound}}" selector="{{page.emptyProductsPlaceholder(productGroupIndex)}}" stepKey="seeEmptyProductsMessage"/>
65+
</actionGroup>
5866
<actionGroup name="selectCategoryFromCategoryDropDown">
5967
<arguments>
6068
<argument name="property" defaultValue="PageBuilderProductsSelectCategoryDropDown"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCarouselTests.xml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -699,4 +699,34 @@
699699
<argument name="index" value="1"/>
700700
</actionGroup>
701701
</test>
702+
<test name="AdminPageBuilderProductsCarouselValidateCanSaveProductsWithEmptyConditions" extends="AdminPageBuilderProductsGridValidateCanSaveProductsWithEmptyConditions">
703+
<annotations>
704+
<features value="PageBuilder"/>
705+
<stories value="Products"/>
706+
<title value="Carousel - Validate Can Save Products with Empty Condition"/>
707+
<description value="Validate that a user can save a Products content type without any conditions set"/>
708+
<severity value="CRITICAL"/>
709+
<useCaseId value="PB-207"/>
710+
<testCaseId value="MC-22881"/>
711+
<group value="pagebuilder"/>
712+
<group value="pagebuilder-products"/>
713+
<group value="pagebuilder-productsCarousel"/>
714+
</annotations>
715+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
716+
<argument name="property" value="PageBuilderProductsProductCarouselAppearance"/>
717+
</actionGroup>
718+
<actionGroup ref="validateEmptyProductsContainer" stepKey="validateEmptyProductsContainerOnStage">
719+
<argument name="page" value="ProductsCarouselOnStage"/>
720+
</actionGroup>
721+
<actionGroup ref="validateEmptyProductsContainer" stepKey="validateEmptyProductsContainerOnStage2">
722+
<argument name="page" value="ProductsCarouselOnStage"/>
723+
</actionGroup>
724+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterProductsCount3">
725+
<argument name="property" value="PageBuilderProductsCarouselCountPropertyMax"/>
726+
</actionGroup>
727+
<actionGroup ref="validateProductInProducts" stepKey="validateProductOnStage3">
728+
<argument name="page" value="ProductsCarouselOnStage"/>
729+
<argument name="product" value="_defaultProduct"/>
730+
</actionGroup>
731+
</test>
702732
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsGridTests.xml

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1140,4 +1140,80 @@
11401140
</actionGroup>
11411141
<dontSeeElementInDOM selector="{{ProductsOnStorefront.product('1')}}" stepKey="validateNoProductsOnStorefront" after="navigateToCMSPageStorefront2"/>
11421142
</test>
1143+
<test name="AdminPageBuilderProductsGridValidateCanSaveProductsWithEmptyConditions">
1144+
<annotations>
1145+
<features value="PageBuilder"/>
1146+
<stories value="Products"/>
1147+
<title value="Grid - Validate Can Save Products with Empty Condition"/>
1148+
<description value="Validate that a user can save a Products content type without any conditions set"/>
1149+
<severity value="CRITICAL"/>
1150+
<useCaseId value="PB-207"/>
1151+
<testCaseId value="MC-22880"/>
1152+
<group value="pagebuilder"/>
1153+
<group value="pagebuilder-products"/>
1154+
<group value="pagebuilder-productsGrid"/>
1155+
</annotations>
1156+
<before>
1157+
<createData entity="PageBuilderProductsSubCategory" stepKey="createCategory"/>
1158+
<createData entity="_defaultProduct" stepKey="createProduct">
1159+
<requiredEntity createDataKey="createCategory"/>
1160+
</createData>
1161+
<createData entity="_emptyCmsPage" stepKey="createCMSPage"/>
1162+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1163+
<actionGroup ref="navigateToCMSPage" stepKey="navigateToCMSPage">
1164+
<argument name="CMSPage" value="$$createCMSPage$$"/>
1165+
</actionGroup>
1166+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1167+
</before>
1168+
<after>
1169+
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
1170+
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
1171+
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
1172+
<actionGroup ref="logout" stepKey="logout"/>
1173+
</after>
1174+
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandMenuSectionAddContent">
1175+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1176+
</actionGroup>
1177+
<actionGroup ref="dragContentTypeToStage" stepKey="dragProductsIntoStage">
1178+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1179+
</actionGroup>
1180+
<!-- Validate: Empty Category Condition -->
1181+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditPanel">
1182+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1183+
</actionGroup>
1184+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
1185+
<argument name="property" value="PageBuilderProductsProductGridAppearance"/>
1186+
</actionGroup>
1187+
<actionGroup ref="chooseVisualSelectOption" stepKey="chooseSelectProductsBy">
1188+
<argument name="property" value="PageBuilderProductsSelectProductsByCategory"/>
1189+
</actionGroup>
1190+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1191+
<actionGroup ref="validateEmptyProductsContainer" stepKey="validateEmptyProductsContainerOnStage"/>
1192+
<!-- Validate: Empty SKU Condition -->
1193+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditPanel2">
1194+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1195+
</actionGroup>
1196+
<actionGroup ref="chooseVisualSelectOption" stepKey="chooseSelectProductsBy2">
1197+
<argument name="property" value="PageBuilderProductsSelectProductsBySKU"/>
1198+
</actionGroup>
1199+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
1200+
<actionGroup ref="validateEmptyProductsContainer" stepKey="validateEmptyProductsContainerOnStage2"/>
1201+
<!-- Validate: Empty Conditions -->
1202+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditPanel3">
1203+
<argument name="contentType" value="PageBuilderProductsContentType"/>
1204+
</actionGroup>
1205+
<actionGroup ref="chooseVisualSelectOption" stepKey="chooseSelectProductsBy3">
1206+
<argument name="property" value="PageBuilderProductsSelectProductsByCondition"/>
1207+
</actionGroup>
1208+
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="enterSortBy3">
1209+
<argument name="property" value="PageBuilderProductsSortByNewestTop"/>
1210+
</actionGroup>
1211+
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterProductsCount3">
1212+
<argument name="property" value="PageBuilderProductsCountPropertyMax"/>
1213+
</actionGroup>
1214+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
1215+
<actionGroup ref="validateProductInProducts" stepKey="validateProductOnStage3">
1216+
<argument name="product" value="_defaultProduct"/>
1217+
</actionGroup>
1218+
</test>
11431219
</tests>

0 commit comments

Comments
 (0)