Skip to content

Commit 92cca8d

Browse files
committed
MC-18601: Page Builder Render
1 parent efd0c6e commit 92cca8d

File tree

4 files changed

+26
-12
lines changed

4 files changed

+26
-12
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/master-format/render.js

Lines changed: 10 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/stage.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/master-format/render.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,17 @@ export default class MasterFormatRenderer {
2828
* @returns {Promise<string>}
2929
*/
3030
public applyBindings(rootContainer: ContentTypeCollectionInterface): Promise<string> {
31-
if (!this.getRenderFrame()) {
32-
console.error("No render frame present for Page Builder instance.");
33-
return;
34-
}
35-
3631
return new Promise((resolve, reject) => {
32+
if (!this.getRenderFrame()) {
33+
// If the stage exists we should also have a frame
34+
if (document.getElementById(this.stageId)) {
35+
return reject("No render frame present for Page Builder instance.");
36+
}
37+
38+
// Otherwise the instance of Page Builder has been removed from the DOM and this is an old instance.
39+
return reject();
40+
}
41+
3742
if (this.ready) {
3843
this.channel.port1.postMessage({
3944
type: "render",

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/stage.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ export default class Stage {
5454
})).then(() => {
5555
this.renderingLock.resolve();
5656
}).catch((error: Error) => {
57-
console.error(error);
57+
if (error) {
58+
console.error(error);
59+
}
5860
});
5961
}, 500);
6062

0 commit comments

Comments
 (0)