Skip to content

Commit 92c4e91

Browse files
author
Hwashiang Yu
committed
MC-843: Heading live edit should become unfocused on drag action
- Added test coverage for bug
1 parent 9809ce9 commit 92c4e91

File tree

2 files changed

+40
-0
lines changed

2 files changed

+40
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderHeadingSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<element name="headingOnStage" type="text" selector="(//{{arg1}}[contains(@data-bind,'heading_text')])[{{arg2}}]" parameterized="true"/>
1818
<element name="headingType" type="button" selector="(//{{arg1}})[{{arg2}}]" parameterized="true"/>
1919
<element name="headingEditableText" type="button" selector="(//div[contains(@class, 'pagebuilder-heading')])[{{arg1}}]//h2[contains(@contenteditable, 'true')]" parameterized="true"/>
20+
<element name="headingToolbar" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])//div[contains(@class, 'pagebuilder-toolbar-options')]"/>
2021
<element name="headingTypeToolbar" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//span[text()='{{arg2}}']" parameterized="true"/>
2122
<element name="headingTypeToolbarSelected" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//a[contains(@class, 'toolbar-active')]//span[text()='{{arg2}}']" parameterized="true"/>
2223
<element name="headingTextAlignToolbar" type="button" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//i[contains(@class,'icon-pagebuilder-align-{{arg2}}')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingEditOnStageTest.xml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1574,4 +1574,43 @@
15741574
<expectedResult type="variable">actualLastButtonYPosition</expectedResult>
15751575
</assertLessThan>
15761576
</test>
1577+
<test name="HeadingToolbarHideOnDrag">
1578+
<annotations>
1579+
<features value="PageBuilder"/>
1580+
<stories value="Heading"/>
1581+
<title value="Stage Edit - Heading Toolbar should hide on drag action"/>
1582+
<description value="Heading live edit should become unfocused on drag action"/>
1583+
<severity value="CRITICAL"/>
1584+
<useCaseId value="MC-843"/>
1585+
<testCaseId value="MC-3540"/>
1586+
<group value="pagebuilder"/>
1587+
<group value="pagebuilder-heading"/>
1588+
<group value="m"/>
1589+
</annotations>
1590+
<before>
1591+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1592+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1593+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1594+
</before>
1595+
<after>
1596+
<actionGroup ref="logout" stepKey="logout"/>
1597+
</after>
1598+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1599+
<argument name="group" value="PageBuilderHeadingContentType"/>
1600+
</actionGroup>
1601+
<actionGroup ref="dragContentTypeToStage" stepKey="dragHeadingIntoStage">
1602+
<argument name="contentType" value="PageBuilderHeadingContentType"/>
1603+
</actionGroup>
1604+
<waitForPageLoad stepKey="waitForAnimation" time="30"/>
1605+
<comment userInput="Validate Heading edit toolbar" stepKey="CommentHeadingEditToolbar"/>
1606+
<seeElement selector="{{HeadingOnStage.headingToolbar}}" stepKey="seeHeadingToolbar"/>
1607+
<comment userInput="When click on draggable content, heading input loses focus, toolbar disappears, and placeholder displays Enter Heading Text" stepKey="commentClickOnDraggable"/>
1608+
<click selector="{{PageBuilderPanel.draggableContentTypeInPanel(PageBuilderHeadingContentType.name)}}" stepKey="clickDraggableInPanel"/>
1609+
<dontSeeElement selector="{{HeadingOnStage.headingToolbar}}" stepKey="dontSeeHeadingToolbar"/>
1610+
<comment userInput="When click inside heading see heading input gain focus, placeholder disappears and WYSIWYG toolbar appears" stepKey="commentClickInsideHeading"/>
1611+
<actionGroup ref="clickInsideLiveEditHeading" stepKey="clickInsideLiveEditHeading">
1612+
<argument name="index" value="1"/>
1613+
</actionGroup>
1614+
<seeElement selector="{{HeadingOnStage.headingToolbar}}" stepKey="seeHeadingToolbar2"/>
1615+
</test>
15771616
</tests>

0 commit comments

Comments
 (0)