Skip to content

Commit 90fbd1f

Browse files
committed
PB-277: Full height Row
- Fixing failing tests
1 parent eb0cb93 commit 90fbd1f

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTests.xml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1073,11 +1073,15 @@
10731073
<argument name="property" value="PageBuilderPadding_0"/>
10741074
</actionGroup>
10751075
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1076-
<!-- Row 2: Min Height = 100vh -->
10771076
<actionGroup ref="duplicateContentType" stepKey="duplicateContentType1">
10781077
<argument name="contentType" value="PageBuilderRowContentType"/>
10791078
<argument name="targetIndex" value="1"/>
10801079
</actionGroup>
1080+
<actionGroup ref="duplicateContentType" stepKey="duplicateContentType2">
1081+
<argument name="contentType" value="PageBuilderRowContentType"/>
1082+
<argument name="targetIndex" value="1"/>
1083+
</actionGroup>
1084+
<!-- Row 2: Min Height = 100vh -->
10811085
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanel2">
10821086
<argument name="contentType" value="PageBuilderRowContentType"/>
10831087
<argument name="contentTypeIndex" value="2"/>
@@ -1087,12 +1091,6 @@
10871091
</actionGroup>
10881092
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
10891093
<!-- Row 3: Min Height = 100vh - 200px -->
1090-
<scrollTo selector="{{RowOnStage.base('2')}}" x="0" y="-400" stepKey="scrollToRow2"/>
1091-
<actionGroup ref="duplicateContentType" stepKey="duplicateContentType2">
1092-
<argument name="contentType" value="PageBuilderRowContentType"/>
1093-
<argument name="targetIndex" value="2"/>
1094-
</actionGroup>
1095-
<scrollTo selector="{{RowOnStage.base('3')}}" x="0" y="-400" stepKey="scrollToRow3"/>
10961094
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanel3">
10971095
<argument name="contentType" value="PageBuilderRowContentType"/>
10981096
<argument name="contentTypeIndex" value="3"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowLayoutTest.xml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -588,11 +588,15 @@
588588
<argument name="property" value="PageBuilderPadding_0"/>
589589
</actionGroup>
590590
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
591-
<!-- Row 2: Min Height = 100vh -->
592591
<actionGroup ref="duplicateContentType" stepKey="duplicateContentType1">
593592
<argument name="contentType" value="PageBuilderRowContentType"/>
594593
<argument name="targetIndex" value="1"/>
595594
</actionGroup>
595+
<actionGroup ref="duplicateContentType" stepKey="duplicateContentType2">
596+
<argument name="contentType" value="PageBuilderRowContentType"/>
597+
<argument name="targetIndex" value="1"/>
598+
</actionGroup>
599+
<!-- Row 2: Min Height = 100vh -->
596600
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanel2">
597601
<argument name="contentType" value="PageBuilderRowContentType"/>
598602
<argument name="contentTypeIndex" value="2"/>
@@ -602,12 +606,6 @@
602606
</actionGroup>
603607
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
604608
<!-- Row 3: Min Height = 100vh - 200px -->
605-
<scrollTo selector="{{RowOnStage.base('2')}}" x="0" y="-400" stepKey="scrollToRow2"/>
606-
<actionGroup ref="duplicateContentType" stepKey="duplicateContentType2">
607-
<argument name="contentType" value="PageBuilderRowContentType"/>
608-
<argument name="targetIndex" value="2"/>
609-
</actionGroup>
610-
<scrollTo selector="{{RowOnStage.base('3')}}" x="0" y="-400" stepKey="scrollToRow3"/>
611609
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanel3">
612610
<argument name="contentType" value="PageBuilderRowContentType"/>
613611
<argument name="contentTypeIndex" value="3"/>

0 commit comments

Comments
 (0)