Skip to content

Commit 8fe4a3a

Browse files
Merge remote-tracking branch 'origin/MC-501-tech-debt-revise-naming-for-events' into cms-team-2-sprint-11
2 parents 65ae6e6 + f2d5394 commit 8fe4a3a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+435
-425
lines changed

app/code/Magento/PageBuilder/docs/events.md

Lines changed: 53 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -49,44 +49,43 @@ This document contains reference information for events dispatched in Page Build
4949

5050
## Events list
5151

52-
* [contentType:create](#contenttypecreate)
53-
* [contentType:ready](#contenttypeready)
54-
* [contentType:dropped:create](#contenttypedroppedcreate)
55-
* [contentType:mount](#contenttypemount)
56-
* [contentType:afterRender](#contenttypeafterrender)
57-
* [contentType:removed](#contenttyperemoved)
58-
* [contentType:duplicate](#contenttypeduplicate)
59-
* [contentType:beforeMove](#contenttypebeforemove)
60-
* [contentType:move](#contenttypemove)
61-
* [column:drag:start](#columdragstart)
62-
* [column:drag:stop](#columndragstop)
63-
* [column:initElement](#columninitelement)
64-
* [image:assigned:{{id}}](#imageassignedid)
65-
* [image:contentType:ready](#imagecontenttypeready)
66-
* [image:uploaded](#imageuploaded)
67-
* [interaction:start](#interactionstart)
68-
* [interaction:stop](#interactionstop)
69-
* [pagebuilder:toggleFullScreen:{{id}}](#pagebuildertogglefullscreenid)
70-
* [previewObservables:updated](#previewobservablesupdated)
52+
* [contentType:createAfter](#contenttypecreateafter)
53+
* [contentType:dropAfter](#contenttypedropafter)
54+
* [contentType:mountAfter](#contenttypemountafter)
55+
* [contentType:renderAfter](#contenttyperenderafter)
56+
* [contentType:removeAfter](#contenttyperemoveafter)
57+
* [contentType:duplicateAfter](#contenttypeduplicateafter)
58+
* [contentType:moveBefore](#contenttypemovebefore)
59+
* [contentType:moveAfter](#contenttypemoveafter)
60+
* [column:dragStart](#columdragstart)
61+
* [column:dragStop](#columndragstop)
62+
* [column:initializeAfter](#columninitializeafter)
63+
* [image:{{id}}:assignAfter](#imageidassignafter)
64+
* [image:mountAfter](#imagemountafter)
65+
* [image:uploadAfter](#imageuploadafter)
66+
* [stage:interactionStart](#stageinteractionstart)
67+
* [stage:interactionStop](#stageinteractionstop)
68+
* [stage:{{id}}:toggleFullscreen](#stageidtogglefullscreen)
69+
* [previewData:updateAfter](#previewdataupdateafter)
7170
* [previewSortable:sortstart](#previewsortablesortstart)
7271
* [previewSortable:sortupdate](#previewsortablesortupdate)
7372
* [stage:error](#stageerror)
74-
* [stage:ready:{{id}}](#stagereadyid)
75-
* [stage:renderTree:{{id}}](#stagerendertreeid)
76-
* [stage:updated](#stageupdated)
77-
* [focusChild:start](#focuschildstart)
78-
* [focusChild:stop](#focuschildstop)
73+
* [stage:{{id}}:readyAfter](#stageidreadyafter)
74+
* [stage:{{id}}:masterFormatRenderAfter](#stageidmasterformatrenderafter)
75+
* [stage:updateAfter](#stageupdateafter)
76+
* [stage:childFocusStart](#stagechildfocusstart)
77+
* [stage:childFocusStop](#stagechildfocusstop)
7978
* [state](#state)
80-
* [{{id}}:updated](#idupdated)
79+
* [{{config.name}}:{{id}}:updateAfter](#confignameidupdateafter)
8180
* [googleMaps:authFailure](#googlemapsauthFailure)
8281

8382
## `contentType:*` events
84-
All events starting with `contentType:` can also be called for specific content types by prefixing the content types name (`{{name}}:contentType:{{event}}`) like the following:
85-
* `text:contentType:create`
86-
* `row:contentType:ready`
87-
* `tab-item:contentType:mount`
83+
All events starting with `contentType:` can also be called for specific content types by prefixing the content types name (`{{name}}:{{event}}`) like the following:
84+
* `text:createAfter`
85+
* `row:mountAfter`
86+
* `tab-item:mountAfter`
8887

89-
### `contentType:create`
88+
### `contentType:createAfter`
9089

9190
**Triggers**
9291

@@ -104,7 +103,7 @@ All events starting with `contentType:` can also be called for specific content
104103

105104
[Back to top]
106105

107-
### `contentType:ready`
106+
### `contentType:mountAfter`
108107

109108
**Triggers**
110109

@@ -122,7 +121,7 @@ All events starting with `contentType:` can also be called for specific content
122121

123122
[Back to top]
124123

125-
### `contentType:dropped:create`
124+
### `contentType:dropAfter`
126125

127126
**Triggers**
128127

@@ -140,7 +139,7 @@ All events starting with `contentType:` can also be called for specific content
140139

141140
[Back to top]
142141

143-
### `contentType:mount`
142+
### `contentType:mountAfter`
144143

145144
**Triggers**
146145

@@ -158,7 +157,7 @@ All events starting with `contentType:` can also be called for specific content
158157

159158
[Back to top]
160159

161-
### `contentType:afterRender`
160+
### `contentType:renderAfter`
162161

163162
**Triggers**
164163

@@ -176,7 +175,7 @@ All events starting with `contentType:` can also be called for specific content
176175

177176
[Back to top]
178177

179-
### `contentType:removed`
178+
### `contentType:removeAfter`
180179

181180
**Triggers**
182181

@@ -195,7 +194,7 @@ All events starting with `contentType:` can also be called for specific content
195194

196195
[Back to top]
197196

198-
### `contentType:duplicate`
197+
### `contentType:duplicateAfter`
199198

200199
**Triggers**
201200

@@ -213,7 +212,7 @@ All events starting with `contentType:` can also be called for specific content
213212

214213
[Back to top]
215214

216-
### `contentType:beforeMove`
215+
### `contentType:moveBefore`
217216

218217
**Triggers**
219218

@@ -233,7 +232,7 @@ All events starting with `contentType:` can also be called for specific content
233232

234233
[Back to top]
235234

236-
### `contentType:move`
235+
### `contentType:moveAfter`
237236

238237
**Triggers**
239238

@@ -253,7 +252,7 @@ All events starting with `contentType:` can also be called for specific content
253252

254253
[Back to top]
255254

256-
### `column:drag:start`
255+
### `column:dragStart`
257256

258257
**Triggers**
259258

@@ -270,7 +269,7 @@ All events starting with `contentType:` can also be called for specific content
270269

271270
[Back to top]
272271

273-
### `column:drag:stop`
272+
### `column:dragStop`
274273

275274
**Triggers**
276275

@@ -287,7 +286,7 @@ All events starting with `contentType:` can also be called for specific content
287286

288287
[Back to top]
289288

290-
### `column:initElement`
289+
### `column:initializeAfter`
291290

292291
**Triggers**
293292

@@ -305,7 +304,7 @@ All events starting with `contentType:` can also be called for specific content
305304

306305
[Back to top]
307306

308-
### `image:assigned:{{id}}`
307+
### `image:{{id}}:assignAfter`
309308

310309
**Triggers**
311310

@@ -315,7 +314,7 @@ All events starting with `contentType:` can also be called for specific content
315314

316315
object
317316

318-
### `image:contentType:ready`
317+
### `image:mountAfter`
319318

320319
**Triggers**
321320

@@ -327,7 +326,7 @@ Function
327326

328327
[Back to top]
329328

330-
### `image:uploaded`
329+
### `image:uploadAfter`
331330

332331
**Triggers**
333332

@@ -339,7 +338,7 @@ Function
339338

340339
[Back to top]
341340

342-
### `interaction:start`
341+
### `stage:interactionStart`
343342

344343
**Triggers**
345344

@@ -356,7 +355,7 @@ Function
356355

357356
[Back to top]
358357

359-
### `interaction:stop`
358+
### `stage:interactionStop`
360359

361360
**Triggers**
362361

@@ -374,7 +373,7 @@ Function
374373

375374
[Back to top]
376375

377-
### `pagebuilder:toggleFullScreen:{{id}}`
376+
### `stage:{{id}}:toggleFullscreen`
378377

379378
**Triggers**
380379

@@ -388,7 +387,7 @@ Function
388387

389388
[Back to top]
390389

391-
### `previewObservables:updated`
390+
### `previewData:updateAfter`
392391

393392
**Triggers**
394393

@@ -454,14 +453,14 @@ Error
454453

455454
[Back to top]
456455

457-
### `stage:ready:{{id}}`
456+
### `stage:{{id}}:readyAfter`
458457

459458
**Triggers**
460459

461460
* `Stage::ready`
462461
* `stage instance`
463462

464-
### `stage:renderTree:{{id}}`
463+
### `stage:{{id}}:masterFormatRenderAfter`
465464

466465
**Triggers**
467466

@@ -477,7 +476,7 @@ Error
477476

478477
[Back to top]
479478

480-
### `stage:updated`
479+
### `stage:updateAfter`
481480

482481
**Triggers**
483482

@@ -494,11 +493,11 @@ Error
494493

495494
[Back to top]
496495

497-
### `focusChild:start`
496+
### `stage:childFocusStart`
498497

499498
[Back to top]
500499

501-
### `focusChild:stop`
500+
### `stage:childFocusStop`
502501

503502
[Back to top]
504503

@@ -518,7 +517,7 @@ Error
518517

519518
[Back to top]
520519

521-
### `{{id}}:updated`
520+
### `{{config.name}}:{{id}}:updateAfter`
522521

523522
**Triggers**
524523

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_map_form.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
</settings>
132132
</button>
133133
</container>
134-
<dynamicRows name="locations" sortOrder="20" component="Magento_PageBuilder/js/form/components/dynamic-rows" template="Magento_PageBuilder/form/components/dynamic-rows/edit-form-on-click-grid">
134+
<dynamicRows name="locations" sortOrder="20" component="Magento_PageBuilder/js/form/components/map-location-dynamic-rows" template="Magento_PageBuilder/form/components/dynamic-rows/edit-form-on-click-grid">
135135
<argument name="data" xsi:type="array">
136136
<item name="config" xsi:type="array">
137137
<item name="insertFormProvider" xsi:type="string">index = map_location_insert_form</item>

app/code/Magento/PageBuilder/view/adminhtml/web/js/binding/sortable-children.js

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type-collection.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)