MC-5810: Improve naming of the critical variables/parameters in the code and configuration

- Renamed render_template to master_template in php files
- Renamed is_visible to is_system in php files

Author: Hwashiang Yu

app/code/Magento/PageBuilder/Model/Config/ContentType/Converter.php

@@ -133,7 +133,7 @@ private function convertAppearanceData(\DOMElement $appearanceNode): array
         }
         $appearanceData['converters'] = $this->convertConvertersData($appearanceNode);
         $appearanceData['preview_template'] = $this->getAttributeValue($appearanceNode, 'preview_template');
-        $appearanceData['render_template'] = $this->getAttributeValue($appearanceNode, 'render_template');
+        $appearanceData['master_template'] = $this->getAttributeValue($appearanceNode, 'master_template');
         $appearanceData['reader'] = $this->getAttributeValue($appearanceNode, 'reader');
         $appearanceData['default'] = $this->getAttributeValue($appearanceNode, 'default');
         $formNode = $appearanceNode->getElementsByTagName('form')->item(0);

app/code/Magento/PageBuilder/Model/Stage/Config.php

@@ -204,7 +204,7 @@ private function flattenContentTypeData(string $name, array $contentType)
             'additional_data' => isset($contentType['additional_data'])
                 ? $this->additionalDataParser->toArray($contentType['additional_data'])
                 : [],
-            'is_visible' => isset($contentType['is_visible']) && $contentType['is_visible'] === 'false' ? false : true
+            'is_system' => isset($contentType['is_system']) && $contentType['is_system'] === 'false' ? false : true
         ];
     }
 

dev/tests/api-functional/testsuite/Magento/PageBuilder/Api/ProductAttributeRepositoryTest.php

@@ -44,9 +44,9 @@ private function createPageBuilderAttribute($attributeCode)
                 "default_value" => "",
                 "frontend_input" => "textarea",
                 "is_wysiwyg_enabled" => 1,
-                "is_visible_on_front" => true,
+                "is_system_on_front" => true,
                 "is_searchable" => true,
-                "is_visible_in_advanced_search" => true,
+                "is_system_in_advanced_search" => true,
                 "is_filterable" => true,
                 "is_filterable_in_search" => true,
                 \Magento\Framework\Api\ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY => [

dev/tests/integration/_files/Magento/TestModulePageBuilderDataMigration/Setup/InstallSchema.php

@@ -484,7 +484,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
             ['unsigned' => true, 'nullable' => false, 'default' => '0'],
             'Is WYSIWYG Enabled'
         )->addColumn(
-            'is_visible',
+            'is_system',
             \Magento\Framework\DB\Ddl\Table::TYPE_SMALLINT,
             null,
             ['unsigned' => true, 'nullable' => false, 'default' => '1'],

dev/tests/integration/testsuite/Magento/PageBuilder/_files/content_type/expected_merged_array.php

@@ -40,7 +40,7 @@
             'appearances' => [
                 'default' => [
                     'preview_template' => 'Path/to/preview/template',
-                    'render_template' => 'Path/to/render/template',
+                    'master_template' => 'Path/to/render/template',
                     'elements' => [
                         'main' => [
                             'style' => [
@@ -218,7 +218,7 @@
             'icon' => 'pagebuilder-type2-custom-icon',
             'component' => 'Path/to/custom/component',
             'preview_component' => 'Path/to/preview/custom/component',
-            'is_visible' => 'false',
+            'is_system' => 'false',
             'form' => 'pagebuilder_type2_custom_form',
             'group' => 'group2',
             'allowed_parents' => [
@@ -230,7 +230,7 @@
                     'data2' => 'value2',
                     'data3' => 'value3',
                     'preview_template' => 'Path/to/preview/custom/template',
-                    'render_template' => 'Path/to/render/custom/template',
+                    'master_template' => 'Path/to/render/custom/template',
                     'elements' => [
                         'first_element' => [
                             'style' => [
@@ -500,7 +500,7 @@
                 ],
                 'appearance1' => [
                     'preview_template' => 'Path/to/preview/template',
-                    'render_template' => 'Path/to/render/template',
+                    'master_template' => 'Path/to/render/template',
                     'elements' => [
                         'main' => [
                             'style' => [
@@ -546,21 +546,21 @@
                 ],
                 'appearance2' => [
                     'preview_template' => 'Path/to/preview/template',
-                    'render_template' => 'Path/to/render/template',
+                    'master_template' => 'Path/to/render/template',
                     'default' => 'false',
                     'converters' => [],
                     'reader' => 'Path/to/reader'
                 ],
                 'appearance3' => [
                     'preview_template' => 'Path/to/preview/template',
-                    'render_template' => 'Path/to/render/template',
+                    'master_template' => 'Path/to/render/template',
                     'converters' => [],
                     'default' => 'false',
                     'reader' => null
                 ],
                 'appearance4' => [
                     'preview_template' => 'Path/to/preview/template',
-                    'render_template' => 'Path/to/render/template',
+                    'master_template' => 'Path/to/render/template',
                     'elements' => [
                         'main' => [
                             'style' => [
@@ -621,7 +621,7 @@
             'appearances' => [
                 'default' => [
                     'preview_template' => 'Path/to/preview/template',
-                    'render_template' => 'Path/to/render/template',
+                    'master_template' => 'Path/to/render/template',
                     'elements' => [
                         'main' => [
                             'style' => [

dev/tests/integration/testsuite/Magento/PageBuilder/_files/content_type/type3_expected_merged_array.php

@@ -21,7 +21,7 @@
             'appearances' => [
                 'default' => [
                     'preview_template' => 'Path/to/preview/template',
-                    'render_template' => 'Path/to/render/template',
+                    'master_template' => 'Path/to/render/template',
                     'elements' => [
                         'main' => [
                             'style' => [