Skip to content

Commit 8ade9e3

Browse files
committed
MC-35104: Tracking Page Builder content type
- Refactor, clean code
1 parent 30ad42f commit 8ade9e3

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

app/code/Magento/PageBuilderAdminAnalytics/view/adminhtml/web/js/page-builder/event-builder.js

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ define(['underscore'], function (_) {
1919

2020
/**
2121
* Sets up event attributes and action depending on name and args
22-
*
23-
* @param {String} name
24-
* @param {Array} args
2522
*/
2623

2724
switch (arrayName[arrayName.length - 1]) {
@@ -49,15 +46,10 @@ define(['underscore'], function (_) {
4946
break;
5047
}
5148

52-
if (action === 'duplicate' || action === 'hide' || action === 'show') {
53-
eventAttributes =
54-
!_.isUndefined(args.originalContentType) &&
55-
!_.isUndefined(args.originalContentType.config) ?
56-
args.originalContentType.config : {};
57-
} else {
58-
eventAttributes = !_.isUndefined(args.contentType) &&
59-
!_.isUndefined(args.contentType.config) ?
60-
args.contentType.config : {};
49+
if (!_.isUndefined(args.contentType)) {
50+
eventAttributes = args.contentType.config;
51+
} else if (!_.isUndefined(args.originalContentType)) {
52+
eventAttributes = args.originalContentType.config;
6153
}
6254

6355
if (action !== '' && !_.isEmpty(eventAttributes)) {

app/code/Magento/PageBuilderAdminAnalytics/view/adminhtml/web/js/page-builder/events-mixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ define(['underscore', 'Magento_PageBuilderAdminAnalytics/js/page-builder/event-b
3636

3737
if (isAdminAnalyticsEnabled &&
3838
!_.isUndefined(window.digitalData.event) &&
39-
!_.isEmpty(event)) {
39+
!_.isUndefined(event)) {
4040
window.digitalData.event.push(event);
4141
window._satellite.track('event');
4242
}

0 commit comments

Comments
 (0)