Skip to content

Commit 8a9d3bc

Browse files
committed
MAGETWO-89294: Slider Data Separation
- Fix static failures
1 parent 1cf1a86 commit 8a9d3bc

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import ko from "knockout";
77
import $t from "mage/translate";
88
import events from "uiEvents";
9+
import ContentTypeCollectionInterface from "../../content-type-collection";
910
import ContentTypeConfigInterface from "../../content-type-config.d";
1011
import Options from "../../content-type-menu";
1112
import Option from "../../content-type-menu/option";
@@ -17,7 +18,6 @@ import {percentToDecimal} from "../../utils/number-converter";
1718
import ObservableUpdater from "../observable-updater";
1819
import BasePreview from "../preview";
1920
import Uploader from "../uploader";
20-
import ContentTypeCollectionInterface from "../../content-type-collection";
2121

2222
export default class Preview extends BasePreview {
2323
private showOverlayHover: KnockoutObservable<boolean> = ko.observable(false);

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@ import _ from "underscore";
1212
import "../../binding/focus";
1313
import {PreviewSortableSortUpdateEventParams} from "../../binding/sortable-children";
1414
import Config from "../../config";
15+
import ContentTypeCollectionInterface from "../../content-type-collection";
1516
import ContentTypeConfigInterface from "../../content-type-config.d";
1617
import createContentType from "../../content-type-factory";
1718
import Option from "../../content-type-menu/option";
1819
import OptionInterface from "../../content-type-menu/option.d";
1920
import ContentTypeInterface from "../../content-type.d";
21+
import ContentTypeAfterRenderEventParamsInterface from "../content-type-after-render-event-params";
2022
import ContentTypeCreateEventParamsInterface from "../content-type-create-event-params.d";
2123
import ContentTypeMountEventParamsInterface from "../content-type-mount-event-params.d";
2224
import ContentTypeDuplicateEventParamsInterface from "../content-type-ready-event-params.d";
@@ -26,8 +28,6 @@ import ObservableUpdater from "../observable-updater";
2628
import PreviewCollection from "../preview-collection";
2729
import Slide from "../slide/preview";
2830
import {default as SliderPreview} from "../slider/preview";
29-
import ContentTypeAfterRenderEventParamsInterface from "../content-type-after-render-event-params";
30-
import ContentTypeCollectionInterface from "../../content-type-collection";
3131

3232
export default class Preview extends PreviewCollection {
3333
public focusedSlide: KnockoutObservable<number> = ko.observable();
@@ -247,8 +247,6 @@ export default class Preview extends PreviewCollection {
247247
*/
248248
protected bindEvents() {
249249
super.bindEvents();
250-
251-
252250
// We only start forcing the containers height once the slider is ready
253251
let sliderReady: boolean = false;
254252
events.on("slider:contentType:ready", (args: ContentTypeReadyEventParamsInterface) => {

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/tabs/preview.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,21 @@ import $t from "mage/translate";
99
import "tabs";
1010
import events from "uiEvents";
1111
import _ from "underscore";
12+
import {ActiveOptionsInterface} from "../../binding/active-options.d";
1213
import {PreviewSortableSortUpdateEventParams} from "../../binding/sortable-children";
14+
import {SortableOptionsInterface} from "../../binding/sortable-options.d";
1315
import Config from "../../config";
1416
import ContentTypeConfigInterface from "../../content-type-config.d";
1517
import createContentType from "../../content-type-factory";
1618
import Option from "../../content-type-menu/option";
1719
import OptionInterface from "../../content-type-menu/option.d";
1820
import ContentTypeRemovedParamsInterface from "../../content-type-removed-params.d";
1921
import ContentTypeInterface from "../../content-type.d";
20-
import {ContentTypeMountEventParamsInterface} from "../content-type-mount-event-params.d";
21-
import {ContentTypeReadyEventParamsInterface} from "../content-type-ready-event-params.d";
22-
import {ContentTypeRemovedEventParamsInterface} from "../content-type-removed-event-params.d";
22+
import ContentTypeMountEventParamsInterface from "../content-type-mount-event-params.d";
23+
import ContentTypeReadyEventParamsInterface from "../content-type-ready-event-params.d";
24+
import ContentTypeRemovedEventParamsInterface from "../content-type-removed-event-params.d";
2325
import ObservableUpdater from "../observable-updater";
2426
import PreviewCollection from "../preview-collection";
25-
import {ActiveOptionsInterface} from "./active-options.d";
26-
import {SortableOptionsInterface} from "./sortable-options.d";
27-
import ContentTypeAfterRenderEventParamsInterface from "../content-type-after-render-event-params";
2827

2928
export default class Preview extends PreviewCollection {
3029
public static focusOperationTime: number;

0 commit comments

Comments
 (0)