Skip to content

Commit 8a8de3d

Browse files
committed
MC-17823: Access Images/Widgets/Variable from HTML content type
- remove unnecessary assertions - move clean up steps to beginning
1 parent 536ee58 commit 8a8de3d

File tree

2 files changed

+3
-42
lines changed

2 files changed

+3
-42
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderElementContentTypesTests.xml

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -953,15 +953,15 @@
953953
</actionGroup>
954954
</before>
955955
<after>
956+
<deleteData createDataKey="createCMSBlock" stepKey="deleteCMSBlock"/>
957+
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
956958
<actionGroup ref="navigateToMediaGallery" stepKey="navigateToMediaGallery"/>
957959
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="NavigateToFolder2">
958960
<argument name="FolderName" value="{{ImageFolder.name}}"/>
959961
</actionGroup>
960962
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteImageFromStorage2">
961963
<argument name="Image" value="ImageUpload3"/>
962964
</actionGroup>
963-
<deleteData createDataKey="createCMSBlock" stepKey="deleteCMSBlock"/>
964-
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
965965
<actionGroup ref="logout" stepKey="logout"/>
966966
</after>
967967
<!-- Add HTML -->
@@ -1003,23 +1003,6 @@
10031003
<argument name="variable" value="PageBuilderTextArea_VariableBaseURL"/>
10041004
</actionGroup>
10051005
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettingsHtml"/>
1006-
<!-- Validate CMS Block Stage -->
1007-
<comment userInput="Validate CMS Block Stage" stepKey="commentValidateCMSBlockStage"/>
1008-
<seeElement selector="{{HtmlOnStage.base('1')}}" stepKey="seeHtmlBaseCMSBlockStage"/>
1009-
<seeElement selector="{{HtmlOnStage.html('1', PageBuilderHtmlPropertyButton.selector)}}" stepKey="seeHtmlCMSBlockStage"/>
1010-
<executeJS function="return document.querySelectorAll('{{HtmlOnStage.baseCSS}}')[0].innerText;" stepKey="actualTextFromHtmlCode"/>
1011-
<assertContains stepKey="assertWidgetOnStage">
1012-
<expectedResult type="string">{{TinyMCEWidgetCMSPageLink.stageValue}}</expectedResult>
1013-
<actualResult type="variable">actualTextFromHtmlCode</actualResult>
1014-
</assertContains>
1015-
<assertContains stepKey="assertImageOnStage">
1016-
<expectedResult type="string">{{ImageUpload3.value}}</expectedResult>
1017-
<actualResult type="variable">actualTextFromHtmlCode</actualResult>
1018-
</assertContains>
1019-
<assertContains stepKey="assertVariableOnStage">
1020-
<expectedResult type="string">{{TinyMCEVariableBaseURL.stageValue}}</expectedResult>
1021-
<actualResult type="variable">actualTextFromHtmlCode</actualResult>
1022-
</assertContains>
10231006
<actionGroup ref="saveCMSBlock" stepKey="saveCMSBlock"/>
10241007
<!-- Validate CMS Block Stage After Save -->
10251008
<comment userInput="Validate CMS Block Stage After Save" stepKey="commentValidateCMSBlockStageAfterSave"/>
@@ -1038,27 +1021,6 @@
10381021
<expectedResult type="string">{{TinyMCEVariableBaseURL.stageValue}}</expectedResult>
10391022
<actualResult type="variable">actualTextFromHtmlCodeAfterSave</actualResult>
10401023
</assertContains>
1041-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStageAfterSave">
1042-
<argument name="contentType" value="PageBuilderHtmlContentType"/>
1043-
</actionGroup>
1044-
<!-- Validate Edit Panel After Save -->
1045-
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanelAfterSave"/>
1046-
<actionGroup ref="assertTextareaContainsValue" stepKey="assertButtonInTextareaValueAfterSave">
1047-
<argument name="value" value="{{PageBuilderHtmlPropertyButton.value}}"/>
1048-
<argument name="selector" value="{{HtmlOnConfiguration.textarea}}"/>
1049-
</actionGroup>
1050-
<actionGroup ref="assertTextareaContainsValue" stepKey="assertWidgetInTextareaValueAfterSave">
1051-
<argument name="value" value="{{PageBuilderTextArea_WidgetCMSPageLink.editPanelValue}}"/>
1052-
<argument name="selector" value="{{HtmlOnConfiguration.textarea}}"/>
1053-
</actionGroup>
1054-
<actionGroup ref="assertTextareaContainsValue" stepKey="assertImageInTextareaValueAfterSave">
1055-
<argument name="value" value="{{ImageUpload3.value}}"/>
1056-
<argument name="selector" value="{{HtmlOnConfiguration.textarea}}"/>
1057-
</actionGroup>
1058-
<actionGroup ref="assertTextareaContainsValue" stepKey="assertVariableInTextareaValueAfterSave">
1059-
<argument name="value" value="{{PageBuilderTextArea_VariableBaseURL.editPanelValue}}"/>
1060-
<argument name="selector" value="{{HtmlOnConfiguration.textarea}}"/>
1061-
</actionGroup>
10621024
<!-- Add Block to CMS Page -->
10631025
<comment userInput="Add Block to CMS Page" stepKey="commentAddBlockToCMSPage"/>
10641026
<actionGroup ref="navigateToCreatedCMSPage" stepKey="navigateToCreatedCMSPage">
@@ -1105,7 +1067,6 @@
11051067
<click selector="{{HtmlOnStorefront.html('1', PageBuilderHtmlPropertyButton.selectorOnFrontend)}}" stepKey="clickRenderedHtmlButtonCMSPageStorefront"/>
11061068
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccurCMSPageStorefront"/>
11071069
<seeCurrentUrlEquals url="{{PageBuilderHtmlPropertyButton.url}}" stepKey="seeThatUrlIsChangedToHtmlLinkUrl"/>
1108-
<openNewTab stepKey="openNewTab"/>
11091070
<actionGroup ref="navigateToStorefrontForCreatedPage" stepKey="navigateToCMSPageStorefront2">
11101071
<argument name="page" value="$$createCMSPage.identifier$$"/>
11111072
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHtmlTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@
2929
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
3030
</before>
3131
<after>
32+
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
3233
<actionGroup ref="navigateToMediaGallery" stepKey="navigateToMediaGallery"/>
3334
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="NavigateToFolder2">
3435
<argument name="FolderName" value="{{ImageFolder.name}}"/>
3536
</actionGroup>
3637
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteImageFromStorage2">
3738
<argument name="Image" value="ImageUpload3"/>
3839
</actionGroup>
39-
<deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
4040
<actionGroup ref="logout" stepKey="logout"/>
4141
</after>
4242
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">

0 commit comments

Comments
 (0)