Skip to content

Commit 89cca4b

Browse files
committed
MC-4294: Cannot Activate Tab Item After Moving Tabs or Slider to New Parent Container
Rename to TabsMoveTabs and add storefront validation/standard rendering assertions
1 parent 80ff913 commit 89cca4b

File tree

1 file changed

+33
-3
lines changed

1 file changed

+33
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabGroupTests.xml

Lines changed: 33 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,7 +1172,7 @@
11721172
<argument name="containerTargetIndex" value="1" />
11731173
</actionGroup>
11741174
</test>
1175-
<test name="TabsRendersAndIsInteractiveAfterMovingToAnotherContainer">
1175+
<test name="TabsMovesTabs">
11761176
<annotations>
11771177
<features value="PageBuilder"/>
11781178
<stories value="Tab"/>
@@ -1193,6 +1193,9 @@
11931193
<after>
11941194
<actionGroup ref="logout" stepKey="logout"/>
11951195
</after>
1196+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1197+
<argument name="contentType" value="PageBuilderTabsContentType"/>
1198+
</actionGroup>
11961199
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
11971200
<argument name="group" value="PageBuilderTabsContentType"/>
11981201
</actionGroup>
@@ -1204,6 +1207,13 @@
12041207
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
12051208
<argument name="containerTargetIndex" value="2"/>
12061209
</actionGroup>
1210+
<actionGroup ref="validateContentTypeInsideContainerStage" stepKey="validateTabsInsideSecondRowOnStage">
1211+
<argument name="contentType" value="PageBuilderTabsContentType"/>
1212+
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1213+
<argument name="positionInContainer" value="1"/>
1214+
<argument name="contentTypeIndex" value="1"/>
1215+
<argument name="containerTargetIndex" value="2"/>
1216+
</actionGroup>
12071217
<actionGroup ref="dragContentTypeToStageByIndex" stepKey="dragColumnContentTypeToSecondRowContentTypeOnStage">
12081218
<argument name="contentType" value="PageBuilderColumnContentType"/>
12091219
<argument name="contentTypeNumber" value="1"/>
@@ -1214,6 +1224,13 @@
12141224
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
12151225
<argument name="containerTargetIndex" value="1"/>
12161226
</actionGroup>
1227+
<actionGroup ref="validateContentTypeInsideContainerStage" stepKey="validateTabsInsideFirstColumnOnStage">
1228+
<argument name="contentType" value="PageBuilderTabsContentType"/>
1229+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
1230+
<argument name="positionInContainer" value="1"/>
1231+
<argument name="contentTypeIndex" value="1"/>
1232+
<argument name="containerTargetIndex" value="1"/>
1233+
</actionGroup>
12171234
<waitForElementVisible selector="{{TabOnStage.tabHeaderItemActive('1')}}" stepKey="seeFirstTabAsActive"/>
12181235
<actionGroup ref="duplicateSmallContentType" stepKey="duplicateSmallContentType">
12191236
<argument name="section" value="TabOnStage"/>
@@ -1231,7 +1248,20 @@
12311248
</actionGroup>
12321249
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettingsRow1"/>
12331250
<waitForElementVisible selector="{{TabOnStage.tabHeaderItemActive('2')}}" stepKey="seeSecondTabAsActiveAfterChangingRowAppearance"/>
1234-
<click selector="{{TabOnStage.tabHeader('1')}}" stepKey="switchToDefaultTab"/>
1235-
<waitForElementVisible selector="{{TabOnStage.tabHeaderItemActive('1')}}" stepKey="seeFirstTabAsActiveAfterClickingOnIt"/>
1251+
<actionGroup ref="switchTabs" stepKey="switchTabsStage">
1252+
<argument name="section" value="TabOnStage"/>
1253+
<argument name="from" value="2"/>
1254+
<argument name="to" value="1"/>
1255+
</actionGroup>
1256+
<actionGroup ref="saveCmsPage" stepKey="saveCmsPage"/>
1257+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1258+
<argument name="contentType" value="PageBuilderTabsContentType"/>
1259+
</actionGroup>
1260+
<waitForPageLoad stepKey="waitForPageLoadStoreFront" time="30"/>
1261+
<actionGroup ref="switchTabs" stepKey="switchTabsStorefront">
1262+
<argument name="section" value="TabOnStorefront"/>
1263+
<argument name="from" value="1"/>
1264+
<argument name="to" value="2"/>
1265+
</actionGroup>
12361266
</test>
12371267
</tests>

0 commit comments

Comments
 (0)