Skip to content

Commit 8744367

Browse files
committed
#636: Responsive breakpoint switcher - fixed failed tests ViewportSwitcherMobileBannerUploadImageFromStageTest.xml, ViewportSwitcherMobileSlideItemUploadImageFromStageTest.xml
1 parent 4d63a4f commit 8744367

File tree

2 files changed

+10
-22
lines changed

2 files changed

+10
-22
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileBannerUploadImageFromStageTest.xml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,12 @@
5050
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
5151
<argument name="contentType" value="PageBuilderBannerContentType"/>
5252
</actionGroup>
53-
<!-- Validate Stage Mobile Viewport -->
5453
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons">
5554
<argument name="contentType" value="PageBuilderBannerContentType"/>
5655
</actionGroup>
5756
<attachFile selector="{{PageBuilderStage.uploadImageInput('1')}}" userInput="{{PageBuilderImageProperty_JPG.value}}" stepKey="attachImageFromLocalToStage"/>
57+
<waitForPageLoad stepKey="waitForPageLoad"/>
58+
<!-- Validate Stage Mobile Viewport -->
5859
<actionGroup ref="ValidateBackgroundImageConfigurationActionGroup" stepKey="validateBackgroundImageStage">
5960
<argument name="section" value="BannerOnBackend"/>
6061
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>
@@ -75,10 +76,6 @@
7576
<argument name="viewportButton" value="desktop"/>
7677
<argument name="viewportStage" value="desktop"/>
7778
</actionGroup>
78-
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons2">
79-
<argument name="contentType" value="PageBuilderBannerContentType"/>
80-
</actionGroup>
81-
<attachFile selector="{{PageBuilderStage.uploadImageInput('1')}}" userInput="{{PageBuilderImageProperty_JPG.value}}" stepKey="attachImageFromLocalToStage2"/>
8279
<actionGroup ref="ValidateBackgroundImageConfigurationActionGroup" stepKey="validateBackgroundImageStage2">
8380
<argument name="section" value="BannerOnBackend"/>
8481
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/ViewportSwitcherMobile/ViewportSwitcherMobileSlideItemUploadImageFromStageTest.xml

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,13 @@
5050
<actionGroup ref="dragContentTypeToStage" stepKey="dragSliderOntoStage">
5151
<argument name="contentType" value="PageBuilderSliderContentType"/>
5252
</actionGroup>
53-
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
54-
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
55-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
56-
<!-- Validate Stage After Save Desktop Viewport -->
57-
<actionGroup ref="unFocusOptionMenu" stepKey="unFocusOptionMenu">
58-
<argument name="contentType" value="PageBuilderSlideContentType"/>
59-
</actionGroup>
53+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide"/>
6054
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons">
6155
<argument name="contentType" value="PageBuilderSliderContentType"/>
6256
</actionGroup>
6357
<attachFile selector="{{PageBuilderStage.uploadImageInput('1')}}" userInput="{{PageBuilderImageProperty_JPG.value}}" stepKey="attachImageFromLocalToStage"/>
6458
<waitForPageLoad stepKey="waitForPageLoad"/>
59+
<!-- Validate Stage Mobile Viewport -->
6560
<actionGroup ref="ValidateBackgroundImageConfigurationActionGroup" stepKey="validateBackgroundImageStage">
6661
<argument name="section" value="SlideOnBackend"/>
6762
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>
@@ -77,17 +72,11 @@
7772
<argument name="property" value="PageBuilderBackgroundImage_JPG"/>
7873
</actionGroup>
7974
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
80-
<!-- Validate Stage After Save Mobile Viewport -->
81-
<actionGroup ref="AdminSwitchPageBuilderViewportActionGroup" stepKey="switchToMobileViewportAfterSave">
82-
<argument name="viewportButton" value="mobile"/>
83-
<argument name="viewportStage" value="mobile"/>
75+
<!-- Validate Stage Desktop Viewport -->
76+
<actionGroup ref="AdminSwitchPageBuilderViewportActionGroup" stepKey="switchToDesktopViewport">
77+
<argument name="viewportButton" value="desktop"/>
78+
<argument name="viewportStage" value="desktop"/>
8479
</actionGroup>
85-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusSlide2"/>
86-
<actionGroup ref="verifyUploadImageButtons" stepKey="verifyUploadImageButtons2">
87-
<argument name="contentType" value="PageBuilderSliderContentType"/>
88-
</actionGroup>
89-
<attachFile selector="{{PageBuilderStage.uploadImageInput('1')}}" userInput="{{PageBuilderImageProperty_JPG.value}}" stepKey="attachImageFromLocalToStage2"/>
90-
<waitForPageLoad stepKey="waitForPageLoad2"/>
9180
<actionGroup ref="ValidateBackgroundImageConfigurationActionGroup" stepKey="validateBackgroundImageStage2">
9281
<argument name="section" value="SlideOnBackend"/>
9382
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>
@@ -103,6 +92,8 @@
10392
<argument name="property" value="PageBuilderBackgroundImage_JPG"/>
10493
</actionGroup>
10594
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings2"/>
95+
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
96+
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
10697
<!-- Navigate To Storefront -->
10798
<actionGroup ref="NavigateToStorefrontForCreatedPageActionGroup" stepKey="navigateToCMSPageStorefront">
10899
<argument name="page" value="$$createPreReqCMSPage.identifier$$"/>

0 commit comments

Comments
 (0)